From: Jens Axboe <axboe@kernel.dk>
To: Johannes Thumshirn <jthumshirn@suse.de>,
Keith Busch <keith.busch@intel.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: change order of qid and cmdid in completion trace
Date: Thu, 26 Apr 2018 14:01:59 -0600 [thread overview]
Message-ID: <3e927f7f-fa84-1792-b80e-bf5679e71bcf@kernel.dk> (raw)
In-Reply-To: <20180426194926.18767-1-jthumshirn@suse.de>
On 4/26/18 1:49 PM, Johannes Thumshirn wrote:
> Keith reported that command submission and command completion
> tracepoints have the order of the cmdid and qid fileds swapped.
>
> While it isn't easily possible to change the command submission
> tracepoint, as there is a regression test parsing it in blktests we
> can swap the command completion tracepoint to have the fileds aligned.
It also makes more sense to have qid before cmdid.
Also, fileds -> fields, in two spots.
With that:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH] nvme: change order of qid and cmdid in completion trace
Date: Thu, 26 Apr 2018 14:01:59 -0600 [thread overview]
Message-ID: <3e927f7f-fa84-1792-b80e-bf5679e71bcf@kernel.dk> (raw)
In-Reply-To: <20180426194926.18767-1-jthumshirn@suse.de>
On 4/26/18 1:49 PM, Johannes Thumshirn wrote:
> Keith reported that command submission and command completion
> tracepoints have the order of the cmdid and qid fileds swapped.
>
> While it isn't easily possible to change the command submission
> tracepoint, as there is a regression test parsing it in blktests we
> can swap the command completion tracepoint to have the fileds aligned.
It also makes more sense to have qid before cmdid.
Also, fileds -> fields, in two spots.
With that:
Reviewed-by: Jens Axboe <axboe at kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2018-04-26 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 19:49 [PATCH] nvme: change order of qid and cmdid in completion trace Johannes Thumshirn
2018-04-26 19:49 ` Johannes Thumshirn
2018-04-26 20:01 ` Jens Axboe [this message]
2018-04-26 20:01 ` Jens Axboe
2018-04-26 20:21 ` Johannes Thumshirn
2018-04-26 20:21 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e927f7f-fa84-1792-b80e-bf5679e71bcf@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.