All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Nicolas Dechesne <nicolas.dechesne@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: codecs: msm8916-wcd-analog: fix module autoload
Date: Tue, 3 Oct 2017 21:43:20 +0100	[thread overview]
Message-ID: <3e9c07c1-1262-9362-b867-9b0f1da42fc9@linaro.org> (raw)
In-Reply-To: <20171003094951.10692-1-nicolas.dechesne@linaro.org>



On 03/10/17 10:49, Nicolas Dechesne wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo snd_soc_msm8916_analog | grep alias
> $
> 
> After this patch:
> 
> $ modinfo snd_soc_msm8916_analog | grep alias
> alias:          of:N*T*Cqcom,pm8916-wcd-analog-codecC*
> alias:          of:N*T*Cqcom,pm8916-wcd-analog-codec
> 
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Thanks for the patch

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---
>   sound/soc/codecs/msm8916-wcd-analog.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 549c269acc7d..d79e5b35e003 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -1241,6 +1241,8 @@ static const struct of_device_id pm8916_wcd_analog_spmi_match_table[] = {
>   	{ }
>   };
>   
> +MODULE_DEVICE_TABLE(of, pm8916_wcd_analog_spmi_match_table);
> +
>   static struct platform_driver pm8916_wcd_analog_spmi_driver = {
>   	.driver = {
>   		   .name = "qcom,pm8916-wcd-spmi-codec",
> 

WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Nicolas Dechesne <nicolas.dechesne@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: msm8916-wcd-analog: fix module autoload
Date: Tue, 3 Oct 2017 21:43:20 +0100	[thread overview]
Message-ID: <3e9c07c1-1262-9362-b867-9b0f1da42fc9@linaro.org> (raw)
In-Reply-To: <20171003094951.10692-1-nicolas.dechesne@linaro.org>



On 03/10/17 10:49, Nicolas Dechesne wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo snd_soc_msm8916_analog | grep alias
> $
> 
> After this patch:
> 
> $ modinfo snd_soc_msm8916_analog | grep alias
> alias:          of:N*T*Cqcom,pm8916-wcd-analog-codecC*
> alias:          of:N*T*Cqcom,pm8916-wcd-analog-codec
> 
> Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Thanks for the patch

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---
>   sound/soc/codecs/msm8916-wcd-analog.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 549c269acc7d..d79e5b35e003 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -1241,6 +1241,8 @@ static const struct of_device_id pm8916_wcd_analog_spmi_match_table[] = {
>   	{ }
>   };
>   
> +MODULE_DEVICE_TABLE(of, pm8916_wcd_analog_spmi_match_table);
> +
>   static struct platform_driver pm8916_wcd_analog_spmi_driver = {
>   	.driver = {
>   		   .name = "qcom,pm8916-wcd-spmi-codec",
> 

  reply	other threads:[~2017-10-03 20:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03  9:49 [PATCH] ASoC: codecs: msm8916-wcd-analog: fix module autoload Nicolas Dechesne
2017-10-03 20:43 ` Srinivas Kandagatla [this message]
2017-10-03 20:43   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e9c07c1-1262-9362-b867-9b0f1da42fc9@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.dechesne@linaro.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.