All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: Add amdkfd softdep
@ 2016-08-25 17:10 Michal Marek
  2016-08-26  2:20 ` Michel Dänzer
  0 siblings, 1 reply; 6+ messages in thread
From: Michal Marek @ 2016-08-25 17:10 UTC (permalink / raw)
  To: Oded Gabbay; +Cc: Martin Jambor, dri-devel

amdgpu loads amdkfd via symbol_request(). Add a softdep hint so that
userspace knows that amdgpu needs amdkfd in the initrd.

Reported-and-tested-by: Martin Jambor <mjambor@suse.cz>
Signed-off-by: Michal Marek <mmarek@suse.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 9aa533cf4ad1..9c469cd311ca 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -633,3 +633,4 @@ module_exit(amdgpu_exit);
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+MODULE_SOFTDEP("pre: amdkfd");
-- 
2.6.6

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Add amdkfd softdep
  2016-08-25 17:10 [PATCH] drm/amdgpu: Add amdkfd softdep Michal Marek
@ 2016-08-26  2:20 ` Michel Dänzer
  2016-08-26  9:16   ` Michal Marek
  0 siblings, 1 reply; 6+ messages in thread
From: Michel Dänzer @ 2016-08-26  2:20 UTC (permalink / raw)
  To: Michal Marek, Oded Gabbay; +Cc: Martin Jambor, dri-devel

On 26/08/16 02:10 AM, Michal Marek wrote:
> amdgpu loads amdkfd via symbol_request(). Add a softdep hint so that
> userspace knows that amdgpu needs amdkfd in the initrd.
> 
> Reported-and-tested-by: Martin Jambor <mjambor@suse.cz>
> Signed-off-by: Michal Marek <mmarek@suse.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 9aa533cf4ad1..9c469cd311ca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -633,3 +633,4 @@ module_exit(amdgpu_exit);
>  MODULE_AUTHOR(DRIVER_AUTHOR);
>  MODULE_DESCRIPTION(DRIVER_DESC);
>  MODULE_LICENSE("GPL and additional rights");
> +MODULE_SOFTDEP("pre: amdkfd");

Will this work if amdkfd isn't built (CONFIG_HSA_AMD=n)?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Add amdkfd softdep
  2016-08-26  2:20 ` Michel Dänzer
@ 2016-08-26  9:16   ` Michal Marek
  2016-08-29  1:37     ` Michel Dänzer
  0 siblings, 1 reply; 6+ messages in thread
From: Michal Marek @ 2016-08-26  9:16 UTC (permalink / raw)
  To: Michel Dänzer; +Cc: Martin Jambor, dri-devel

On 2016-08-26 04:20, Michel Dänzer wrote:
> On 26/08/16 02:10 AM, Michal Marek wrote:
>> amdgpu loads amdkfd via symbol_request(). Add a softdep hint so that
>> userspace knows that amdgpu needs amdkfd in the initrd.
>>
>> Reported-and-tested-by: Martin Jambor <mjambor@suse.cz>
>> Signed-off-by: Michal Marek <mmarek@suse.com>
>> ---
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 9aa533cf4ad1..9c469cd311ca 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -633,3 +633,4 @@ module_exit(amdgpu_exit);
>>  MODULE_AUTHOR(DRIVER_AUTHOR);
>>  MODULE_DESCRIPTION(DRIVER_DESC);
>>  MODULE_LICENSE("GPL and additional rights");
>> +MODULE_SOFTDEP("pre: amdkfd");
> 
> Will this work if amdkfd isn't built (CONFIG_HSA_AMD=n)?

It's a soft dependency, so it will be silently ignored. /sbin/modprobe
--show-depends amdgpu will only list amdgpu.ko and its hard depedencies.

Michal

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Add amdkfd softdep
  2016-08-26  9:16   ` Michal Marek
@ 2016-08-29  1:37     ` Michel Dänzer
  2016-08-29 12:55       ` [PATCH v2] amdgpu, radeon: " Michal Marek
  2016-08-29 13:03       ` [PATCH] drm/amdgpu: " Michal Marek
  0 siblings, 2 replies; 6+ messages in thread
From: Michel Dänzer @ 2016-08-29  1:37 UTC (permalink / raw)
  To: Michal Marek; +Cc: Martin Jambor, dri-devel

On 26/08/16 06:16 PM, Michal Marek wrote:
> On 2016-08-26 04:20, Michel Dänzer wrote:
>> On 26/08/16 02:10 AM, Michal Marek wrote:
>>> amdgpu loads amdkfd via symbol_request(). Add a softdep hint so that
>>> userspace knows that amdgpu needs amdkfd in the initrd.
>>>
>>> Reported-and-tested-by: Martin Jambor <mjambor@suse.cz>
>>> Signed-off-by: Michal Marek <mmarek@suse.com>
>>> ---
>>>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> index 9aa533cf4ad1..9c469cd311ca 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> @@ -633,3 +633,4 @@ module_exit(amdgpu_exit);
>>>  MODULE_AUTHOR(DRIVER_AUTHOR);
>>>  MODULE_DESCRIPTION(DRIVER_DESC);
>>>  MODULE_LICENSE("GPL and additional rights");
>>> +MODULE_SOFTDEP("pre: amdkfd");
>>
>> Will this work if amdkfd isn't built (CONFIG_HSA_AMD=n)?
> 
> It's a soft dependency, so it will be silently ignored. /sbin/modprobe
> --show-depends amdgpu will only list amdgpu.ko and its hard depedencies.

Thanks for the clarification.

The radeon driver probably needs this as well?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] amdgpu, radeon: Add amdkfd softdep
  2016-08-29  1:37     ` Michel Dänzer
@ 2016-08-29 12:55       ` Michal Marek
  2016-08-29 13:03       ` [PATCH] drm/amdgpu: " Michal Marek
  1 sibling, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-08-29 12:55 UTC (permalink / raw)
  To: Michel Dänzer, Oded Gabbay; +Cc: Martin Jambor, dri-devel

Both amdgpu and radeon load amdkfd via symbol_request(). Add a softdep
hint so that userspace knows that each of them needs amdkfd in the
initrd.

Reported-and-tested-by: Martin Jambor <mjambor@suse.cz> [amdgpu]
Reported-by: Michel Dänzer <michel@daenzer.net> [radeon]
Signed-off-by: Michal Marek <mmarek@suse.com>
---
v2: Also patch radeon

 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +
 drivers/gpu/drm/radeon/radeon_drv.c     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 9aa533cf4ad1..9c469cd311ca 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -633,3 +633,4 @@ module_exit(amdgpu_exit);
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+MODULE_SOFTDEP("pre: amdkfd");
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index c01a7c6abb49..0a60125c0138 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -617,3 +617,4 @@ module_exit(radeon_exit);
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL and additional rights");
+MODULE_SOFTDEP("pre: amdkfd");
-- 
2.6.6

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Add amdkfd softdep
  2016-08-29  1:37     ` Michel Dänzer
  2016-08-29 12:55       ` [PATCH v2] amdgpu, radeon: " Michal Marek
@ 2016-08-29 13:03       ` Michal Marek
  1 sibling, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-08-29 13:03 UTC (permalink / raw)
  To: Michel Dänzer; +Cc: Martin Jambor, dri-devel

On 2016-08-29 03:37, Michel Dänzer wrote:
> On 26/08/16 06:16 PM, Michal Marek wrote:
>> It's a soft dependency, so it will be silently ignored. /sbin/modprobe
>> --show-depends amdgpu will only list amdgpu.ko and its hard depedencies.
> 
> Thanks for the clarification.
> 
> The radeon driver probably needs this as well?

You are right. I sent a v2 covering radeon as well.

Thanks,
Michal
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-29 13:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-25 17:10 [PATCH] drm/amdgpu: Add amdkfd softdep Michal Marek
2016-08-26  2:20 ` Michel Dänzer
2016-08-26  9:16   ` Michal Marek
2016-08-29  1:37     ` Michel Dänzer
2016-08-29 12:55       ` [PATCH v2] amdgpu, radeon: " Michal Marek
2016-08-29 13:03       ` [PATCH] drm/amdgpu: " Michal Marek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.