* [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused
@ 2023-03-10 21:44 Krzysztof Kozlowski
2023-03-11 0:04 ` Konrad Dybcio
2023-03-15 23:35 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 21:44 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, linux-arm-msm, linux-kernel
Cc: Krzysztof Kozlowski
The driver can be compile tested with !CONFIG_OF making certain data
unused:
drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/soc/qcom/qcom_gsbi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
index 290bdefbf28a..f1742e5bddb9 100644
--- a/drivers/soc/qcom/qcom_gsbi.c
+++ b/drivers/soc/qcom/qcom_gsbi.c
@@ -114,7 +114,7 @@ struct gsbi_info {
struct regmap *tcsr;
};
-static const struct of_device_id tcsr_dt_match[] = {
+static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
{ .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
{ .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
{ .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused
2023-03-10 21:44 [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused Krzysztof Kozlowski
@ 2023-03-11 0:04 ` Konrad Dybcio
2023-03-11 0:05 ` Konrad Dybcio
2023-03-15 23:35 ` Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2023-03-11 0:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, linux-arm-msm,
linux-kernel
On 10.03.2023 22:44, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Shouldn't this driver depend on OF?
Konrad
> drivers/soc/qcom/qcom_gsbi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
> index 290bdefbf28a..f1742e5bddb9 100644
> --- a/drivers/soc/qcom/qcom_gsbi.c
> +++ b/drivers/soc/qcom/qcom_gsbi.c
> @@ -114,7 +114,7 @@ struct gsbi_info {
> struct regmap *tcsr;
> };
>
> -static const struct of_device_id tcsr_dt_match[] = {
> +static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
> { .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
> { .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
> { .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused
2023-03-11 0:04 ` Konrad Dybcio
@ 2023-03-11 0:05 ` Konrad Dybcio
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-03-11 0:05 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, linux-arm-msm,
linux-kernel
On 11.03.2023 01:04, Konrad Dybcio wrote:
>
>
> On 10.03.2023 22:44, Krzysztof Kozlowski wrote:
>> The driver can be compile tested with !CONFIG_OF making certain data
>> unused:
>>
>> drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> Shouldn't this driver depend on OF?
>
Nevermind, can't read.
Konrad
> Konrad
>> drivers/soc/qcom/qcom_gsbi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
>> index 290bdefbf28a..f1742e5bddb9 100644
>> --- a/drivers/soc/qcom/qcom_gsbi.c
>> +++ b/drivers/soc/qcom/qcom_gsbi.c
>> @@ -114,7 +114,7 @@ struct gsbi_info {
>> struct regmap *tcsr;
>> };
>>
>> -static const struct of_device_id tcsr_dt_match[] = {
>> +static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
>> { .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
>> { .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
>> { .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused
2023-03-10 21:44 [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 0:04 ` Konrad Dybcio
@ 2023-03-15 23:35 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-03-15 23:35 UTC (permalink / raw)
To: linux-arm-msm, Konrad Dybcio, Krzysztof Kozlowski, linux-kernel,
Andy Gross
On Fri, 10 Mar 2023 22:44:13 +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
>
>
Applied, thanks!
[1/1] soc: qcom: gsbi: mark OF related data as maybe unused
commit: 903caf42eabec2e39d836cb0aa8bbc23717408e7
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-15 23:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10 21:44 [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 0:04 ` Konrad Dybcio
2023-03-11 0:05 ` Konrad Dybcio
2023-03-15 23:35 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.