From: Dean Nelson <dnelson@redhat.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Robert Richter <rric@kernel.org>,
Sunil Goutham <sgoutham@cavium.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Vadim Lomovtsev <vlomovtsev@marvell.com>
Subject: Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case
Date: Tue, 26 Mar 2019 09:44:19 -0500 [thread overview]
Message-ID: <3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com> (raw)
In-Reply-To: <20190326153916.530d472e@carbon>
On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote:
> On Tue, 26 Mar 2019 10:04:47 -0400
> Dean Nelson <dnelson@redhat.com> wrote:
>
>> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently
>> disables receive buffer page recycling for the non-XDP case by always NULL'ng
>> the page pointer.
>>
>> This patch corrects two if-conditionals to allow for the recycling of non-XDP
>> mode pages by only setting the page pointer to NULL when the page is not ready
>> for recycling.
>>
>> Signed-off-by: Dean Nelson <dnelson@redhat.com>
>
> You need to add a "fixes" line like this:
>
> Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP")
>
> And in-general reference a commit in the same way in the description.
Sorry, for some reason I thought the 'Fixes' line was optional.
Thank you for setting me straight. Should I repost the patchset?
WARNING: multiple messages have this Message-ID (diff)
From: Dean Nelson <dnelson@redhat.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Sunil Goutham <sgoutham@cavium.com>,
Robert Richter <rric@kernel.org>,
netdev@vger.kernel.org, Vadim Lomovtsev <vlomovtsev@marvell.com>,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case
Date: Tue, 26 Mar 2019 09:44:19 -0500 [thread overview]
Message-ID: <3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com> (raw)
In-Reply-To: <20190326153916.530d472e@carbon>
On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote:
> On Tue, 26 Mar 2019 10:04:47 -0400
> Dean Nelson <dnelson@redhat.com> wrote:
>
>> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently
>> disables receive buffer page recycling for the non-XDP case by always NULL'ng
>> the page pointer.
>>
>> This patch corrects two if-conditionals to allow for the recycling of non-XDP
>> mode pages by only setting the page pointer to NULL when the page is not ready
>> for recycling.
>>
>> Signed-off-by: Dean Nelson <dnelson@redhat.com>
>
> You need to add a "fixes" line like this:
>
> Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP")
>
> And in-general reference a commit in the same way in the description.
Sorry, for some reason I thought the 'Fixes' line was optional.
Thank you for setting me straight. Should I repost the patchset?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-26 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 14:04 [PATCH net 0/2] thunderx: fix receive buffer page recycling Dean Nelson
2019-03-26 14:04 ` [PATCH net 1/2] thunderx: enable page recycling for non-XDP case Dean Nelson
2019-03-26 14:39 ` Jesper Dangaard Brouer
2019-03-26 14:39 ` Jesper Dangaard Brouer
2019-03-26 14:44 ` Dean Nelson [this message]
2019-03-26 14:44 ` Dean Nelson
2019-03-26 14:59 ` Jesper Dangaard Brouer
2019-03-26 14:59 ` Jesper Dangaard Brouer
2019-03-26 15:39 ` Dean Nelson
2019-03-26 15:39 ` Dean Nelson
2019-03-26 14:04 ` [PATCH net 2/2] thunderx: eliminate extra calls to put_page() for pages held for recycling Dean Nelson
2019-03-26 15:39 ` [PATCH net 0/2] thunderx: fix receive buffer page recycling Dean Nelson
2019-03-26 15:39 ` Dean Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com \
--to=dnelson@redhat.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
--cc=vlomovtsev@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.