All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: "Cédric Le Goater" <clg@kaod.org>, "Joel Stanley" <joel@jms.id.au>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc
Date: Wed, 21 Sep 2016 11:34:10 -0500	[thread overview]
Message-ID: <3eafb21f-f716-c04b-41c6-ce2f4e7701f7@acm.org> (raw)
In-Reply-To: <789d8d52-7ce0-deee-617b-2502a7a3eb93@kaod.org>

On 09/21/2016 05:17 AM, Cédric Le Goater wrote:
> On 09/21/2016 12:05 PM, Joel Stanley wrote:
>> devm_ioremap_resource returns ERR_PTR so we can't check for NULL.
> Thanks for spotting this.
>
> Acked-by: Cédric Le Goater <clg@kaod.org>

Thanks, I've pull this into my tree.

-corey

> C.
>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>>   drivers/char/ipmi/bt-bmc.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
>> index 2e880bf0be26..de64bf1f2f4d 100644
>> --- a/drivers/char/ipmi/bt-bmc.c
>> +++ b/drivers/char/ipmi/bt-bmc.c
>> @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev)
>>   	}
>>   
>>   	bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);
>> -	if (!bt_bmc->base)
>> -		return -ENOMEM;
>> +	if (IS_ERR(bt_bmc->base))
>> +		return PTR_ERR(bt_bmc->base);
>>   
>>   	mutex_init(&bt_bmc->mutex);
>>   	init_waitqueue_head(&bt_bmc->queue);
>>

      reply	other threads:[~2016-09-21 16:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 10:05 [PATCH] ipmi: Fix ioremap error handling in bt-bmc Joel Stanley
2016-09-21 10:17 ` Cédric Le Goater
2016-09-21 16:34   ` Corey Minyard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3eafb21f-f716-c04b-41c6-ce2f4e7701f7@acm.org \
    --to=minyard@acm.org \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.