* [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
@ 2016-10-13 8:30 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-10-13 8:30 UTC (permalink / raw)
To: David Woodhouse, Graham Moore
Cc: Brian Norris, Marek Vasut, linux-mtd, kernel-janitors
We return success or possibly uninitialized values on these error paths
instead of proper error codes.
Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c
index 944863b..d489fbd 100644
--- a/drivers/mtd/spi-nor/cadence-quadspi.c
+++ b/drivers/mtd/spi-nor/cadence-quadspi.c
@@ -1077,12 +1077,14 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi, struct device_node *np)
/* Get flash device data */
for_each_available_child_of_node(dev->of_node, np) {
- if (of_property_read_u32(np, "reg", &cs)) {
+ ret = of_property_read_u32(np, "reg", &cs);
+ if (ret) {
dev_err(dev, "Couldn't determine chip select.\n");
goto err;
}
if (cs >= CQSPI_MAX_CHIPSELECT) {
+ ret = -EINVAL;
dev_err(dev, "Chip select %d out of range.\n", cs);
goto err;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
@ 2016-10-13 8:30 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-10-13 8:30 UTC (permalink / raw)
To: David Woodhouse, Graham Moore
Cc: Brian Norris, Marek Vasut, linux-mtd, kernel-janitors
We return success or possibly uninitialized values on these error paths
instead of proper error codes.
Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c
index 944863b..d489fbd 100644
--- a/drivers/mtd/spi-nor/cadence-quadspi.c
+++ b/drivers/mtd/spi-nor/cadence-quadspi.c
@@ -1077,12 +1077,14 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi, struct device_node *np)
/* Get flash device data */
for_each_available_child_of_node(dev->of_node, np) {
- if (of_property_read_u32(np, "reg", &cs)) {
+ ret = of_property_read_u32(np, "reg", &cs);
+ if (ret) {
dev_err(dev, "Couldn't determine chip select.\n");
goto err;
}
if (cs >= CQSPI_MAX_CHIPSELECT) {
+ ret = -EINVAL;
dev_err(dev, "Chip select %d out of range.\n", cs);
goto err;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
2016-10-13 8:30 ` Dan Carpenter
@ 2016-10-14 7:16 ` Marek Vasut
-1 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2016-10-14 7:16 UTC (permalink / raw)
To: Dan Carpenter, David Woodhouse, Graham Moore
Cc: Brian Norris, linux-mtd, kernel-janitors
On 10/13/2016 10:30 AM, Dan Carpenter wrote:
> We return success or possibly uninitialized values on these error paths
> instead of proper error codes.
>
> Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Nice
Reviewed-by: Marek Vasut <marex@denx.de>
> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c
> index 944863b..d489fbd 100644
> --- a/drivers/mtd/spi-nor/cadence-quadspi.c
> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c
> @@ -1077,12 +1077,14 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi, struct device_node *np)
>
> /* Get flash device data */
> for_each_available_child_of_node(dev->of_node, np) {
> - if (of_property_read_u32(np, "reg", &cs)) {
> + ret = of_property_read_u32(np, "reg", &cs);
> + if (ret) {
> dev_err(dev, "Couldn't determine chip select.\n");
> goto err;
> }
>
> if (cs >= CQSPI_MAX_CHIPSELECT) {
> + ret = -EINVAL;
> dev_err(dev, "Chip select %d out of range.\n", cs);
> goto err;
> }
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
@ 2016-10-14 7:16 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2016-10-14 7:16 UTC (permalink / raw)
To: Dan Carpenter, David Woodhouse, Graham Moore
Cc: Brian Norris, linux-mtd, kernel-janitors
On 10/13/2016 10:30 AM, Dan Carpenter wrote:
> We return success or possibly uninitialized values on these error paths
> instead of proper error codes.
>
> Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Nice
Reviewed-by: Marek Vasut <marex@denx.de>
> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c
> index 944863b..d489fbd 100644
> --- a/drivers/mtd/spi-nor/cadence-quadspi.c
> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c
> @@ -1077,12 +1077,14 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi, struct device_node *np)
>
> /* Get flash device data */
> for_each_available_child_of_node(dev->of_node, np) {
> - if (of_property_read_u32(np, "reg", &cs)) {
> + ret = of_property_read_u32(np, "reg", &cs);
> + if (ret) {
> dev_err(dev, "Couldn't determine chip select.\n");
> goto err;
> }
>
> if (cs >= CQSPI_MAX_CHIPSELECT) {
> + ret = -EINVAL;
> dev_err(dev, "Chip select %d out of range.\n", cs);
> goto err;
> }
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
2016-10-14 7:16 ` Marek Vasut
@ 2016-10-15 22:09 ` Moritz Fischer
-1 siblings, 0 replies; 8+ messages in thread
From: Moritz Fischer @ 2016-10-15 22:09 UTC (permalink / raw)
To: Marek Vasut
Cc: Dan Carpenter, David Woodhouse, Graham Moore, kernel-janitors,
Brian Norris, linux-mtd
On Fri, Oct 14, 2016 at 9:16 AM, Marek Vasut <marex@denx.de> wrote:
> On 10/13/2016 10:30 AM, Dan Carpenter wrote:
>> We return success or possibly uninitialized values on these error paths
>> instead of proper error codes.
>>
>> Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>
> Nice
>
> Reviewed-by: Marek Vasut <marex@denx.de>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
Thanks,
Moritz
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
@ 2016-10-15 22:09 ` Moritz Fischer
0 siblings, 0 replies; 8+ messages in thread
From: Moritz Fischer @ 2016-10-15 22:09 UTC (permalink / raw)
To: Marek Vasut
Cc: Dan Carpenter, David Woodhouse, Graham Moore, kernel-janitors,
Brian Norris, linux-mtd
On Fri, Oct 14, 2016 at 9:16 AM, Marek Vasut <marex@denx.de> wrote:
> On 10/13/2016 10:30 AM, Dan Carpenter wrote:
>> We return success or possibly uninitialized values on these error paths
>> instead of proper error codes.
>>
>> Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>
> Nice
>
> Reviewed-by: Marek Vasut <marex@denx.de>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
Thanks,
Moritz
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
2016-10-15 22:09 ` Moritz Fischer
@ 2016-11-28 8:20 ` Cyrille Pitchen
-1 siblings, 0 replies; 8+ messages in thread
From: Cyrille Pitchen @ 2016-11-28 8:20 UTC (permalink / raw)
To: Moritz Fischer, Marek Vasut
Cc: kernel-janitors, linux-mtd, Brian Norris, David Woodhouse,
Dan Carpenter, Graham Moore
Le 16/10/2016 à 00:09, Moritz Fischer a écrit :
> On Fri, Oct 14, 2016 at 9:16 AM, Marek Vasut <marex@denx.de> wrote:
>> On 10/13/2016 10:30 AM, Dan Carpenter wrote:
>>> We return success or possibly uninitialized values on these error paths
>>> instead of proper error codes.
>>>
>>> Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>
>> Nice
>>
>> Reviewed-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
Applied to git://github.com/spi-nor/linux.git
Thanks!
>
> Thanks,
>
> Moritz
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash()
@ 2016-11-28 8:20 ` Cyrille Pitchen
0 siblings, 0 replies; 8+ messages in thread
From: Cyrille Pitchen @ 2016-11-28 8:20 UTC (permalink / raw)
To: Moritz Fischer, Marek Vasut
Cc: kernel-janitors, linux-mtd, Brian Norris, David Woodhouse,
Dan Carpenter, Graham Moore
Le 16/10/2016 à 00:09, Moritz Fischer a écrit :
> On Fri, Oct 14, 2016 at 9:16 AM, Marek Vasut <marex@denx.de> wrote:
>> On 10/13/2016 10:30 AM, Dan Carpenter wrote:
>>> We return success or possibly uninitialized values on these error paths
>>> instead of proper error codes.
>>>
>>> Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>
>> Nice
>>
>> Reviewed-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
Applied to git://github.com/spi-nor/linux.git
Thanks!
>
> Thanks,
>
> Moritz
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-11-28 8:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-13 8:30 [patch 2/2] mtd: spi-nor: Fix some error codes in cqspi_setup_flash() Dan Carpenter
2016-10-13 8:30 ` Dan Carpenter
2016-10-14 7:16 ` Marek Vasut
2016-10-14 7:16 ` Marek Vasut
2016-10-15 22:09 ` Moritz Fischer
2016-10-15 22:09 ` Moritz Fischer
2016-11-28 8:20 ` Cyrille Pitchen
2016-11-28 8:20 ` Cyrille Pitchen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.