From: Oleksandr Andrushchenko <andr2000@gmail.com> To: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org Cc: dmitry.torokhov@gmail.com Subject: Re: [Xen-devel] [PATCH v2] xen, input: try to read screen resolution for xen-kbdfront Date: Fri, 27 Jan 2017 10:26:09 +0200 [thread overview] Message-ID: <3ec171a9-c38a-87e6-d1f6-5493211dc87e@gmail.com> (raw) In-Reply-To: <feaf5ee6-2a65-af7c-2dfb-ce9af29163ee@suse.com> On 01/27/2017 10:14 AM, Juergen Gross wrote: > On 27/01/17 08:53, Oleksandr Andrushchenko wrote: >> On 01/27/2017 09:46 AM, Juergen Gross wrote: >>> On 27/01/17 08:21, Oleksandr Andrushchenko wrote: >>>> On 01/27/2017 09:12 AM, Juergen Gross wrote: >>>>> Instead of using the default resolution of 800*600 for the pointing >>>>> device of xen-kbdfront try to read the resolution of the (virtual) >>>>> framebuffer device. Use the default as fallback only. >>>>> >>>>> Signed-off-by: Juergen Gross <jgross@suse.com> >>>>> --- >>>>> V2: get framebuffer resolution only if CONFIG_FB (Dmitry Torokhov) >>>>> --- >>>>> drivers/input/misc/xen-kbdfront.c | 15 ++++++++++++--- >>>>> 1 file changed, 12 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/drivers/input/misc/xen-kbdfront.c >>>>> b/drivers/input/misc/xen-kbdfront.c >>>>> index 3900875..3aae9b4 100644 >>>>> --- a/drivers/input/misc/xen-kbdfront.c >>>>> +++ b/drivers/input/misc/xen-kbdfront.c >>>>> @@ -16,6 +16,7 @@ >>>>> #include <linux/kernel.h> >>>>> #include <linux/errno.h> >>>>> #include <linux/module.h> >>>>> +#include <linux/fb.h> >>>>> #include <linux/input.h> >>>>> #include <linux/slab.h> >>>>> @@ -108,7 +109,7 @@ static irqreturn_t input_handler(int rq, void >>>>> *dev_id) >>>>> static int xenkbd_probe(struct xenbus_device *dev, >>>>> const struct xenbus_device_id *id) >>>>> { >>>>> - int ret, i; >>>>> + int ret, i, width, height; >>>>> unsigned int abs; >>>>> struct xenkbd_info *info; >>>>> struct input_dev *kbd, *ptr; >>>>> @@ -173,9 +174,17 @@ static int xenkbd_probe(struct xenbus_device *dev, >>>>> ptr->id.product = 0xfffe; >>>>> if (abs) { >>>>> + width = XENFB_WIDTH; >>>>> + height = XENFB_HEIGHT; >>>>> +#ifdef CONFIG_FB >>>>> + if (registered_fb[0]) { >>>> This still will not help if FB gets registered after kbd+ptr >>> Hmm, so you think I should add a call to fb_register_client() to get >>> events for new registered framebuffer devices? >> yes, but also pay attention to CONFIG_FB_NOTIFY: you may still >> end up w/o notification. > Okay, that's not worse than today. agree >>> This would probably work. I'll have a try. >>> >>> >>> Thanks, >>> >>> Juergen >> My bigger concern here is that we try to tie keyboard and pointer device >> to the framebuffer. IMO, these are independent parts of the system and >> the relation >> depends on the use-case. One can have graphics enabled w/o framebuffer >> at all, e.g. >> DRM/KMS + OpenGLES + Weston + kbd + ptr... > Again: that's a use case which will work as today. The current defaults > are being used. > > The question is whether we should add a module parameter switching off > the automatic adaption of the resolution as there might be use cases > where we don't want this feature. I think for those who doesn't want this resolution there is still a possibility to change it on backend's XenbusStateConnected So, no need for module parameter, IMO > > Juergen
WARNING: multiple messages have this Message-ID (diff)
From: Oleksandr Andrushchenko <andr2000@gmail.com> To: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org Cc: dmitry.torokhov@gmail.com Subject: Re: [PATCH v2] xen, input: try to read screen resolution for xen-kbdfront Date: Fri, 27 Jan 2017 10:26:09 +0200 [thread overview] Message-ID: <3ec171a9-c38a-87e6-d1f6-5493211dc87e@gmail.com> (raw) In-Reply-To: <feaf5ee6-2a65-af7c-2dfb-ce9af29163ee@suse.com> On 01/27/2017 10:14 AM, Juergen Gross wrote: > On 27/01/17 08:53, Oleksandr Andrushchenko wrote: >> On 01/27/2017 09:46 AM, Juergen Gross wrote: >>> On 27/01/17 08:21, Oleksandr Andrushchenko wrote: >>>> On 01/27/2017 09:12 AM, Juergen Gross wrote: >>>>> Instead of using the default resolution of 800*600 for the pointing >>>>> device of xen-kbdfront try to read the resolution of the (virtual) >>>>> framebuffer device. Use the default as fallback only. >>>>> >>>>> Signed-off-by: Juergen Gross <jgross@suse.com> >>>>> --- >>>>> V2: get framebuffer resolution only if CONFIG_FB (Dmitry Torokhov) >>>>> --- >>>>> drivers/input/misc/xen-kbdfront.c | 15 ++++++++++++--- >>>>> 1 file changed, 12 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/drivers/input/misc/xen-kbdfront.c >>>>> b/drivers/input/misc/xen-kbdfront.c >>>>> index 3900875..3aae9b4 100644 >>>>> --- a/drivers/input/misc/xen-kbdfront.c >>>>> +++ b/drivers/input/misc/xen-kbdfront.c >>>>> @@ -16,6 +16,7 @@ >>>>> #include <linux/kernel.h> >>>>> #include <linux/errno.h> >>>>> #include <linux/module.h> >>>>> +#include <linux/fb.h> >>>>> #include <linux/input.h> >>>>> #include <linux/slab.h> >>>>> @@ -108,7 +109,7 @@ static irqreturn_t input_handler(int rq, void >>>>> *dev_id) >>>>> static int xenkbd_probe(struct xenbus_device *dev, >>>>> const struct xenbus_device_id *id) >>>>> { >>>>> - int ret, i; >>>>> + int ret, i, width, height; >>>>> unsigned int abs; >>>>> struct xenkbd_info *info; >>>>> struct input_dev *kbd, *ptr; >>>>> @@ -173,9 +174,17 @@ static int xenkbd_probe(struct xenbus_device *dev, >>>>> ptr->id.product = 0xfffe; >>>>> if (abs) { >>>>> + width = XENFB_WIDTH; >>>>> + height = XENFB_HEIGHT; >>>>> +#ifdef CONFIG_FB >>>>> + if (registered_fb[0]) { >>>> This still will not help if FB gets registered after kbd+ptr >>> Hmm, so you think I should add a call to fb_register_client() to get >>> events for new registered framebuffer devices? >> yes, but also pay attention to CONFIG_FB_NOTIFY: you may still >> end up w/o notification. > Okay, that's not worse than today. agree >>> This would probably work. I'll have a try. >>> >>> >>> Thanks, >>> >>> Juergen >> My bigger concern here is that we try to tie keyboard and pointer device >> to the framebuffer. IMO, these are independent parts of the system and >> the relation >> depends on the use-case. One can have graphics enabled w/o framebuffer >> at all, e.g. >> DRM/KMS + OpenGLES + Weston + kbd + ptr... > Again: that's a use case which will work as today. The current defaults > are being used. > > The question is whether we should add a module parameter switching off > the automatic adaption of the resolution as there might be use cases > where we don't want this feature. I think for those who doesn't want this resolution there is still a possibility to change it on backend's XenbusStateConnected So, no need for module parameter, IMO > > Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-27 8:27 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-27 7:12 [PATCH v2] xen,input: try to read screen resolution for xen-kbdfront Juergen Gross 2017-01-27 7:21 ` [Xen-devel] [PATCH v2] xen, input: " Oleksandr Andrushchenko 2017-01-27 7:21 ` Oleksandr Andrushchenko 2017-01-27 7:46 ` [Xen-devel] " Juergen Gross 2017-01-27 7:46 ` Juergen Gross 2017-01-27 7:53 ` [Xen-devel] " Oleksandr Andrushchenko 2017-01-27 8:14 ` Juergen Gross 2017-01-27 8:14 ` [Xen-devel] " Juergen Gross 2017-01-27 8:26 ` Oleksandr Andrushchenko [this message] 2017-01-27 8:26 ` Oleksandr Andrushchenko 2017-01-27 8:31 ` [Xen-devel] " Juergen Gross 2017-01-27 8:31 ` Juergen Gross 2017-01-27 16:10 ` [Xen-devel] " Dmitry Torokhov 2017-01-27 16:10 ` Dmitry Torokhov 2017-01-30 11:23 ` [Xen-devel] " Juergen Gross 2017-01-30 11:27 ` Oleksandr Andrushchenko 2017-01-30 11:27 ` Oleksandr Andrushchenko 2017-02-17 19:47 ` Dmitry Torokhov 2017-02-17 19:47 ` [Xen-devel] " Dmitry Torokhov 2017-02-20 6:05 ` Juergen Gross 2017-02-20 6:05 ` [Xen-devel] " Juergen Gross 2017-01-30 11:23 ` Juergen Gross 2017-01-27 7:53 ` Oleksandr Andrushchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3ec171a9-c38a-87e6-d1f6-5493211dc87e@gmail.com \ --to=andr2000@gmail.com \ --cc=dmitry.torokhov@gmail.com \ --cc=jgross@suse.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.