[PATCH] drm/amd/display: Unconditionally print when DP sink power state fails

[PATCH] drm/amd/display: Unconditionally print when DP sink power state fails

[Srinivasan Shanmugam]

The previous 'commit 9360c01646d4e ("drm/amd/display: Add logging when
setting DP sink power state fails")', it is better to unconditionally
print "failed to power up sink", because we are returning
DC_ERROR_UNEXPECTED.

Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
---
 .../drm/amd/display/dc/link/protocols/link_dp_capability.c    | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
index 59adc61156cb..2914fca7dab3 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
@@ -1043,9 +1043,7 @@ static enum dc_status wake_up_aux_channel(struct dc_link *link)
 				DP_SET_POWER,
 				&dpcd_power_state,
 				sizeof(dpcd_power_state));
-		if (status < 0)
-			DC_LOG_DC("%s: Failed to power up sink: %s\n", __func__,
-				  dpcd_power_state == DP_SET_POWER_D0 ? "D0" : "D3");
+		DC_LOG_DC("%s: Failed to power up sink\n", __func__);
 		return DC_ERROR_UNEXPECTED;
 	}
 
-- 
2.25.1

Re: [PATCH] drm/amd/display: Unconditionally print when DP sink power state fails

[Aurabindo Pillai]

On 4/17/23 13:08, Srinivasan Shanmugam wrote:
> The previous 'commit 9360c01646d4e ("drm/amd/display: Add logging when
> setting DP sink power state fails")', it is better to unconditionally
> print "failed to power up sink", because we are returning
> DC_ERROR_UNEXPECTED.
> 
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
>   .../drm/amd/display/dc/link/protocols/link_dp_capability.c    | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> index 59adc61156cb..2914fca7dab3 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> @@ -1043,9 +1043,7 @@ static enum dc_status wake_up_aux_channel(struct dc_link *link)
>   				DP_SET_POWER,
>   				&dpcd_power_state,
>   				sizeof(dpcd_power_state));
> -		if (status < 0)
> -			DC_LOG_DC("%s: Failed to power up sink: %s\n", __func__,
> -				  dpcd_power_state == DP_SET_POWER_D0 ? "D0" : "D3");
> +		DC_LOG_DC("%s: Failed to power up sink\n", __func__);
>   		return DC_ERROR_UNEXPECTED;
>   	}
>   


With the following tag added to the commit message:

Fixes: 9360c01646d4e ("drm/amd/display: Add logging when setting DP sink 
power state fails")

The patch is:

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>