All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Ricardo Ribalda <ribalda@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: xilinx: Fix info message during probe
Date: Tue, 15 Sep 2020 13:41:02 +0200	[thread overview]
Message-ID: <3ed01356-d0a7-d4a4-3d8c-87013c3eab93@xilinx.com> (raw)
In-Reply-To: <20200915112936.320647-1-ribalda@kernel.org>



On 15. 09. 20 13:29, Ricardo Ribalda wrote:
> The info message was showing the mapped address of the device. To avoid
> security problems, all virtual addresses are converted to __ptrval__, so
> the message was useless/ugly:
> 
> [    2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37
> 
> Use %pR instead:
> 
> [   15.021354] xilinx_spi b0010000.spi-flash: at [mem 0xb0010000-0xb001ffff], irq=37
> 
> Signed-off-by: Ricardo Ribalda <ribalda@kernel.org>
> ---
>  drivers/spi/spi-xilinx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 8dd2bb99cb4d..523edfdf5dcd 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -491,8 +491,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>  		goto put_master;
>  	}
>  
> -	dev_info(&pdev->dev, "at 0x%08llX mapped to 0x%p, irq=%d\n",
> -		(unsigned long long)res->start, xspi->regs, xspi->irq);
> +	dev_info(&pdev->dev, "at %pR, irq=%d\n", res, xspi->irq);
>  
>  	if (pdata) {
>  		for (i = 0; i < pdata->num_devices; i++)
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Ricardo Ribalda <ribalda@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: xilinx: Fix info message during probe
Date: Tue, 15 Sep 2020 13:41:02 +0200	[thread overview]
Message-ID: <3ed01356-d0a7-d4a4-3d8c-87013c3eab93@xilinx.com> (raw)
In-Reply-To: <20200915112936.320647-1-ribalda@kernel.org>



On 15. 09. 20 13:29, Ricardo Ribalda wrote:
> The info message was showing the mapped address of the device. To avoid
> security problems, all virtual addresses are converted to __ptrval__, so
> the message was useless/ugly:
> 
> [    2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37
> 
> Use %pR instead:
> 
> [   15.021354] xilinx_spi b0010000.spi-flash: at [mem 0xb0010000-0xb001ffff], irq=37
> 
> Signed-off-by: Ricardo Ribalda <ribalda@kernel.org>
> ---
>  drivers/spi/spi-xilinx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 8dd2bb99cb4d..523edfdf5dcd 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -491,8 +491,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>  		goto put_master;
>  	}
>  
> -	dev_info(&pdev->dev, "at 0x%08llX mapped to 0x%p, irq=%d\n",
> -		(unsigned long long)res->start, xspi->regs, xspi->irq);
> +	dev_info(&pdev->dev, "at %pR, irq=%d\n", res, xspi->irq);
>  
>  	if (pdata) {
>  		for (i = 0; i < pdata->num_devices; i++)
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-16  0:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 11:29 [PATCH] spi: xilinx: Fix info message during probe Ricardo Ribalda
2020-09-15 11:29 ` Ricardo Ribalda
2020-09-15 11:41 ` Michal Simek [this message]
2020-09-15 11:41   ` Michal Simek
2020-09-17 18:58 ` Mark Brown
2020-09-17 18:58   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ed01356-d0a7-d4a4-3d8c-87013c3eab93@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=ribalda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.