From: Jyri Sarha <jsarha@ti.com> To: Cihangir Akturk <cakturk@gmail.com> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, David Airlie <airlied@linux.ie>, <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers Date: Thu, 3 Aug 2017 16:56:04 +0300 [thread overview] Message-ID: <3ed06ee9-6c17-2cb3-f1c4-72901ef7dc17@ti.com> (raw) In-Reply-To: <1501761585-11757-24-git-send-email-cakturk@gmail.com> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 08/03/17 14:58, Cihangir Akturk wrote: > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() adn should not be > used by new code. So convert all users of compatibility functions to use > the new APIs. > > Signed-off-by: Cihangir Akturk <cakturk@gmail.com> Acked-by: Jyri Sarha <jsarha@ti.com> This appears to be a part of a larger series. So I guess it will go in via drm-misc. But if this is not the case just let me know and I'll add this to my next pull request. Best Regards, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index d524ed0..6e936dd 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -75,7 +75,7 @@ static void unref_worker(struct drm_flip_work *work, void *val) > struct drm_device *dev = tilcdc_crtc->base.dev; > > mutex_lock(&dev->mode_config.mutex); > - drm_framebuffer_unreference(val); > + drm_framebuffer_put(val); > mutex_unlock(&dev->mode_config.mutex); > } > > @@ -456,7 +456,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) > > set_scanout(crtc, fb); > > - drm_framebuffer_reference(fb); > + drm_framebuffer_get(fb); > > crtc->hwmode = crtc->state->adjusted_mode; > } > @@ -621,7 +621,7 @@ int tilcdc_crtc_update_fb(struct drm_crtc *crtc, > return -EBUSY; > } > > - drm_framebuffer_reference(fb); > + drm_framebuffer_get(fb); > > crtc->primary->fb = fb; > tilcdc_crtc->event = event; >
WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha@ti.com> To: Cihangir Akturk <cakturk@gmail.com> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers Date: Thu, 3 Aug 2017 16:56:04 +0300 [thread overview] Message-ID: <3ed06ee9-6c17-2cb3-f1c4-72901ef7dc17@ti.com> (raw) In-Reply-To: <1501761585-11757-24-git-send-email-cakturk@gmail.com> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 08/03/17 14:58, Cihangir Akturk wrote: > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() adn should not be > used by new code. So convert all users of compatibility functions to use > the new APIs. > > Signed-off-by: Cihangir Akturk <cakturk@gmail.com> Acked-by: Jyri Sarha <jsarha@ti.com> This appears to be a part of a larger series. So I guess it will go in via drm-misc. But if this is not the case just let me know and I'll add this to my next pull request. Best Regards, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index d524ed0..6e936dd 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -75,7 +75,7 @@ static void unref_worker(struct drm_flip_work *work, void *val) > struct drm_device *dev = tilcdc_crtc->base.dev; > > mutex_lock(&dev->mode_config.mutex); > - drm_framebuffer_unreference(val); > + drm_framebuffer_put(val); > mutex_unlock(&dev->mode_config.mutex); > } > > @@ -456,7 +456,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) > > set_scanout(crtc, fb); > > - drm_framebuffer_reference(fb); > + drm_framebuffer_get(fb); > > crtc->hwmode = crtc->state->adjusted_mode; > } > @@ -621,7 +621,7 @@ int tilcdc_crtc_update_fb(struct drm_crtc *crtc, > return -EBUSY; > } > > - drm_framebuffer_reference(fb); > + drm_framebuffer_get(fb); > > crtc->primary->fb = fb; > tilcdc_crtc->event = event; >
next prev parent reply other threads:[~2017-08-03 13:56 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-03 11:58 [PATCH 00/29] DRM API conversions Cihangir Akturk 2017-08-03 11:58 ` [PATCH 01/29] drm/amdgpu: switch to drm_*{get,put} helpers Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 12:08 ` Christian König 2017-08-03 12:08 ` Christian König 2017-08-03 11:58 ` [PATCH 02/29] drm: mali-dp: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 14:02 ` Liviu Dudau 2017-08-03 11:58 ` [PATCH 03/29] drm/armada: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 04/29] drm/ast: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 05/29] drm/atmel-hlcdc: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 12:10 ` Boris Brezillon 2017-08-03 12:10 ` Boris Brezillon 2017-08-03 14:55 ` Boris Brezillon 2017-08-03 11:58 ` [PATCH 06/29] drm/bochs: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 07/29] drm/cirrus: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 08/29] drm/etnaviv: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 09/29] drm/exynos: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 10/29] drm/gma500: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 11/29] drm/hisilicon: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 12/29] drm/i915: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 12:26 ` Jani Nikula 2017-08-03 12:26 ` Jani Nikula 2017-08-03 12:49 ` Daniel Vetter 2017-08-03 12:49 ` Daniel Vetter 2017-08-03 15:52 ` Cihangir Akturk 2017-08-07 9:10 ` Daniel Vetter 2017-08-03 15:36 ` Cihangir Akturk 2017-08-04 8:18 ` Jani Nikula 2017-08-04 8:18 ` [PATCH 12/29] drm/i915: switch to drm_*{get, put} helpers Jani Nikula 2017-08-03 11:58 ` [PATCH 13/29] drm/imx: switch to drm_*{get,put} helpers Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 14/29] drm/mediatek: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 15/29] drm/mgag200: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 16/29] drm/msm: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 17/29] drm/nouveau: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 13:05 ` Tobias Klausmann 2017-08-03 11:58 ` [PATCH 18/29] drm/omap: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 19/29] drm/qxl: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 20/29] drm/radeon: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 12:08 ` Christian König 2017-08-03 12:08 ` Christian König 2017-08-03 16:27 ` Alex Deucher 2017-08-03 16:27 ` Alex Deucher 2017-08-03 11:58 ` [PATCH 21/29] drm/rockchip: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 22/29] drm/tegra: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 23/29] drm/tilcdc: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 13:56 ` Jyri Sarha [this message] 2017-08-03 13:56 ` Jyri Sarha 2017-08-03 15:42 ` Daniel Vetter 2017-08-03 17:37 ` Jyri Sarha 2017-08-03 17:37 ` Jyri Sarha 2017-08-03 11:58 ` [PATCH 24/29] drm/udl: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 25/29] drm/vc4: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-08 20:39 ` Eric Anholt 2017-08-08 20:39 ` Eric Anholt 2017-08-03 11:58 ` [PATCH 26/29] drm/vgem: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 27/29] drm/virtio: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 11:58 ` [PATCH 28/29] drm/vmwgfx: " Cihangir Akturk 2017-08-03 11:58 ` Cihangir Akturk 2017-08-03 12:40 ` Thomas Hellstrom 2017-08-03 13:06 ` Daniel Vetter 2017-08-03 13:06 ` Daniel Vetter 2017-08-03 11:58 ` [PATCH 29/29] staging: vboxvideo: " Cihangir Akturk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3ed06ee9-6c17-2cb3-f1c4-72901ef7dc17@ti.com \ --to=jsarha@ti.com \ --cc=airlied@linux.ie \ --cc=cakturk@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.