* [PATCH] USB: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-19 11:05 cgel.zte
2022-04-19 11:08 ` Bastien Nocera
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-19 11:05 UTC (permalink / raw)
To: hadess; +Cc: gregkh, linux-usb, linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. This change is just to simplify the code, no
actual functional changes.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/usb/misc/apple-mfi-fastcharge.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c b/drivers/usb/misc/apple-mfi-fastcharge.c
index ac8695195c13..fba102245d8f 100644
--- a/drivers/usb/misc/apple-mfi-fastcharge.c
+++ b/drivers/usb/misc/apple-mfi-fastcharge.c
@@ -119,11 +119,9 @@ static int apple_mfi_fc_set_property(struct power_supply *psy,
dev_dbg(&mfi->udev->dev, "prop: %d\n", psp);
- ret = pm_runtime_get_sync(&mfi->udev->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(&mfi->udev->dev);
+ ret = pm_runtime_resume_and_get(&mfi->udev->dev);
+ if (ret < 0)
return ret;
- }
switch (psp) {
case POWER_SUPPLY_PROP_CHARGE_TYPE:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] USB: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
2022-04-19 11:05 [PATCH] USB: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
@ 2022-04-19 11:08 ` Bastien Nocera
0 siblings, 0 replies; 2+ messages in thread
From: Bastien Nocera @ 2022-04-19 11:08 UTC (permalink / raw)
To: cgel.zte; +Cc: gregkh, linux-usb, linux-kernel, Minghao Chi, Zeal Robot
On Tue, 2022-04-19 at 11:05 +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. This change is just to simplify the code, no
> actual functional changes.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Thanks!
> ---
> drivers/usb/misc/apple-mfi-fastcharge.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c
> b/drivers/usb/misc/apple-mfi-fastcharge.c
> index ac8695195c13..fba102245d8f 100644
> --- a/drivers/usb/misc/apple-mfi-fastcharge.c
> +++ b/drivers/usb/misc/apple-mfi-fastcharge.c
> @@ -119,11 +119,9 @@ static int apple_mfi_fc_set_property(struct
> power_supply *psy,
>
> dev_dbg(&mfi->udev->dev, "prop: %d\n", psp);
>
> - ret = pm_runtime_get_sync(&mfi->udev->dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(&mfi->udev->dev);
> + ret = pm_runtime_resume_and_get(&mfi->udev->dev);
> + if (ret < 0)
> return ret;
> - }
>
> switch (psp) {
> case POWER_SUPPLY_PROP_CHARGE_TYPE:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-19 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-19 11:05 [PATCH] USB: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
2022-04-19 11:08 ` Bastien Nocera
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.