* [PATCH 1/1] scsi: hisi_sas: fix for the build error log_non_standard_event undefined
@ 2017-10-31 12:25 ` shiju.jose
0 siblings, 0 replies; 4+ messages in thread
From: shiju.jose @ 2017-10-31 12:25 UTC (permalink / raw)
To: martin.petersen, jejb, linux-scsi, linux-kernel
Cc: john.garry, xuwei5, shiju.jose
This patch fix the build error log_non_standard_event undefined
for the i386 build for COMPILE_TEST.
https://lists.01.org/pipermail/kbuild-all/2017-October/039518.html
The function call log_non_standard_event is replaced with the
function call trace_non_standard_event.
Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 41 ++++++++++++++++++----------------
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
index 433412a..72f606a 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
@@ -2959,12 +2959,13 @@ static irqreturn_t int_chnl_int_v2_hw(int irq_no, void *p)
if (trace_ns_event_enabled) {
err_data.physical_addr = val;
err_data.type = ecc_error->type;
- log_non_standard_event(&CPER_SEC_TYPE_HISI_SAS,
- &NULL_UUID_LE,
- dev_name(dev),
- GHES_SEV_RECOVERABLE,
- (const u8 *)&err_data,
- sizeof(err_data));
+ trace_non_standard_event(
+ &CPER_SEC_TYPE_HISI_SAS,
+ &NULL_UUID_LE,
+ dev_name(dev),
+ GHES_SEV_RECOVERABLE,
+ (const u8 *)&err_data,
+ sizeof(err_data));
} else {
dev_warn(dev, ecc_error->msg, val);
}
@@ -3000,12 +3001,13 @@ static void multi_bit_ecc_error_process_v2_hw(struct hisi_hba *hisi_hba,
if (trace_ns_event_enabled) {
err_data.physical_addr = val;
err_data.type = ecc_error->type;
- log_non_standard_event(&CPER_SEC_TYPE_HISI_SAS,
- &NULL_UUID_LE,
- dev_name(dev),
- GHES_SEV_PANIC,
- (const u8 *)&err_data,
- sizeof(err_data));
+ trace_non_standard_event(
+ &CPER_SEC_TYPE_HISI_SAS,
+ &NULL_UUID_LE,
+ dev_name(dev),
+ GHES_SEV_PANIC,
+ (const u8 *)&err_data,
+ sizeof(err_data));
} else {
dev_warn(dev, ecc_error->msg, irq_value, val);
}
@@ -3135,7 +3137,7 @@ static irqreturn_t fatal_axi_int_v2_hw(int irq_no, void *p)
HISI_SAS_VALID_AXI_ERR_INFO;
err_data.type = axi_error->type;
err_data.axi_err_info = sub->msk;
- log_non_standard_event(
+ trace_non_standard_event(
&CPER_SEC_TYPE_HISI_SAS,
&NULL_UUID_LE,
dev_name(dev),
@@ -3152,12 +3154,13 @@ static irqreturn_t fatal_axi_int_v2_hw(int irq_no, void *p)
err_data.validation_bits =
HISI_SAS_VALID_ERR_TYPE;
err_data.type = axi_error->type;
- log_non_standard_event(&CPER_SEC_TYPE_HISI_SAS,
- &NULL_UUID_LE,
- dev_name(dev),
- GHES_SEV_PANIC,
- (const u8 *)&err_data,
- sizeof(err_data));
+ trace_non_standard_event(
+ &CPER_SEC_TYPE_HISI_SAS,
+ &NULL_UUID_LE,
+ dev_name(dev),
+ GHES_SEV_PANIC,
+ (const u8 *)&err_data,
+ sizeof(err_data));
} else
dev_warn(dev, "%s (0x%x) found!\n",
axi_error->msg, irq_value);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] scsi: hisi_sas: fix for the build error log_non_standard_event undefined
@ 2017-10-31 12:25 ` shiju.jose
0 siblings, 0 replies; 4+ messages in thread
From: shiju.jose @ 2017-10-31 12:25 UTC (permalink / raw)
To: martin.petersen, jejb, linux-scsi, linux-kernel
Cc: john.garry, xuwei5, shiju.jose
This patch fix the build error log_non_standard_event undefined
for the i386 build for COMPILE_TEST.
https://lists.01.org/pipermail/kbuild-all/2017-October/039518.html
The function call log_non_standard_event is replaced with the
function call trace_non_standard_event.
Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 41 ++++++++++++++++++----------------
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
index 433412a..72f606a 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
@@ -2959,12 +2959,13 @@ static irqreturn_t int_chnl_int_v2_hw(int irq_no, void *p)
if (trace_ns_event_enabled) {
err_data.physical_addr = val;
err_data.type = ecc_error->type;
- log_non_standard_event(&CPER_SEC_TYPE_HISI_SAS,
- &NULL_UUID_LE,
- dev_name(dev),
- GHES_SEV_RECOVERABLE,
- (const u8 *)&err_data,
- sizeof(err_data));
+ trace_non_standard_event(
+ &CPER_SEC_TYPE_HISI_SAS,
+ &NULL_UUID_LE,
+ dev_name(dev),
+ GHES_SEV_RECOVERABLE,
+ (const u8 *)&err_data,
+ sizeof(err_data));
} else {
dev_warn(dev, ecc_error->msg, val);
}
@@ -3000,12 +3001,13 @@ static void multi_bit_ecc_error_process_v2_hw(struct hisi_hba *hisi_hba,
if (trace_ns_event_enabled) {
err_data.physical_addr = val;
err_data.type = ecc_error->type;
- log_non_standard_event(&CPER_SEC_TYPE_HISI_SAS,
- &NULL_UUID_LE,
- dev_name(dev),
- GHES_SEV_PANIC,
- (const u8 *)&err_data,
- sizeof(err_data));
+ trace_non_standard_event(
+ &CPER_SEC_TYPE_HISI_SAS,
+ &NULL_UUID_LE,
+ dev_name(dev),
+ GHES_SEV_PANIC,
+ (const u8 *)&err_data,
+ sizeof(err_data));
} else {
dev_warn(dev, ecc_error->msg, irq_value, val);
}
@@ -3135,7 +3137,7 @@ static irqreturn_t fatal_axi_int_v2_hw(int irq_no, void *p)
HISI_SAS_VALID_AXI_ERR_INFO;
err_data.type = axi_error->type;
err_data.axi_err_info = sub->msk;
- log_non_standard_event(
+ trace_non_standard_event(
&CPER_SEC_TYPE_HISI_SAS,
&NULL_UUID_LE,
dev_name(dev),
@@ -3152,12 +3154,13 @@ static irqreturn_t fatal_axi_int_v2_hw(int irq_no, void *p)
err_data.validation_bits =
HISI_SAS_VALID_ERR_TYPE;
err_data.type = axi_error->type;
- log_non_standard_event(&CPER_SEC_TYPE_HISI_SAS,
- &NULL_UUID_LE,
- dev_name(dev),
- GHES_SEV_PANIC,
- (const u8 *)&err_data,
- sizeof(err_data));
+ trace_non_standard_event(
+ &CPER_SEC_TYPE_HISI_SAS,
+ &NULL_UUID_LE,
+ dev_name(dev),
+ GHES_SEV_PANIC,
+ (const u8 *)&err_data,
+ sizeof(err_data));
} else
dev_warn(dev, "%s (0x%x) found!\n",
axi_error->msg, irq_value);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] scsi: hisi_sas: fix for the build error log_non_standard_event undefined
2017-10-31 12:25 ` shiju.jose
@ 2017-10-31 16:33 ` Martin K. Petersen
-1 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2017-10-31 16:33 UTC (permalink / raw)
To: shiju.jose
Cc: martin.petersen, jejb, linux-scsi, linux-kernel, john.garry, xuwei5
Shiju,
> This patch fix the build error log_non_standard_event undefined
> for the i386 build for COMPILE_TEST.
This is messy. You have one patch addressing build problems in two
different patches. This breaks our ability to bisect.
I combined the ECC and AXI patches into one and then added the build fix
on top. Really hope that works.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] scsi: hisi_sas: fix for the build error log_non_standard_event undefined
@ 2017-10-31 16:33 ` Martin K. Petersen
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2017-10-31 16:33 UTC (permalink / raw)
To: shiju.jose
Cc: martin.petersen, jejb, linux-scsi, linux-kernel, john.garry, xuwei5
Shiju,
> This patch fix the build error log_non_standard_event undefined
> for the i386 build for COMPILE_TEST.
This is messy. You have one patch addressing build problems in two
different patches. This breaks our ability to bisect.
I combined the ECC and AXI patches into one and then added the build fix
on top. Really hope that works.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-31 16:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 12:25 [PATCH 1/1] scsi: hisi_sas: fix for the build error log_non_standard_event undefined shiju.jose
2017-10-31 12:25 ` shiju.jose
2017-10-31 16:33 ` Martin K. Petersen
2017-10-31 16:33 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.