All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/5] disable drm_global_mutex for most drivers, take 2
Date: Fri, 7 Feb 2020 14:37:51 +0100	[thread overview]
Message-ID: <3f1d5e20-e75d-cf35-92fa-b23ae586d0e7@suse.de> (raw)
In-Reply-To: <20200204150146.2006481-1-daniel.vetter@ffwll.ch>


[-- Attachment #1.1.1: Type: text/plain, Size: 1304 bytes --]

Hi,

On patches 2 to 5:

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

I'm not overly knowledgeable on DRM locking semantics, but the patches
appear to be correct in general.

Best regards
Thomas


Am 04.02.20 um 16:01 schrieb Daniel Vetter:
> CI didn't like my test-with tag :-/
> 
> Test-with: 20200128112549.172135-1-daniel.vetter@ffwll.ch
> 
> Daniel Vetter (5):
>   drm: Complain if drivers still use the ->load callback
>   drm/fbdev-helper: don't force restores
>   drm/client: Rename _force to _locked
>   drm: Push drm_global_mutex locking in drm_open
>   drm: Nerf drm_global_mutex BKL for good drivers
> 
>  drivers/gpu/drm/drm_client_modeset.c | 12 +++++---
>  drivers/gpu/drm/drm_drv.c            | 26 +++++++++-------
>  drivers/gpu/drm/drm_fb_helper.c      | 16 ++--------
>  drivers/gpu/drm/drm_file.c           | 46 ++++++++++++++++++++++++++--
>  drivers/gpu/drm/drm_internal.h       |  1 +
>  include/drm/drm_client.h             |  7 ++++-
>  include/drm/drm_drv.h                |  3 ++
>  7 files changed, 79 insertions(+), 32 deletions(-)
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 0/5] disable drm_global_mutex for most drivers, take 2
Date: Fri, 7 Feb 2020 14:37:51 +0100	[thread overview]
Message-ID: <3f1d5e20-e75d-cf35-92fa-b23ae586d0e7@suse.de> (raw)
In-Reply-To: <20200204150146.2006481-1-daniel.vetter@ffwll.ch>


[-- Attachment #1.1.1: Type: text/plain, Size: 1304 bytes --]

Hi,

On patches 2 to 5:

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

I'm not overly knowledgeable on DRM locking semantics, but the patches
appear to be correct in general.

Best regards
Thomas


Am 04.02.20 um 16:01 schrieb Daniel Vetter:
> CI didn't like my test-with tag :-/
> 
> Test-with: 20200128112549.172135-1-daniel.vetter@ffwll.ch
> 
> Daniel Vetter (5):
>   drm: Complain if drivers still use the ->load callback
>   drm/fbdev-helper: don't force restores
>   drm/client: Rename _force to _locked
>   drm: Push drm_global_mutex locking in drm_open
>   drm: Nerf drm_global_mutex BKL for good drivers
> 
>  drivers/gpu/drm/drm_client_modeset.c | 12 +++++---
>  drivers/gpu/drm/drm_drv.c            | 26 +++++++++-------
>  drivers/gpu/drm/drm_fb_helper.c      | 16 ++--------
>  drivers/gpu/drm/drm_file.c           | 46 ++++++++++++++++++++++++++--
>  drivers/gpu/drm/drm_internal.h       |  1 +
>  include/drm/drm_client.h             |  7 ++++-
>  include/drm/drm_drv.h                |  3 ++
>  7 files changed, 79 insertions(+), 32 deletions(-)
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-02-07 13:37 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 15:01 [PATCH 0/5] disable drm_global_mutex for most drivers, take 2 Daniel Vetter
2020-02-04 15:01 ` [Intel-gfx] " Daniel Vetter
2020-02-04 15:01 ` [PATCH 1/5] drm: Complain if drivers still use the ->load callback Daniel Vetter
2020-02-04 15:01   ` [Intel-gfx] " Daniel Vetter
2020-02-04 15:01 ` [PATCH 2/5] drm/fbdev-helper: don't force restores Daniel Vetter
2020-02-04 15:01   ` [Intel-gfx] " Daniel Vetter
2020-02-04 15:01 ` [PATCH 3/5] drm/client: Rename _force to _locked Daniel Vetter
2020-02-04 15:01   ` [Intel-gfx] " Daniel Vetter
2020-02-04 15:01 ` [PATCH 4/5] drm: Push drm_global_mutex locking in drm_open Daniel Vetter
2020-02-04 15:01   ` [Intel-gfx] " Daniel Vetter
2020-02-10  8:09   ` Chris Wilson
2020-02-10  8:09     ` [Intel-gfx] " Chris Wilson
2020-02-04 15:01 ` [PATCH 5/5] drm: Nerf drm_global_mutex BKL for good drivers Daniel Vetter
2020-02-04 15:01   ` [Intel-gfx] " Daniel Vetter
2020-02-10  8:09   ` Chris Wilson
2020-02-10  8:09     ` [Intel-gfx] " Chris Wilson
2020-02-05  2:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for disable drm_global_mutex for most drivers (rev5) Patchwork
2020-02-06 19:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for disable drm_global_mutex for most drivers (rev6) Patchwork
2020-02-06 20:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for disable drm_global_mutex for most drivers (rev7) Patchwork
2020-02-07  8:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-07 13:37 ` Thomas Zimmermann [this message]
2020-02-07 13:37   ` [Intel-gfx] [PATCH 0/5] disable drm_global_mutex for most drivers, take 2 Thomas Zimmermann
2020-02-09 17:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for disable drm_global_mutex for most drivers (rev7) Patchwork
2020-02-10  9:47 ` [PATCH 0/5] disable drm_global_mutex for most drivers, take 2 Thomas Zimmermann
2020-02-10  9:47   ` [Intel-gfx] " Thomas Zimmermann
2020-02-11 11:20   ` Daniel Vetter
2020-02-11 11:20     ` [Intel-gfx] " Daniel Vetter
2020-02-10 10:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for disable drm_global_mutex for most drivers (rev7) Patchwork
2020-02-10 12:20 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f1d5e20-e75d-cf35-92fa-b23ae586d0e7@suse.de \
    --to=tzimmermann@suse.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.