* [PATCH 2/2] ASoC: rt1316: fix key tone missing
@ 2023-07-21 8:18 shumingf
2023-07-21 11:18 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: shumingf @ 2023-07-21 8:18 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: alsa-devel, lars, flove, oder_chiou, jack.yu, derek.fang,
Vijendar.Mukunda, Shuming Fan
From: Shuming Fan <shumingf@realtek.com>
This patch disables the soft ramp to output immediately.
Signed-off-by: Shuming Fan <shumingf@realtek.com>
---
sound/soc/codecs/rt1316-sdw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt1316-sdw.c b/sound/soc/codecs/rt1316-sdw.c
index ce2246a2591c..feea11149d93 100644
--- a/sound/soc/codecs/rt1316-sdw.c
+++ b/sound/soc/codecs/rt1316-sdw.c
@@ -134,7 +134,7 @@ static const struct reg_sequence rt1316_blind_write[] = {
{ 0xc093, 0x80 },
{ 0xc09d, 0x80 },
{ 0xc0b0, 0x77 },
- { 0xc010, 0xa5 },
+ { 0xc010, 0x25 },
{ 0xc050, 0x83 },
{ 0x2f55, 0x03 },
{ 0x3217, 0xb5 },
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] ASoC: rt1316: fix key tone missing
2023-07-21 8:18 [PATCH 2/2] ASoC: rt1316: fix key tone missing shumingf
@ 2023-07-21 11:18 ` Mark Brown
2023-07-21 15:34 ` Shuming [范書銘]
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2023-07-21 11:18 UTC (permalink / raw)
To: shumingf
Cc: lgirdwood, alsa-devel, lars, flove, oder_chiou, jack.yu,
derek.fang, Vijendar.Mukunda
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
On Fri, Jul 21, 2023 at 04:18:07PM +0800, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
>
> This patch disables the soft ramp to output immediately.
> { 0xc09d, 0x80 },
> { 0xc0b0, 0x77 },
> - { 0xc010, 0xa5 },
> + { 0xc010, 0x25 },
> { 0xc050, 0x83 },
This should probably be an actual control not something patched into the
registers - some users might prefer toe soft ramp.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 2/2] ASoC: rt1316: fix key tone missing
2023-07-21 11:18 ` Mark Brown
@ 2023-07-21 15:34 ` Shuming [范書銘]
0 siblings, 0 replies; 3+ messages in thread
From: Shuming [范書銘] @ 2023-07-21 15:34 UTC (permalink / raw)
To: Mark Brown
Cc: lgirdwood, alsa-devel, lars, Flove(HsinFu),
Oder Chiou, Jack Yu, Derek [方德義],
Vijendar.Mukunda
> > From: Shuming Fan <shumingf@realtek.com>
> >
> > This patch disables the soft ramp to output immediately.
>
> > { 0xc09d, 0x80 },
> > { 0xc0b0, 0x77 },
> > - { 0xc010, 0xa5 },
> > + { 0xc010, 0x25 },
> > { 0xc050, 0x83 },
>
> This should probably be an actual control not something patched into the
> registers - some users might prefer toe soft ramp.
Got it. I will add a mixer control for it. Thanks.
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-21 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-21 8:18 [PATCH 2/2] ASoC: rt1316: fix key tone missing shumingf
2023-07-21 11:18 ` Mark Brown
2023-07-21 15:34 ` Shuming [范書銘]
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.