* [GIT PULL FOR v5.19] cec: various fixes and enhancements
@ 2022-04-06 11:00 Hans Verkuil
2022-04-06 15:01 ` [GIT PULL FOR v5.19] cec: various fixes and enhancements (#82257) Jenkins
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2022-04-06 11:00 UTC (permalink / raw)
To: linux-media
The first two patches fix issues relating to a CEC adapter
being disabled while a transmit is still in progress at the
hardware level. Unless the hardware is really disabled (i.e.
loses power) the transmit should just continue in order to
keep the hardware and framework state in sync, and to avoid
half-written messages on the bus.
The third patch fixes a mismatch between the API documentation
and the actual code w.r.t. reporting the results of a non-blocking
transmit.
The fourth patch adds helpers to make it easier for both drivers
and userspace to detect if the received message contains the
result of a non-blocking transmit.
The fifth patch makes the framework more robust, preventing ops
from being called when the device is already unregistered.
The sixth patch allows drivers to override the transmit timeout
value. And the last patch adds a new callback so drivers can take
actual when an adapter is fully configured (i.e. all logical addresses
are claimed) or unconfigured.
Regards,
Hans
The following changes since commit 535f49a9e1f99d0bacb5d492a9dd193c3affbfc0:
media: platform: imx-mipi-csis: Add dependency on VIDEO_DEV (2022-04-05 16:12:30 +0200)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.19b
for you to fetch changes up to 7ebdf1f2e7b92536eb3ea7595a051057eec9ef1b:
cec: add optional adap_configured callback (2022-04-06 10:31:05 +0200)
----------------------------------------------------------------
Tag branch
----------------------------------------------------------------
Hans Verkuil (7):
cec: call enable_adap on s_log_addrs
cec: abort if the current transmit was canceled
cec: correctly pass on reply results
cec.h: add cec_msg_recv_is_rx/tx_result helpers
cec: use call_op and check for !unregistered
cec: add xfer_timeout_ms field
cec: add optional adap_configured callback
Documentation/driver-api/media/cec-core.rst | 13 +++-
drivers/media/cec/core/cec-adap.c | 282 +++++++++++++++++++++++++++++++++++++++++++------------------------
drivers/media/cec/core/cec-api.c | 24 ++----
drivers/media/cec/core/cec-core.c | 18 ++++-
drivers/media/cec/core/cec-pin-priv.h | 11 +++
drivers/media/cec/core/cec-pin.c | 23 +++---
drivers/media/cec/core/cec-priv.h | 10 +++
include/media/cec.h | 12 +++
include/uapi/linux/cec.h | 20 +++++
9 files changed, 278 insertions(+), 135 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [GIT PULL FOR v5.19] cec: various fixes and enhancements (#82257)
2022-04-06 11:00 [GIT PULL FOR v5.19] cec: various fixes and enhancements Hans Verkuil
@ 2022-04-06 15:01 ` Jenkins
0 siblings, 0 replies; 2+ messages in thread
From: Jenkins @ 2022-04-06 15:01 UTC (permalink / raw)
To: mchehab+samsung, linux-media; +Cc: builder
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/3f54b8d2-9c26-1775-0cc9-688a677776eb@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/197361/
Build time: 00:24:12
Link: https://lore.kernel.org/linux-media/3f54b8d2-9c26-1775-0cc9-688a677776eb@xs4all.nl
gpg: Signature made Wed 06 Apr 2022 10:52:37 AM UTC
gpg: using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76
gpg: Can't check signature: No public key
Summary: got 2/7 patches with issues, being 1 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-cec-call-enable_adap-on-s_log_addrs.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
allyesconfig: return code #0:
../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1983 vivid_create_instance() parse error: turning off implications after 60 seconds
SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds
../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654)
../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2900 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
patches/0005-cec-use-call_op-and-check-for-unregistered.patch:
checkpatch.pl:
$ cat patches/0005-cec-use-call_op-and-check-for-unregistered.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:173: CHECK: Macro argument reuse 'pin' - possible side-effects?
-:173: CHECK: Macro argument 'pin' may be better as '(pin)' to avoid precedence issues
-:173: CHECK: Macro argument reuse 'op' - possible side-effects?
-:173: CHECK: Macro argument 'op' may be better as '(op)' to avoid precedence issues
-:177: CHECK: Macro argument reuse 'pin' - possible side-effects?
-:177: CHECK: Macro argument 'pin' may be better as '(pin)' to avoid precedence issues
-:177: CHECK: Macro argument reuse 'op' - possible side-effects?
-:177: CHECK: Macro argument 'op' may be better as '(op)' to avoid precedence issues
-:290: CHECK: Macro argument reuse 'adap' - possible side-effects?
-:290: CHECK: Macro argument 'adap' may be better as '(adap)' to avoid precedence issues
-:290: CHECK: Macro argument reuse 'op' - possible side-effects?
-:290: CHECK: Macro argument 'op' may be better as '(op)' to avoid precedence issues
-:294: CHECK: Macro argument reuse 'adap' - possible side-effects?
-:294: CHECK: Macro argument 'adap' may be better as '(adap)' to avoid precedence issues
-:294: CHECK: Macro argument reuse 'op' - possible side-effects?
-:294: CHECK: Macro argument 'op' may be better as '(op)' to avoid precedence issues
Error #512 when building PDF docs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 11:00 [GIT PULL FOR v5.19] cec: various fixes and enhancements Hans Verkuil
2022-04-06 15:01 ` [GIT PULL FOR v5.19] cec: various fixes and enhancements (#82257) Jenkins
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.