From: Tianyu Lan <ltykernel@gmail.com> To: Michael Kelley <mikelley@microsoft.com>, KY Srinivasan <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Stephen Hemminger <sthemmin@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "luto@kernel.org" <luto@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>, "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>, "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>, "jgross@suse.com" <jgross@suse.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>, "joro@8bytes.org" <joro@8bytes.org>, "will@kernel.org" <will@kernel.org>, "davem@davemloft.net" <davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>, "jejb@linux.ibm.com" <jejb@linux.ibm.com>, "martin.petersen@oracle.com" <martin.petersen@oracle.com>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "arnd@arndb.de" <arnd@arndb.de>, "hch@lst.de" <hch@lst.de>, "m.szyprowski@samsung.com" <m.szyprowski@samsung.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>, "brijesh.singh@amd.com" <brijesh.singh@amd.com>, Tianyu Lan <Tianyu.Lan@microsoft.com>, "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>, "pgonda@google.com" <pgonda@google.com>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>, "rppt@kernel.org" <rppt@kernel.org>, "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>, "aneesh.kumar@linux.ibm.com" <aneesh.kumar@linux.ibm.com>, "saravanand@fb.com" <saravanand@fb.com>, "krish.sadhukhan@oracle.com" <krish.sadhukhan@oracle.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "tj@kernel.org" <tj@kernel.org>, "rientjes@google.com" <rientjes@google.com> Cc: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, vkuznets <vkuznets@redhat.com>, "parri.andrea@gmail.com" <parri.andrea@gmail.com>, "dave.hansen@intel.com" <dave.hansen@intel.com> Subject: Re: [PATCH V5 09/12] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Date: Thu, 16 Sep 2021 18:57:20 +0800 [thread overview] Message-ID: <3f6a6407-b8fd-803b-e4fe-ea9a873a5840@gmail.com> (raw) In-Reply-To: <MWHPR21MB159349234C15D0F04F87845CD7DB9@MWHPR21MB1593.namprd21.prod.outlook.com> On 9/15/2021 11:42 PM, Michael Kelley wrote: >> @@ -196,13 +199,34 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, >> mem->slots[i].orig_addr = INVALID_PHYS_ADDR; >> mem->slots[i].alloc_size = 0; >> } >> + >> + if (set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT)) >> + return -EFAULT; >> + >> + /* >> + * Map memory in the unencrypted physical address space when requested >> + * (e.g. for Hyper-V AMD SEV-SNP Isolation VMs). >> + */ >> + if (swiotlb_unencrypted_base) { >> + phys_addr_t paddr = __pa(vaddr) + swiotlb_unencrypted_base; > Nit: Use "start" instead of "__pa(vaddr)" since "start" is already the needed > physical address. Yes, "start" should be used here. > >> @@ -304,7 +332,7 @@ int >> swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) >> { >> struct io_tlb_mem *mem = &io_tlb_default_mem; >> - unsigned long bytes = nslabs << IO_TLB_SHIFT; >> + int ret; >> >> if (swiotlb_force == SWIOTLB_NO_FORCE) >> return 0; >> @@ -318,8 +346,9 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) >> if (!mem->slots) >> return -ENOMEM; >> >> - set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT); >> - swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true); >> + ret = swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true); >> + if (ret) > Before returning the error, free the pages obtained from the earlier call > to __get_free_pages()? > Yes, will fix. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Tianyu Lan <ltykernel@gmail.com> To: Michael Kelley <mikelley@microsoft.com>, KY Srinivasan <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Stephen Hemminger <sthemmin@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "luto@kernel.org" <luto@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>, "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>, "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>, "jgross@suse.com" <jgross@suse.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>, "joro@8bytes.org" <joro@8bytes.org>, "will@kernel.org" <will@kernel.org>, "davem@davemloft.net" <davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>, "jejb@linux.ibm.com" <jejb@linux.ibm.com>, "martin.petersen@oracle.com" <martin.petersen@oracle.com>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "arnd@arndb.de" <arnd@arndb.de>, "hch@lst.de" <hch@lst.de>, "m.szyprowski@samsung.com" <m.szyprowski@samsung.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>, "brijesh.singh@amd.com" <brijesh.singh@amd.com>, Tianyu Lan <Tianyu.Lan@microsoft.com>, "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>, "pgonda@google.com" <pgonda@google.com>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>, "rppt@kernel.org" <rppt@kernel.org>, "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>, "aneesh.kumar@linux.ibm.com" <aneesh.kumar@linux.ibm.com>, "saravanand@fb.com" <saravanand@fb.com>, "krish.sadhukhan@oracle.com" <krish.sadhukhan@oracle.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "tj@kernel.org" <tj@kernel.org>, "rientjes@google.com" <rientjes@google.com> Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, "parri.andrea@gmail.com" <parri.andrea@gmail.com>, "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>, "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dave.hansen@intel.com" <dave.hansen@intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, vkuznets <vkuznets@redhat.com> Subject: Re: [PATCH V5 09/12] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Date: Thu, 16 Sep 2021 18:57:20 +0800 [thread overview] Message-ID: <3f6a6407-b8fd-803b-e4fe-ea9a873a5840@gmail.com> (raw) In-Reply-To: <MWHPR21MB159349234C15D0F04F87845CD7DB9@MWHPR21MB1593.namprd21.prod.outlook.com> On 9/15/2021 11:42 PM, Michael Kelley wrote: >> @@ -196,13 +199,34 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, >> mem->slots[i].orig_addr = INVALID_PHYS_ADDR; >> mem->slots[i].alloc_size = 0; >> } >> + >> + if (set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT)) >> + return -EFAULT; >> + >> + /* >> + * Map memory in the unencrypted physical address space when requested >> + * (e.g. for Hyper-V AMD SEV-SNP Isolation VMs). >> + */ >> + if (swiotlb_unencrypted_base) { >> + phys_addr_t paddr = __pa(vaddr) + swiotlb_unencrypted_base; > Nit: Use "start" instead of "__pa(vaddr)" since "start" is already the needed > physical address. Yes, "start" should be used here. > >> @@ -304,7 +332,7 @@ int >> swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) >> { >> struct io_tlb_mem *mem = &io_tlb_default_mem; >> - unsigned long bytes = nslabs << IO_TLB_SHIFT; >> + int ret; >> >> if (swiotlb_force == SWIOTLB_NO_FORCE) >> return 0; >> @@ -318,8 +346,9 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs) >> if (!mem->slots) >> return -ENOMEM; >> >> - set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT); >> - swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true); >> + ret = swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true); >> + if (ret) > Before returning the error, free the pages obtained from the earlier call > to __get_free_pages()? > Yes, will fix. Thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-09-16 10:57 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-14 13:39 [PATCH V5 00/12] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-14 13:39 ` [PATCH V5 01/12] x86/hyperv: Initialize GHCB page in Isolation VM Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-14 13:39 ` [PATCH V5 02/12] x86/hyperv: Initialize shared memory boundary in the " Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-14 13:39 ` [PATCH V5 03/12] x86/hyperv: Add new hvcall guest address host visibility support Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-14 13:39 ` [PATCH V5 04/12] Drivers: hv: vmbus: Mark vmbus ring buffer visible to host in Isolation VM Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-15 15:40 ` Michael Kelley 2021-09-15 15:40 ` Michael Kelley via iommu 2021-09-14 13:39 ` [PATCH V5 05/12] x86/hyperv: Add Write/Read MSR registers via ghcb page Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-15 15:41 ` Michael Kelley 2021-09-15 15:41 ` Michael Kelley via iommu 2021-09-14 13:39 ` [PATCH V5 06/12] x86/hyperv: Add ghcb hvcall support for SNP VM Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-14 13:39 ` [PATCH V5 07/12] Drivers: hv: vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-15 15:41 ` Michael Kelley 2021-09-15 15:41 ` Michael Kelley via iommu 2021-09-16 10:52 ` Tianyu Lan 2021-09-16 10:52 ` Tianyu Lan 2021-09-14 13:39 ` [PATCH V5 08/12] Drivers: hv : vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-14 13:39 ` [PATCH V5 09/12] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-15 15:42 ` Michael Kelley 2021-09-15 15:42 ` Michael Kelley via iommu 2021-09-16 10:57 ` Tianyu Lan [this message] 2021-09-16 10:57 ` Tianyu Lan 2021-09-14 13:39 ` [PATCH V5 10/12] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-15 15:43 ` Michael Kelley 2021-09-15 15:43 ` Michael Kelley via iommu 2021-09-14 13:39 ` [PATCH V5 11/12] scsi: storvsc: Add Isolation VM support for storvsc driver Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-15 15:43 ` Michael Kelley 2021-09-15 15:43 ` Michael Kelley via iommu 2021-09-14 13:39 ` [PATCH V5 12/12] net: netvsc: Add Isolation VM support for netvsc driver Tianyu Lan 2021-09-14 13:39 ` Tianyu Lan 2021-09-14 15:49 ` Haiyang Zhang 2021-09-14 15:49 ` Haiyang Zhang via iommu 2021-09-15 16:21 ` Michael Kelley 2021-09-15 16:21 ` Michael Kelley via iommu 2021-09-15 16:46 ` Haiyang Zhang 2021-09-15 16:46 ` Haiyang Zhang via iommu 2021-09-16 13:56 ` Tianyu Lan 2021-09-16 13:56 ` Tianyu Lan 2021-09-16 14:43 ` Tianyu Lan 2021-09-16 14:43 ` Tianyu Lan 2021-09-22 10:34 ` Tianyu Lan 2021-09-22 10:34 ` Tianyu Lan 2021-09-27 14:26 ` Tianyu Lan 2021-09-27 14:26 ` Tianyu Lan 2021-09-28 5:39 ` Christoph Hellwig 2021-09-28 5:39 ` Christoph Hellwig 2021-09-28 9:23 ` Tianyu Lan 2021-09-28 9:23 ` Tianyu Lan 2021-09-30 5:48 ` Christoph Hellwig 2021-09-30 5:48 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3f6a6407-b8fd-803b-e4fe-ea9a873a5840@gmail.com \ --to=ltykernel@gmail.com \ --cc=Tianyu.Lan@microsoft.com \ --cc=akpm@linux-foundation.org \ --cc=aneesh.kumar@linux.ibm.com \ --cc=arnd@arndb.de \ --cc=boris.ostrovsky@oracle.com \ --cc=bp@alien8.de \ --cc=brijesh.singh@amd.com \ --cc=dave.hansen@intel.com \ --cc=dave.hansen@linux.intel.com \ --cc=davem@davemloft.net \ --cc=decui@microsoft.com \ --cc=gregkh@linuxfoundation.org \ --cc=haiyangz@microsoft.com \ --cc=hch@lst.de \ --cc=hpa@zytor.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jejb@linux.ibm.com \ --cc=jgross@suse.com \ --cc=joro@8bytes.org \ --cc=kirill.shutemov@linux.intel.com \ --cc=konrad.wilk@oracle.com \ --cc=krish.sadhukhan@oracle.com \ --cc=kuba@kernel.org \ --cc=kys@microsoft.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-hyperv@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=luto@kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=martin.petersen@oracle.com \ --cc=mikelley@microsoft.com \ --cc=mingo@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=parri.andrea@gmail.com \ --cc=peterz@infradead.org \ --cc=pgonda@google.com \ --cc=rientjes@google.com \ --cc=robin.murphy@arm.com \ --cc=rppt@kernel.org \ --cc=saravanand@fb.com \ --cc=sfr@canb.auug.org.au \ --cc=sstabellini@kernel.org \ --cc=sthemmin@microsoft.com \ --cc=tglx@linutronix.de \ --cc=thomas.lendacky@amd.com \ --cc=tj@kernel.org \ --cc=vkuznets@redhat.com \ --cc=wei.liu@kernel.org \ --cc=will@kernel.org \ --cc=x86@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.