* [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code
@ 2019-09-04 11:54 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-09-04 11:54 UTC (permalink / raw)
To: b.zolnierkie, tglx, alexios.zavras, gregkh, allison, yuehaibing
Cc: linux-omap, linux-fbdev, dri-devel, linux-kernel
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/omap2/omapfb/vrfb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c
index 819e0bc..ee0dd4c 100644
--- a/drivers/video/fbdev/omap2/omapfb/vrfb.c
+++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c
@@ -339,9 +339,7 @@ static int __init vrfb_probe(struct platform_device *pdev)
int i;
/* first resource is the register res, the rest are vrfb contexts */
-
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- vrfb_base = devm_ioremap_resource(&pdev->dev, mem);
+ vrfb_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(vrfb_base))
return PTR_ERR(vrfb_base);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code
@ 2019-09-04 11:54 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-09-04 11:54 UTC (permalink / raw)
To: b.zolnierkie, tglx, alexios.zavras, gregkh, allison, yuehaibing
Cc: linux-omap, linux-fbdev, dri-devel, linux-kernel
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/omap2/omapfb/vrfb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c
index 819e0bc..ee0dd4c 100644
--- a/drivers/video/fbdev/omap2/omapfb/vrfb.c
+++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c
@@ -339,9 +339,7 @@ static int __init vrfb_probe(struct platform_device *pdev)
int i;
/* first resource is the register res, the rest are vrfb contexts */
-
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- vrfb_base = devm_ioremap_resource(&pdev->dev, mem);
+ vrfb_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(vrfb_base))
return PTR_ERR(vrfb_base);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code
2019-09-04 11:54 ` YueHaibing
(?)
@ 2020-01-03 12:14 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-03 12:14 UTC (permalink / raw)
To: YueHaibing
Cc: tglx, alexios.zavras, gregkh, allison, linux-omap, linux-fbdev,
dri-devel, linux-kernel
On 9/4/19 1:54 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/omap2/omapfb/vrfb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> index 819e0bc..ee0dd4c 100644
> --- a/drivers/video/fbdev/omap2/omapfb/vrfb.c
> +++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> @@ -339,9 +339,7 @@ static int __init vrfb_probe(struct platform_device *pdev)
> int i;
>
> /* first resource is the register res, the rest are vrfb contexts */
> -
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - vrfb_base = devm_ioremap_resource(&pdev->dev, mem);
> + vrfb_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(vrfb_base))
> return PTR_ERR(vrfb_base);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code
@ 2020-01-03 12:14 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-03 12:14 UTC (permalink / raw)
To: YueHaibing
Cc: linux-fbdev, gregkh, linux-kernel, dri-devel, alexios.zavras,
tglx, linux-omap, allison
On 9/4/19 1:54 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/omap2/omapfb/vrfb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> index 819e0bc..ee0dd4c 100644
> --- a/drivers/video/fbdev/omap2/omapfb/vrfb.c
> +++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> @@ -339,9 +339,7 @@ static int __init vrfb_probe(struct platform_device *pdev)
> int i;
>
> /* first resource is the register res, the rest are vrfb contexts */
> -
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - vrfb_base = devm_ioremap_resource(&pdev->dev, mem);
> + vrfb_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(vrfb_base))
> return PTR_ERR(vrfb_base);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code
@ 2020-01-03 12:14 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-03 12:14 UTC (permalink / raw)
To: YueHaibing
Cc: linux-fbdev, gregkh, linux-kernel, dri-devel, alexios.zavras,
tglx, linux-omap, allison
On 9/4/19 1:54 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/omap2/omapfb/vrfb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> index 819e0bc..ee0dd4c 100644
> --- a/drivers/video/fbdev/omap2/omapfb/vrfb.c
> +++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> @@ -339,9 +339,7 @@ static int __init vrfb_probe(struct platform_device *pdev)
> int i;
>
> /* first resource is the register res, the rest are vrfb contexts */
> -
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - vrfb_base = devm_ioremap_resource(&pdev->dev, mem);
> + vrfb_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(vrfb_base))
> return PTR_ERR(vrfb_base);
>
^ permalink raw reply [flat|nested] 6+ messages in thread