* [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied
@ 2020-03-09 16:35 Yi Li
2020-03-10 2:04 ` John Snow
0 siblings, 1 reply; 4+ messages in thread
From: Yi Li @ 2020-03-09 16:35 UTC (permalink / raw)
To: qemu-devel; +Cc: yili
The QCowL2Meta **m parameter is not used
Signed-off-by: Yi Li <yili@winhong.com>
---
block/qcow2-cluster.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 17f1363..db9efa5 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -1154,7 +1154,7 @@ static int handle_dependencies(BlockDriverState *bs, uint64_t guest_offset,
* -errno: in error cases
*/
static int handle_copied(BlockDriverState *bs, uint64_t guest_offset,
- uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
+ uint64_t *host_offset, uint64_t *bytes)
{
BDRVQcow2State *s = bs->opaque;
int l2_index;
@@ -1567,7 +1567,7 @@ again:
/*
* 2. Count contiguous COPIED clusters.
*/
- ret = handle_copied(bs, start, &cluster_offset, &cur_bytes, m);
+ ret = handle_copied(bs, start, &cluster_offset, &cur_bytes);
if (ret < 0) {
return ret;
} else if (ret) {
--
2.7.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied
2020-03-09 16:35 [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied Yi Li
@ 2020-03-10 2:04 ` John Snow
2020-03-10 11:19 ` Alberto Garcia
0 siblings, 1 reply; 4+ messages in thread
From: John Snow @ 2020-03-10 2:04 UTC (permalink / raw)
To: Yi Li, qemu-devel; +Cc: Kevin Wolf, Qemu-block, Max Reitz
CC qemu-block and qcow2 maintainers
(Use scripts/get_maintainer.pl to identify maintainers.)
On 3/9/20 12:35 PM, Yi Li wrote:
> The QCowL2Meta **m parameter is not used
>
> Signed-off-by: Yi Li <yili@winhong.com>
> ---
> block/qcow2-cluster.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index 17f1363..db9efa5 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -1154,7 +1154,7 @@ static int handle_dependencies(BlockDriverState *bs, uint64_t guest_offset,
> * -errno: in error cases
> */
> static int handle_copied(BlockDriverState *bs, uint64_t guest_offset,
> - uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
> + uint64_t *host_offset, uint64_t *bytes)
> {
> BDRVQcow2State *s = bs->opaque;
> int l2_index;
> @@ -1567,7 +1567,7 @@ again:
> /*
> * 2. Count contiguous COPIED clusters.
> */
> - ret = handle_copied(bs, start, &cluster_offset, &cur_bytes, m);
> + ret = handle_copied(bs, start, &cluster_offset, &cur_bytes);
> if (ret < 0) {
> return ret;
> } else if (ret) {
>
Seems OK to me -- it is definitely unused.
(Is _that_ a problem? For qcow2 maintainers to know.)
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied
2020-03-10 2:04 ` John Snow
@ 2020-03-10 11:19 ` Alberto Garcia
2020-03-10 15:20 ` John Snow
0 siblings, 1 reply; 4+ messages in thread
From: Alberto Garcia @ 2020-03-10 11:19 UTC (permalink / raw)
To: John Snow, Yi Li, qemu-devel; +Cc: Kevin Wolf, Qemu-block, Max Reitz
On Tue 10 Mar 2020 03:04:47 AM CET, John Snow wrote:
>> static int handle_copied(BlockDriverState *bs, uint64_t guest_offset,
>> - uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
>> + uint64_t *host_offset, uint64_t *bytes)
>> {
>> BDRVQcow2State *s = bs->opaque;
>> int l2_index;
>> @@ -1567,7 +1567,7 @@ again:
>> /*
>> * 2. Count contiguous COPIED clusters.
>> */
>> - ret = handle_copied(bs, start, &cluster_offset, &cur_bytes, m);
>> + ret = handle_copied(bs, start, &cluster_offset, &cur_bytes);
>> if (ret < 0) {
>> return ret;
>> } else if (ret) {
>>
>
> Seems OK to me -- it is definitely unused.
> (Is _that_ a problem? For qcow2 maintainers to know.)
It is unused now, but I'm using it in my subcluster allocation patches:
https://lists.gnu.org/archive/html/qemu-block/2019-12/msg00588.html
(I expect to send v4 soon, probably this week)
Berto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied
2020-03-10 11:19 ` Alberto Garcia
@ 2020-03-10 15:20 ` John Snow
0 siblings, 0 replies; 4+ messages in thread
From: John Snow @ 2020-03-10 15:20 UTC (permalink / raw)
To: Alberto Garcia, Yi Li, qemu-devel; +Cc: Kevin Wolf, Qemu-block, Max Reitz
On 3/10/20 7:19 AM, Alberto Garcia wrote:
> On Tue 10 Mar 2020 03:04:47 AM CET, John Snow wrote:
>>> static int handle_copied(BlockDriverState *bs, uint64_t guest_offset,
>>> - uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
>>> + uint64_t *host_offset, uint64_t *bytes)
>>> {
>>> BDRVQcow2State *s = bs->opaque;
>>> int l2_index;
>>> @@ -1567,7 +1567,7 @@ again:
>>> /*
>>> * 2. Count contiguous COPIED clusters.
>>> */
>>> - ret = handle_copied(bs, start, &cluster_offset, &cur_bytes, m);
>>> + ret = handle_copied(bs, start, &cluster_offset, &cur_bytes);
>>> if (ret < 0) {
>>> return ret;
>>> } else if (ret) {
>>>
>>
>> Seems OK to me -- it is definitely unused.
>> (Is _that_ a problem? For qcow2 maintainers to know.)
>
> It is unused now, but I'm using it in my subcluster allocation patches:
>
> https://lists.gnu.org/archive/html/qemu-block/2019-12/msg00588.html
>
> (I expect to send v4 soon, probably this week)
>
> Berto
>
I had a hunch.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-10 15:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 16:35 [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied Yi Li
2020-03-10 2:04 ` John Snow
2020-03-10 11:19 ` Alberto Garcia
2020-03-10 15:20 ` John Snow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.