[PATCH] lsm: remove current_security()

[PATCH] lsm: remove current_security()

[Paul Moore]

There are no remaining callers and it really is unsafe in the brave
new world of LSM stacking.

Signed-off-by: Paul Moore <paul@paul-moore.com>
---
 include/linux/cred.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/cred.h b/include/linux/cred.h
index efb6edf32de7..98b0a23ddd23 100644
--- a/include/linux/cred.h
+++ b/include/linux/cred.h
@@ -384,7 +384,6 @@ static inline void put_cred(const struct cred *_cred)
 #define current_fsgid() 	(current_cred_xxx(fsgid))
 #define current_cap()		(current_cred_xxx(cap_effective))
 #define current_user()		(current_cred_xxx(user))
-#define current_security()	(current_cred_xxx(security))
 
 extern struct user_namespace init_user_ns;
 #ifdef CONFIG_USER_NS

Re: [PATCH] lsm: remove current_security()

[James Morris]

On Wed, 4 Sep 2019, Paul Moore wrote:

> There are no remaining callers and it really is unsafe in the brave
> new world of LSM stacking.
> 
> Signed-off-by: Paul Moore <paul@paul-moore.com>


Acked-by: James Morris <jamorris@linux.microsoft.com>

You might as well push this through with the SELinux changes.

-- 
James Morris
<jmorris@namei.org>

Re: [PATCH] lsm: remove current_security()

[Paul Moore]

On Wed, Sep 4, 2019 at 9:34 PM James Morris <jmorris@namei.org> wrote:
> On Wed, 4 Sep 2019, Paul Moore wrote:
>
> > There are no remaining callers and it really is unsafe in the brave
> > new world of LSM stacking.
> >
> > Signed-off-by: Paul Moore <paul@paul-moore.com>
>
> Acked-by: James Morris <jamorris@linux.microsoft.com>

Thanks.

> You might as well push this through with the SELinux changes.

That is what I was planning, it will break the build if merged via
another tree without Stephen's patch.  Merged into selinux/next to be
sent upstream during the next merge window.

-- 
paul moore
www.paul-moore.com

Re: [PATCH] lsm: remove current_security()

[Casey Schaufler]

On 9/4/2019 4:00 PM, Paul Moore wrote:
> There are no remaining callers and it really is unsafe in the brave
> new world of LSM stacking.
>
> Signed-off-by: Paul Moore <paul@paul-moore.com>

Acked-by: Casey Schaufler <casey@schaufler-ca.com>

Thanks for this. It should have gone in with the last
set of stacking patches.

> ---
>  include/linux/cred.h |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/cred.h b/include/linux/cred.h
> index efb6edf32de7..98b0a23ddd23 100644
> --- a/include/linux/cred.h
> +++ b/include/linux/cred.h
> @@ -384,7 +384,6 @@ static inline void put_cred(const struct cred *_cred)
>  #define current_fsgid() 	(current_cred_xxx(fsgid))
>  #define current_cap()		(current_cred_xxx(cap_effective))
>  #define current_user()		(current_cred_xxx(user))
> -#define current_security()	(current_cred_xxx(security))
>  
>  extern struct user_namespace init_user_ns;
>  #ifdef CONFIG_USER_NS
>
>