* [PATCH for-7.0] tests/qemu-iotests: Fix 051 for binaries without 'lsi53c895a'
@ 2021-12-06 14:34 Thomas Huth
2021-12-23 15:20 ` Hanna Reitz
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2021-12-06 14:34 UTC (permalink / raw)
To: Kevin Wolf, Hanna Reitz, qemu-devel; +Cc: qemu-block
The lsi53c895a SCSI adaptor might not be enabled in each and every
x86 QEMU binary, e.g. it's disabled in the RHEL/CentOS build.
Thus let's add a check to the 051 test so that it does not fail if
this device is not available.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/051 | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 1d2fa93a11..e9042a6214 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -45,6 +45,10 @@ _supported_proto file
_unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' data_file
_require_drivers nbd
+if [ "$QEMU_DEFAULT_MACHINE" = "pc" ]; then
+ _require_devices lsi53c895a
+fi
+
do_run_qemu()
{
echo Testing: "$@"
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-7.0] tests/qemu-iotests: Fix 051 for binaries without 'lsi53c895a'
2021-12-06 14:34 [PATCH for-7.0] tests/qemu-iotests: Fix 051 for binaries without 'lsi53c895a' Thomas Huth
@ 2021-12-23 15:20 ` Hanna Reitz
0 siblings, 0 replies; 2+ messages in thread
From: Hanna Reitz @ 2021-12-23 15:20 UTC (permalink / raw)
To: Thomas Huth, Kevin Wolf, qemu-devel; +Cc: qemu-block
On 06.12.21 15:34, Thomas Huth wrote:
> The lsi53c895a SCSI adaptor might not be enabled in each and every
> x86 QEMU binary, e.g. it's disabled in the RHEL/CentOS build.
> Thus let's add a check to the 051 test so that it does not fail if
> this device is not available.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/051 | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks, applied to my block branch:
https://gitlab.com/hreitz/qemu/-/commits/block
Hanna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-23 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 14:34 [PATCH for-7.0] tests/qemu-iotests: Fix 051 for binaries without 'lsi53c895a' Thomas Huth
2021-12-23 15:20 ` Hanna Reitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.