All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs: ref-manual: migration-3.0: remove reference to non-existing BB_SETSCENE_VERIFY_FUNCTION2
@ 2021-06-01 19:32 Quentin Schulz
  2021-06-02 14:10 ` [docs] " Michael Opdenacker
  0 siblings, 1 reply; 2+ messages in thread
From: Quentin Schulz @ 2021-06-01 19:32 UTC (permalink / raw)
  To: docs; +Cc: Quentin Schulz

This variable has been removed in July 2019 with commit
5deaa5df730a "runqueue: Drop unused BB_SETSCENE_VERIFY_FUNCTION2" in
bitbake git repo.

The glossary entry for the variable has been recently removed from bitbake
documentation, therefore the ref breaks the build.

Let's remove the reference so that the build still passes.

Signed-off-by: Quentin Schulz <foss@0leil.net>
---

This is related to
https://lists.openembedded.org/g/bitbake-devel/message/12353 patch

 documentation/ref-manual/migration-3.0.rst | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/documentation/ref-manual/migration-3.0.rst b/documentation/ref-manual/migration-3.0.rst
index f3d20e2ed..a3da85015 100644
--- a/documentation/ref-manual/migration-3.0.rst
+++ b/documentation/ref-manual/migration-3.0.rst
@@ -184,10 +184,9 @@ The following BitBake changes have occurred.
    exceptions. Remove this argument in any calls to
    ``bb.build.exec_func()`` in custom classes or scripts.
 
--  The
-   :term:`bitbake:BB_SETSCENE_VERIFY_FUNCTION2`
-   is no longer used. In the unlikely event that you have any references
-   to it, they should be removed.
+-  The ``BB_SETSCENE_VERIFY_FUNCTION2`` variable is no longer used. In
+   the unlikely event that you have any references to it, they should be
+   removed.
 
 -  The ``RunQueueExecuteScenequeue`` and ``RunQueueExecuteTasks`` events
    have been removed since setscene tasks are now executed as part of
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [docs] [PATCH] docs: ref-manual: migration-3.0: remove reference to non-existing BB_SETSCENE_VERIFY_FUNCTION2
  2021-06-01 19:32 [PATCH] docs: ref-manual: migration-3.0: remove reference to non-existing BB_SETSCENE_VERIFY_FUNCTION2 Quentin Schulz
@ 2021-06-02 14:10 ` Michael Opdenacker
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Opdenacker @ 2021-06-02 14:10 UTC (permalink / raw)
  To: docs

Hi Quentin,

On 6/1/21 9:32 PM, Quentin Schulz wrote:
> This variable has been removed in July 2019 with commit
> 5deaa5df730a "runqueue: Drop unused BB_SETSCENE_VERIFY_FUNCTION2" in
> bitbake git repo.
>
> The glossary entry for the variable has been recently removed from bitbake
> documentation, therefore the ref breaks the build.
>
> Let's remove the reference so that the build still passes.
>
> Signed-off-by: Quentin Schulz <foss@0leil.net>
> ---
>
> This is related to
> https://lists.openembedded.org/g/bitbake-devel/message/12353 patch
>
>  documentation/ref-manual/migration-3.0.rst | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/documentation/ref-manual/migration-3.0.rst b/documentation/ref-manual/migration-3.0.rst
> index f3d20e2ed..a3da85015 100644
> --- a/documentation/ref-manual/migration-3.0.rst
> +++ b/documentation/ref-manual/migration-3.0.rst
> @@ -184,10 +184,9 @@ The following BitBake changes have occurred.
>     exceptions. Remove this argument in any calls to
>     ``bb.build.exec_func()`` in custom classes or scripts.
>  
> --  The
> -   :term:`bitbake:BB_SETSCENE_VERIFY_FUNCTION2`
> -   is no longer used. In the unlikely event that you have any references
> -   to it, they should be removed.
> +-  The ``BB_SETSCENE_VERIFY_FUNCTION2`` variable is no longer used. In
> +   the unlikely event that you have any references to it, they should be
> +   removed.
>  
>  -  The ``RunQueueExecuteScenequeue`` and ``RunQueueExecuteTasks`` events
>     have been removed since setscene tasks are now executed as part of

Thanks for the patch!

Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>

Merged in master-next.
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-02 14:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 19:32 [PATCH] docs: ref-manual: migration-3.0: remove reference to non-existing BB_SETSCENE_VERIFY_FUNCTION2 Quentin Schulz
2021-06-02 14:10 ` [docs] " Michael Opdenacker

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.