From: Michael Ellerman <mpe@ellerman.id.au>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, qemu-ppc@nongnu.org,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [v2] powerpc/pseries: start rtasd before PCI probing
Date: Mon, 11 Jul 2016 20:19:34 +1000 (AEST) [thread overview]
Message-ID: <3rp1Ky5q41z9t10@ozlabs.org> (raw)
In-Reply-To: <146602104462.23192.4267928292361711364.stgit@bahia.lan>
On Wed, 2016-15-06 at 20:26:41 UTC, Greg Kurz wrote:
> A strange behaviour is observed when comparing PCI hotplug in QEMU, between
> x86 and pseries. If you consider the following steps:
> - start a VM
> - add a PCI device via the QEMU monitor before the rtasd has started (for
> example starting the VM in paused state, or hotplug during FW or boot
> loader)
> - resume the VM execution
>
> The x86 kernel detects the PCI device, but the pseries one does not.
>
> This happens because the rtasd kernel worker is currently started under
> device_initcall, while PCI probing happens earlier under subsys_initcall.
>
> As a consequence, if we have a pending RTAS event at boot time, a message
> is printed and the event is dropped.
>
> This patch moves all the initialization of rtasd to arch_initcall, which is
> run before subsys_call: this way, logging_enabled is true when the RTAS
> event pops up and it is not lost anymore.
>
> The proc fs bits stay at device_initcall because they cannot be run before
> fs_initcall.
>
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/8c6a0a1f4041f19559538649e0
cheers
prev parent reply other threads:[~2016-07-11 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:26 [PATCH v2] powerpc/pseries: start rtasd before PCI probing Greg Kurz
2016-06-21 9:02 ` [Qemu-ppc] " Greg Kurz
2016-07-07 17:26 ` Greg Kurz
2016-07-08 9:25 ` Michael Ellerman
2016-07-11 10:19 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3rp1Ky5q41z9t10@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=david@gibson.dropbear.id.au \
--cc=gkurz@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.