* [PATCH 0228/1529] Fix typo
@ 2016-05-21 12:06 Andrea Gelmini
2016-05-22 2:37 ` Paul Mackerras
0 siblings, 1 reply; 4+ messages in thread
From: Andrea Gelmini @ 2016-05-21 12:06 UTC (permalink / raw)
To: andrea.gelmini
Cc: trivial, benh, paulus, mpe, christophe.leroy, oss, linuxppc-dev
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/powerpc/lib/checksum_64.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S
index 8e6e510..f3b5b7d 100644
--- a/arch/powerpc/lib/checksum_64.S
+++ b/arch/powerpc/lib/checksum_64.S
@@ -74,7 +74,7 @@ _GLOBAL(__csum_partial)
ld r11,24(r3)
/*
- * On POWER6 and POWER7 back to back addes take 2 cycles because of
+ * On POWER6 and POWER7 back to back adds take 2 cycles because of
* the XER dependency. This means the fastest this loop can go is
* 16 cycles per iteration. The scheduling of the loop below has
* been shown to hit this on both POWER6 and POWER7.
@@ -275,7 +275,7 @@ source; ld r10,16(r3)
source; ld r11,24(r3)
/*
- * On POWER6 and POWER7 back to back addes take 2 cycles because of
+ * On POWER6 and POWER7 back to back adds take 2 cycles because of
* the XER dependency. This means the fastest this loop can go is
* 16 cycles per iteration. The scheduling of the loop below has
* been shown to hit this on both POWER6 and POWER7.
--
2.8.2.534.g1f66975
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0228/1529] Fix typo
2016-05-21 12:06 [PATCH 0228/1529] Fix typo Andrea Gelmini
@ 2016-05-22 2:37 ` Paul Mackerras
2016-05-23 1:27 ` [PATCH] Clarify that adde is an instruction and we mean plural Stewart Smith
0 siblings, 1 reply; 4+ messages in thread
From: Paul Mackerras @ 2016-05-22 2:37 UTC (permalink / raw)
To: Andrea Gelmini; +Cc: trivial, benh, mpe, christophe.leroy, oss, linuxppc-dev
On Sat, May 21, 2016 at 02:06:18PM +0200, Andrea Gelmini wrote:
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> arch/powerpc/lib/checksum_64.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S
> index 8e6e510..f3b5b7d 100644
> --- a/arch/powerpc/lib/checksum_64.S
> +++ b/arch/powerpc/lib/checksum_64.S
> @@ -74,7 +74,7 @@ _GLOBAL(__csum_partial)
> ld r11,24(r3)
>
> /*
> - * On POWER6 and POWER7 back to back addes take 2 cycles because of
> + * On POWER6 and POWER7 back to back adds take 2 cycles because of
> * the XER dependency. This means the fastest this loop can go is
> * 16 cycles per iteration. The scheduling of the loop below has
> * been shown to hit this on both POWER6 and POWER7.
> @@ -275,7 +275,7 @@ source; ld r10,16(r3)
> source; ld r11,24(r3)
>
> /*
> - * On POWER6 and POWER7 back to back addes take 2 cycles because of
> + * On POWER6 and POWER7 back to back adds take 2 cycles because of
> * the XER dependency. This means the fastest this loop can go is
> * 16 cycles per iteration. The scheduling of the loop below has
> * been shown to hit this on both POWER6 and POWER7.
NAK - this is talking about the 'adde' instruction, not the 'add'
instruction.
Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Clarify that adde is an instruction and we mean plural
2016-05-22 2:37 ` Paul Mackerras
@ 2016-05-23 1:27 ` Stewart Smith
2016-07-17 10:28 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Stewart Smith @ 2016-05-23 1:27 UTC (permalink / raw)
To: paulus, andrea.gelmini; +Cc: trivial, oss, linuxppc-dev, Stewart Smith
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
arch/powerpc/lib/checksum_64.S | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S
index 8e6e510..fdec6e6 100644
--- a/arch/powerpc/lib/checksum_64.S
+++ b/arch/powerpc/lib/checksum_64.S
@@ -74,9 +74,9 @@ _GLOBAL(__csum_partial)
ld r11,24(r3)
/*
- * On POWER6 and POWER7 back to back addes take 2 cycles because of
- * the XER dependency. This means the fastest this loop can go is
- * 16 cycles per iteration. The scheduling of the loop below has
+ * On POWER6 and POWER7 back to back adde instructions take 2 cycles
+ * because of the XER dependency. This means the fastest this loop can
+ * go is 16 cycles per iteration. The scheduling of the loop below has
* been shown to hit this on both POWER6 and POWER7.
*/
.align 5
@@ -275,9 +275,9 @@ source; ld r10,16(r3)
source; ld r11,24(r3)
/*
- * On POWER6 and POWER7 back to back addes take 2 cycles because of
- * the XER dependency. This means the fastest this loop can go is
- * 16 cycles per iteration. The scheduling of the loop below has
+ * On POWER6 and POWER7 back to back adde instructions take 2 cycles
+ * because of the XER dependency. This means the fastest this loop can
+ * go is 16 cycles per iteration. The scheduling of the loop below has
* been shown to hit this on both POWER6 and POWER7.
*/
.align 5
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Clarify that adde is an instruction and we mean plural
2016-05-23 1:27 ` [PATCH] Clarify that adde is an instruction and we mean plural Stewart Smith
@ 2016-07-17 10:28 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2016-07-17 10:28 UTC (permalink / raw)
To: Stewart Smith, paulus, andrea.gelmini
Cc: oss, linuxppc-dev, trivial, Stewart Smith
On Mon, 2016-23-05 at 01:27:01 UTC, Stewart Smith wrote:
> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/ec5619fdba66f091b5b987f980
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-17 10:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-21 12:06 [PATCH 0228/1529] Fix typo Andrea Gelmini
2016-05-22 2:37 ` Paul Mackerras
2016-05-23 1:27 ` [PATCH] Clarify that adde is an instruction and we mean plural Stewart Smith
2016-07-17 10:28 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.