From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-sunxi@googlegroups.com, maxime.ripard@bootlin.com
Cc: codekipper@gmail.com, wens@csie.org,
linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com,
broonie@kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, be17068@iperbole.bo.it
Subject: Re: [linux-sunxi] Re: [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings
Date: Wed, 14 Aug 2019 13:31:04 +0200 [thread overview]
Message-ID: <4005451.bVnTXbg3Co@jernej-laptop> (raw)
In-Reply-To: <20190814072007.6tfvhzsw4oxbwpc2@flea>
Dne sreda, 14. avgust 2019 ob 09:20:07 CEST je Maxime Ripard napisal(a):
> On Wed, Aug 14, 2019 at 08:08:54AM +0200, codekipper@gmail.com wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Bypass the regmap cache when flushing the i2s FIFOs and modify the tables
> > to reflect this.
> >
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
>
> This patch looks like it's fixing something while the commit log
> doesn't mention what is being fixed.
Main issue addressed here is that SUN4I_I2S_FIFO_CTRL_REG has two self-clear
registers (SUN4I_I2S_FIFO_CTRL_FLUSH_RX and SUN4I_I2S_FIFO_CTRL_FLUSH_TX) and
thus it should be marked as volatile.
Best regards,
Jernej
>
> Having some context here would be great.
>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-sunxi@googlegroups.com, maxime.ripard@bootlin.com
Cc: alsa-devel@alsa-project.org, be17068@iperbole.bo.it,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
codekipper@gmail.com, wens@csie.org, broonie@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-sunxi] Re: [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings
Date: Wed, 14 Aug 2019 13:31:04 +0200 [thread overview]
Message-ID: <4005451.bVnTXbg3Co@jernej-laptop> (raw)
In-Reply-To: <20190814072007.6tfvhzsw4oxbwpc2@flea>
Dne sreda, 14. avgust 2019 ob 09:20:07 CEST je Maxime Ripard napisal(a):
> On Wed, Aug 14, 2019 at 08:08:54AM +0200, codekipper@gmail.com wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Bypass the regmap cache when flushing the i2s FIFOs and modify the tables
> > to reflect this.
> >
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
>
> This patch looks like it's fixing something while the commit log
> doesn't mention what is being fixed.
Main issue addressed here is that SUN4I_I2S_FIFO_CTRL_REG has two self-clear
registers (SUN4I_I2S_FIFO_CTRL_FLUSH_RX and SUN4I_I2S_FIFO_CTRL_FLUSH_TX) and
thus it should be marked as volatile.
Best regards,
Jernej
>
> Having some context here would be great.
>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-14 11:31 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 6:08 [PATCH v5 00/15] ASoC: sun4i-i2s: Updates to the driver codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 6:08 ` [PATCH v5 01/15] ASoC: sun4i-i2s: Add regmap field to sign extend sample codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 6:43 ` Maxime Ripard
2019-08-14 6:43 ` Maxime Ripard
2019-08-14 11:24 ` Code Kipper
2019-08-14 11:24 ` Code Kipper
2019-08-14 11:24 ` Code Kipper
2019-08-14 6:08 ` [PATCH v5 02/15] ASoC: sun4i-i2s: Add set_tdm_slot functionality codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 7:09 ` Maxime Ripard
2019-08-14 7:09 ` Maxime Ripard
2019-08-14 7:09 ` Maxime Ripard
2019-08-16 6:27 ` Code Kipper
2019-08-16 6:27 ` Code Kipper
2019-08-16 6:27 ` Code Kipper
2019-08-14 9:30 ` Mark Brown
2019-08-14 9:30 ` Mark Brown
2019-08-14 9:30 ` Mark Brown
2019-08-16 6:22 ` Code Kipper
2019-08-16 6:22 ` Code Kipper
2019-08-16 6:22 ` Code Kipper
2019-08-14 6:08 ` [PATCH v5 03/15] ASoC: sun4i-i2s: Correct divider calculations codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 7:13 ` Maxime Ripard
2019-08-14 7:13 ` Maxime Ripard
2019-08-14 7:13 ` Maxime Ripard
2019-08-14 9:31 ` Mark Brown
2019-08-14 9:31 ` Mark Brown
2019-08-14 9:31 ` Mark Brown
2019-08-14 6:08 ` [PATCH v5 04/15] ASoC: sun4i-i2s: Support more formats on newer SoCs codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 7:16 ` Maxime Ripard
2019-08-14 7:16 ` Maxime Ripard
2019-08-14 7:16 ` Maxime Ripard
2019-08-14 11:23 ` Code Kipper
2019-08-14 11:23 ` Code Kipper
2019-08-14 11:23 ` Code Kipper
2019-08-14 6:08 ` [PATCH v5 05/15] ASoC: sun4i-i2s: Add functions for RX and TX channel offsets codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 6:08 ` [PATCH v5 06/15] ASoC: sun4i-i2s: Add functions for RX and TX channel enables codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 6:08 ` [PATCH v5 07/15] ASoC: sun4i-i2s: Add functions for RX and TX channel selects codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 6:08 ` [PATCH v5 08/15] ASoC: sun4i-i2s: Add functions for channel mapping codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 6:08 ` [PATCH v5 09/15] clk: sunxi-ng: h6: Allow I2S to change parent rate codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-21 4:07 ` [linux-sunxi] " Chen-Yu Tsai
2019-08-21 4:07 ` Chen-Yu Tsai
2019-08-21 4:07 ` Chen-Yu Tsai
2019-08-21 5:52 ` [linux-sunxi] " Code Kipper
2019-08-21 5:52 ` Code Kipper
2019-08-21 5:52 ` Code Kipper
2019-08-21 6:01 ` [linux-sunxi] " Chen-Yu Tsai
2019-08-21 6:01 ` Chen-Yu Tsai
2019-08-21 6:01 ` Chen-Yu Tsai
2019-08-21 9:19 ` Code Kipper
2019-08-21 9:19 ` Code Kipper
2019-08-21 9:19 ` Code Kipper
2019-08-21 9:35 ` [linux-sunxi] " Chen-Yu Tsai
2019-08-21 9:35 ` Chen-Yu Tsai
2019-08-21 9:35 ` Chen-Yu Tsai
2019-08-14 6:08 ` [PATCH v5 10/15] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 6:08 ` [PATCH v5 11/15] ASoC: sun4i-i2s: Add support for H6 I2S codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 7:57 ` Jernej Škrabec
2019-08-14 7:57 ` Jernej Škrabec
2019-08-14 7:57 ` Jernej Škrabec
2019-08-14 11:08 ` Code Kipper
2019-08-14 11:08 ` Code Kipper
2019-08-14 11:08 ` Code Kipper
2019-08-14 6:08 ` [PATCH v5 12/15] ASoC: sun4i-i2s: Add multi-lane functionality codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 7:20 ` Maxime Ripard
2019-08-14 7:20 ` Maxime Ripard
2019-08-14 7:20 ` Maxime Ripard
2019-08-14 11:16 ` Code Kipper
2019-08-14 11:16 ` Code Kipper
2019-08-14 11:16 ` Code Kipper
2019-08-14 8:27 ` [linux-sunxi] " Jernej Škrabec
2019-08-14 8:27 ` Jernej Škrabec
2019-08-14 8:27 ` Jernej Škrabec
2019-08-14 6:08 ` [PATCH v5 13/15] ASoC: sun4i-i2s: Add multichannel functionality codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 6:08 ` [PATCH v5 14/15] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 8:28 ` [linux-sunxi] " Jernej Škrabec
2019-08-14 8:28 ` Jernej Škrabec
2019-08-14 8:28 ` Jernej Škrabec
2019-08-14 9:03 ` [linux-sunxi] " Code Kipper
2019-08-14 9:03 ` Code Kipper
2019-08-14 9:03 ` Code Kipper
2019-08-14 6:08 ` [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings codekipper
2019-08-14 6:08 ` codekipper
2019-08-14 6:08 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14 7:20 ` Maxime Ripard
2019-08-14 7:20 ` Maxime Ripard
2019-08-14 7:20 ` Maxime Ripard
2019-08-14 11:31 ` Jernej Škrabec [this message]
2019-08-14 11:31 ` [linux-sunxi] " Jernej Škrabec
2019-08-14 8:37 ` [linux-sunxi] " Jernej Škrabec
2019-08-14 8:37 ` Jernej Škrabec
2019-08-14 8:37 ` Jernej Škrabec
2019-08-14 9:02 ` [linux-sunxi] " Code Kipper
2019-08-14 9:02 ` Code Kipper
2019-08-14 9:02 ` Code Kipper
2019-08-14 11:31 ` Chen-Yu Tsai
2019-08-14 11:31 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4005451.bVnTXbg3Co@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=be17068@iperbole.bo.it \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.