All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	linux-efi@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
	"Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Subject: Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images
Date: Wed, 15 Feb 2017 19:59:30 +0100	[thread overview]
Message-ID: <4014c5e6-b5a0-7552-166f-a42992532c09@siemens.com> (raw)
In-Reply-To: <1bf3c9d8-56aa-818b-350f-deb62ad14e08@siemens.com>

On 2017-02-15 19:50, Jan Kiszka wrote:
> On 2017-02-15 19:46, Andy Shevchenko wrote:
>> On Wed, Feb 15, 2017 at 8:14 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> See patch 2 for the background.
>>>
>>> Series has been tested on the Galileo Gen2, to exclude regressions, with
>>> a firmware.cap without security header and the SIMATIC IOT2040 which
>>> requires the header because of its mandatory secure boot.
>>
>> Briefly looking to the code it looks like a real hack.
>> Sorry, but it would be carefully (re-)designed.
> 
> The interface that the firmware provides us? That should have been done
> differently, I agree, but I'm not too much into those firmware details,
> specifically when it comes to signatures.
> 
> The Linux code was designed around that suboptimal situation. If there
> are better ideas, I'm all ears.
> 

Expanding CC's as requested by Andy.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
To: Andy Shevchenko
	<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Matt Fleming
	<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
	Ard Biesheuvel
	<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
	"Kweh,
	Hock Leong"
	<hock.leong.kweh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Bryan O'Donoghue
	<pure.logic-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>
Subject: Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images
Date: Wed, 15 Feb 2017 19:59:30 +0100	[thread overview]
Message-ID: <4014c5e6-b5a0-7552-166f-a42992532c09@siemens.com> (raw)
In-Reply-To: <1bf3c9d8-56aa-818b-350f-deb62ad14e08-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>

On 2017-02-15 19:50, Jan Kiszka wrote:
> On 2017-02-15 19:46, Andy Shevchenko wrote:
>> On Wed, Feb 15, 2017 at 8:14 PM, Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org> wrote:
>>> See patch 2 for the background.
>>>
>>> Series has been tested on the Galileo Gen2, to exclude regressions, with
>>> a firmware.cap without security header and the SIMATIC IOT2040 which
>>> requires the header because of its mandatory secure boot.
>>
>> Briefly looking to the code it looks like a real hack.
>> Sorry, but it would be carefully (re-)designed.
> 
> The interface that the firmware provides us? That should have been done
> differently, I agree, but I'm not too much into those firmware details,
> specifically when it comes to signatures.
> 
> The Linux code was designed around that suboptimal situation. If there
> are better ideas, I'm all ears.
> 

Expanding CC's as requested by Andy.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2017-02-15 19:00 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 18:14 [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images Jan Kiszka
2017-02-15 18:14 ` [PATCH 1/2] efi/capsule: Prepare for loading images with security header Jan Kiszka
2017-02-15 18:14 ` [PATCH 2/2] efi/capsule: Add support for Quark " Jan Kiszka
2017-02-17  1:30   ` Bryan O'Donoghue
2017-02-17  1:30     ` Bryan O'Donoghue
2017-03-24 16:44     ` Jan Kiszka
2017-03-24 16:44       ` Jan Kiszka
2017-02-15 18:17 ` [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images Ard Biesheuvel
2017-02-15 18:17   ` Ard Biesheuvel
2017-02-15 18:47   ` Jan Kiszka
2017-02-15 18:47     ` Jan Kiszka
2017-02-15 18:41 ` Andy Shevchenko
2017-02-15 18:41   ` Andy Shevchenko
2017-02-15 18:46 ` Andy Shevchenko
2017-02-15 18:46   ` Andy Shevchenko
2017-02-15 18:50   ` Jan Kiszka
2017-02-15 18:50     ` Jan Kiszka
2017-02-15 18:59     ` Jan Kiszka [this message]
2017-02-15 18:59       ` Jan Kiszka
2017-02-16  3:00       ` Kweh, Hock Leong
2017-02-16  3:00         ` Kweh, Hock Leong
2017-02-16  7:29         ` Jan Kiszka
2017-02-16  7:29           ` Jan Kiszka
2017-02-18 21:48           ` Ard Biesheuvel
2017-02-19 13:33             ` Jan Kiszka
2017-02-19 13:33               ` Jan Kiszka
2017-02-20  1:33               ` Bryan O'Donoghue
2017-02-20  1:52                 ` Jan Kiszka
2017-02-20  1:52                   ` Jan Kiszka
2017-03-24 15:18                 ` Jan Kiszka
2017-02-17  0:53         ` Bryan O'Donoghue
2017-02-17  0:53           ` Bryan O'Donoghue
2017-02-17  8:23           ` Kweh, Hock Leong
2017-02-17  8:23             ` Kweh, Hock Leong
2017-02-17  9:24             ` Jan Kiszka
2017-02-17  9:24               ` Jan Kiszka
2017-02-28 12:12               ` Matt Fleming
2017-02-28 12:12                 ` Matt Fleming
2017-02-28 12:20                 ` Jan Kiszka
2017-02-28 12:20                   ` Jan Kiszka
2017-02-28 12:29                   ` Matt Fleming
2017-02-28 13:25                     ` Ard Biesheuvel
2017-02-28 13:25                       ` Ard Biesheuvel
2017-02-28 13:35                       ` Andy Shevchenko
2017-02-28 13:35                         ` Andy Shevchenko
2017-02-28 13:36                         ` Andy Shevchenko
2017-02-28 13:36                           ` Andy Shevchenko
2017-02-28 15:07                           ` Bryan O'Donoghue
2017-02-28 15:07                             ` Bryan O'Donoghue
2017-02-28 15:09                             ` Bryan O'Donoghue
2017-02-28 15:27                             ` Andy Shevchenko
2017-02-28 16:52                               ` Bryan O'Donoghue
2017-02-28 17:18                                 ` Andy Shevchenko
2017-02-28 17:42                                   ` Bryan O'Donoghue
2017-02-28 17:42                                     ` Bryan O'Donoghue
2017-03-01 14:02                                     ` Bryan O'Donoghue
2017-03-01 14:02                                       ` Bryan O'Donoghue
2017-03-01 14:55                                       ` Andy Shevchenko
2017-02-17  9:51             ` Bryan O'Donoghue
2017-02-17  9:51               ` Bryan O'Donoghue
2017-02-17 10:14               ` Jan Kiszka
2017-02-17 10:14                 ` Jan Kiszka
2017-02-17 11:42                 ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4014c5e6-b5a0-7552-166f-a42992532c09@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bp@alien8.de \
    --cc=hock.leong.kweh@intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=pure.logic@nexus-software.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.