* imx: smatch errors
@ 2019-02-07 14:33 Hans Verkuil
2019-02-16 9:27 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2019-02-07 14:33 UTC (permalink / raw)
To: Steve Longerbeam; +Cc: Linux Media Mailing List
Hi Steve,
It turns out that the daily build never compiled the staging media drivers,
which included imx. Now that I enabled it I get these three errors:
drivers/staging/media/imx/imx-media-vdic.c:236 prepare_vdi_in_buffers() error: uninitialized symbol 'prev_phys'.
drivers/staging/media/imx/imx-media-vdic.c:237 prepare_vdi_in_buffers() error: uninitialized symbol 'curr_phys'.
drivers/staging/media/imx/imx-media-vdic.c:238 prepare_vdi_in_buffers() error: uninitialized symbol 'next_phys'.
Can you take a look? The root cause is that the switch doesn't have
a default case.
I expect that this is easy to fix, but I'm not sure what the fix should be,
otherwise I would have made a patch for you.
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: imx: smatch errors
2019-02-07 14:33 imx: smatch errors Hans Verkuil
@ 2019-02-16 9:27 ` Hans Verkuil
2019-02-17 23:52 ` Steve Longerbeam
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2019-02-16 9:27 UTC (permalink / raw)
To: Steve Longerbeam; +Cc: Linux Media Mailing List, Philipp Zabel
On 2/7/19 3:33 PM, Hans Verkuil wrote:
> Hi Steve,
>
> It turns out that the daily build never compiled the staging media drivers,
> which included imx. Now that I enabled it I get these three errors:
>
> drivers/staging/media/imx/imx-media-vdic.c:236 prepare_vdi_in_buffers() error: uninitialized symbol 'prev_phys'.
> drivers/staging/media/imx/imx-media-vdic.c:237 prepare_vdi_in_buffers() error: uninitialized symbol 'curr_phys'.
> drivers/staging/media/imx/imx-media-vdic.c:238 prepare_vdi_in_buffers() error: uninitialized symbol 'next_phys'.
>
> Can you take a look? The root cause is that the switch doesn't have
> a default case.
>
> I expect that this is easy to fix, but I'm not sure what the fix should be,
> otherwise I would have made a patch for you.
Ping!
Regards,
Hans
>
> Regards,
>
> Hans
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: imx: smatch errors
2019-02-16 9:27 ` Hans Verkuil
@ 2019-02-17 23:52 ` Steve Longerbeam
0 siblings, 0 replies; 3+ messages in thread
From: Steve Longerbeam @ 2019-02-17 23:52 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List, Philipp Zabel
Hi Hans, pardon the delay, I will post a patch for this tomorrow.
Steve
On 2/16/19 1:27 AM, Hans Verkuil wrote:
> On 2/7/19 3:33 PM, Hans Verkuil wrote:
>> Hi Steve,
>>
>> It turns out that the daily build never compiled the staging media drivers,
>> which included imx. Now that I enabled it I get these three errors:
>>
>> drivers/staging/media/imx/imx-media-vdic.c:236 prepare_vdi_in_buffers() error: uninitialized symbol 'prev_phys'.
>> drivers/staging/media/imx/imx-media-vdic.c:237 prepare_vdi_in_buffers() error: uninitialized symbol 'curr_phys'.
>> drivers/staging/media/imx/imx-media-vdic.c:238 prepare_vdi_in_buffers() error: uninitialized symbol 'next_phys'.
>>
>> Can you take a look? The root cause is that the switch doesn't have
>> a default case.
>>
>> I expect that this is easy to fix, but I'm not sure what the fix should be,
>> otherwise I would have made a patch for you.
> Ping!
>
> Regards,
>
> Hans
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-17 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-07 14:33 imx: smatch errors Hans Verkuil
2019-02-16 9:27 ` Hans Verkuil
2019-02-17 23:52 ` Steve Longerbeam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.