Re: [PATCH] drm/vc4: Fix memory leak of the CRTC state.

Re: [PATCH] drm/vc4: Fix memory leak of the CRTC state.

[Stefan Wahren]

Hi Eric,

could you please resend this patch [1], because it's still not applied in Linux 4.10-rc2.

Thanks
Stefan

[1] - https://patchwork.kernel.org/patch/9369793/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/vc4: Fix memory leak of the CRTC state.

[Stefan Wahren]

> Hi Eric,
>
> could you please resend this patch [1], because it's still not applied in Linux 4.10-rc2.
>
> Thanks
> Stefan
>
> [1] - https://patchwork.kernel.org/patch/9369793/

ping ...
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/vc4: Fix memory leak of the CRTC state.

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 347 bytes --]

Stefan Wahren <stefan.wahren@i2se.com> writes:

>> Hi Eric,
>>
>> could you please resend this patch [1], because it's still not applied in Linux 4.10-rc2.
>>
>> Thanks
>> Stefan
>>
>> [1] - https://patchwork.kernel.org/patch/9369793/
>
> ping ...

It's in drm-vc4-fixes now.  I just sent out two more fixes, and I should
send the -fixes PR soon.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/vc4: Fix memory leak of the CRTC state.

[Eric Anholt]

The underscores variant frees the pointers inside, while the
no-underscores variant calls underscores and then frees the struct.

Signed-off-by: Eric Anholt <eric@anholt.net>
Fixes: d8dbf44f13b9 ("drm/vc4: Make the CRTCs cooperate on allocating display lists.")
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/vc4/vc4_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index 7f08d681a74b..d544ff9b0d46 100644
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
@@ -832,7 +832,7 @@ static void vc4_crtc_destroy_state(struct drm_crtc *crtc,
 
 	}
 
-	__drm_atomic_helper_crtc_destroy_state(state);
+	drm_atomic_helper_crtc_destroy_state(crtc, state);
 }
 
 static const struct drm_crtc_funcs vc4_crtc_funcs = {
-- 
2.9.3