[Buildroot] ffmpeg: disable mmal in 64bit arm

[Buildroot] ffmpeg: disable mmal in 64bit arm

[Guillermo G]

[-- Attachment #1.1: Type: text/plain, Size: 1733 bytes --]

Hello! This is my first time writing to the buildroot mailing list, so
first thanks everyone for all the work that goes into this project, it's
really great.

I have found a possible error in the ffmpeg configuration (present in 2023.02.1
but also in master). Specifically in package/ffmpeg/ffmpeg.mk - Line 284
<https://github.com/buildroot/buildroot/blob/11aa7ac8fa3a21dc2476dd09539ea3cf3e48f03d/package/ffmpeg/ffmpeg.mk#L284>
.

I am building for a 64bit ARM target, and mmal is not available for 64bit
ARM <https://github.com/raspberrypi/userland/issues/688>, therefore my
build crashes because it automatically sets the option --enable-mmal.
I modified line 285 manually to --disable-mmal which results in a working
build and a working ffmpeg buildroot (tested), but I was wondering if it
could be fixed for other users.

@fhunleth <https://github.com/fhunleth> from the Nerves project helped me
out to come up with a patch proposal
<https://gist.github.com/guillego/6e6c47c93f845d4477c0307dc4c1c772> so that
it gets disabled for 64 bit arm targets.

I've never submitted a patch so I thought it would be best to first search
in the mailing list and since I didn't find anything, send an email to see
what you think.

Additional details:

   - Host: Mac OS. Apple Silicon M1.
   - Buildroot version: 23.02.1
   - Target: Raspberry Pi 3A+/Zero 2W
   - Package for which the build fails: ffmpeg 4.4.4
   - Error message (simplified):

-----
>>> ffmpeg 4.4.4 Patching libtool
>>> ffmpeg 4.4.4 Configuring
[...ommited verbose...]
ERROR: mmal not found

make[1]: *** [package/pkg-generic.mk:283:
/nerves/build/build/ffmpeg-4.4.4/.stamp_configured] Error 1
make: *** [Makefile:23: _all] Error 2
-----

Thanks a lot!

Best,

Guillermo

[-- Attachment #1.2: Type: text/html, Size: 2589 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] ffmpeg: disable mmal in 64bit arm

[Arnout Vandecappelle via buildroot]

On 05/07/2023 10:58, Guillermo G wrote:
> Hello! This is my first time writing to the buildroot mailing list, so first 
> thanks everyone for all the work that goes into this project, it's really great.
> 
> I have found a possible error in the ffmpeg configuration (present in 2023.02.1 
> but also in master). Specifically in package/ffmpeg/ffmpeg.mk - Line 284 
> <https://github.com/buildroot/buildroot/blob/11aa7ac8fa3a21dc2476dd09539ea3cf3e48f03d/package/ffmpeg/ffmpeg.mk#L284>.
> 
> I am building for a 64bit ARM target, and mmal is not available for 64bit ARM 
> <https://github.com/raspberrypi/userland/issues/688>, therefore my build crashes 
> because it automatically sets the option --enable-mmal.
> I modified line 285 manually to --disable-mmal which results in a working build 
> and a working ffmpeg buildroot (tested), but I was wondering if it could be 
> fixed for other users.
> 
> @fhunleth <https://github.com/fhunleth> from the Nerves project helped me out to 
> come up with a patch proposal 
> <https://gist.github.com/guillego/6e6c47c93f845d4477c0307dc4c1c772> so that it 
> gets disabled for 64 bit arm targets.

  Bernd sent a patch [1] that does more or less that.

  Applied to master, thanks.

  Regards,
  Arnout

[1] 
https://patchwork.ozlabs.org/project/buildroot/patch/20230705161042.700055-1-bernd@kuhls.net/


> 
> I've never submitted a patch so I thought it would be best to first search in 
> the mailing list and since I didn't find anything, send an email to see what you 
> think.
> 
> Additional details:
> 
>   * Host: Mac OS. Apple Silicon M1.
>   * Buildroot version: 23.02.1
>   * Target: Raspberry Pi 3A+/Zero 2W
>   * Package for which the build fails: ffmpeg 4.4.4
>   * Error message (simplified):
> 
> -----
>  >>> ffmpeg 4.4.4 Patching libtool
>  >>> ffmpeg 4.4.4 Configuring
> [...ommited verbose...]
> ERROR: mmal not found
> 
> make[1]: *** [package/pkg-generic.mk:283 <http://pkg-generic.mk:283>: 
> /nerves/build/build/ffmpeg-4.4.4/.stamp_configured] Error 1
> make: *** [Makefile:23: _all] Error 2
> -----
> 
> Thanks a lot!
> 
> Best,
> 
> Guillermo
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot