All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] brcmfmac: add CYW43570 PCIE device
@ 2021-11-23  6:24 Lin Ian (CSSITB CSS ICW SW WFS / EE)
  2021-11-23 12:32 ` Arend van Spriel
  0 siblings, 1 reply; 5+ messages in thread
From: Lin Ian (CSSITB CSS ICW SW WFS / EE) @ 2021-11-23  6:24 UTC (permalink / raw)
  To: linux-wireless
  Cc: brcm80211-dev-list, brcm80211-dev-list, Arend van Spriel,
	Franky Lin, Hante Meuleman, Kalle Valo, Chi-Hsien.Lin

From: Soontak Lee <soontak.lee@cypress.com>

CYW43570 is a 3-antenna, 2x2 MIMO,802.11a/b/g/n/ac, PCIe 3.0 for WLAN.
It is BT/WIFI combo.

Signed-off-by: Soontak Lee <soontak.lee@cypress.com>
Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Jira:SWLINUX-1213
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 1 +
  drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 +
  2 files changed, 2 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c 
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index 8b149996fc00..ceeb1f10752a 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -2106,6 +2106,7 @@ static const struct pci_device_id 
brcmf_pcie_devid_table[] = {
      BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_DEVICE_ID),
+    BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_RAW_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_4358_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_4359_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_DEVICE_ID),
diff --git 
a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h 
b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
index 9d81320164ce..3bbe2388ec54 100644
--- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
+++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
@@ -71,6 +71,7 @@
  #define BRCM_PCIE_4356_DEVICE_ID    0x43ec
  #define BRCM_PCIE_43567_DEVICE_ID    0x43d3
  #define BRCM_PCIE_43570_DEVICE_ID    0x43d9
+#define BRCM_PCIE_43570_RAW_DEVICE_ID    0xaa31
  #define BRCM_PCIE_4358_DEVICE_ID    0x43e9
  #define BRCM_PCIE_4359_DEVICE_ID    0x43ef
  #define BRCM_PCIE_43602_DEVICE_ID    0x43ba
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: add CYW43570 PCIE device
  2021-11-23  6:24 [PATCH] brcmfmac: add CYW43570 PCIE device Lin Ian (CSSITB CSS ICW SW WFS / EE)
@ 2021-11-23 12:32 ` Arend van Spriel
  2021-11-25  9:29   ` Lin Ian (CSSITB CSS ICW SW WFS / EE)
  0 siblings, 1 reply; 5+ messages in thread
From: Arend van Spriel @ 2021-11-23 12:32 UTC (permalink / raw)
  To: Lin Ian (CSSITB CSS ICW SW WFS / EE), linux-wireless
  Cc: brcm80211-dev-list, brcm80211-dev-list, Franky Lin,
	Hante Meuleman, Kalle Valo, Chi-Hsien.Lin

[-- Attachment #1: Type: text/plain, Size: 2162 bytes --]

On November 23, 2021 7:24:32 AM "Lin Ian (CSSITB CSS ICW SW WFS / EE)" 
<ian.lin-ee@infineon.com> wrote:

> From: Soontak Lee <soontak.lee@cypress.com>
>
> CYW43570 is a 3-antenna, 2x2 MIMO,802.11a/b/g/n/ac, PCIe 3.0 for WLAN.
> It is BT/WIFI combo.
>
> Signed-off-by: Soontak Lee <soontak.lee@cypress.com>
> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>

Missing signoff

> Jira:SWLINUX-1213

Meaningless to the public so remove it when submitting to the community.

> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 1 +
>  drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> index 8b149996fc00..ceeb1f10752a 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> @@ -2106,6 +2106,7 @@ static const struct pci_device_id
> brcmf_pcie_devid_table[] = {
>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_DEVICE_ID),
> +    BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_RAW_DEVICE_ID),
>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4358_DEVICE_ID),
>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4359_DEVICE_ID),
>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_DEVICE_ID),
> diff --git
> a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> index 9d81320164ce..3bbe2388ec54 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> @@ -71,6 +71,7 @@
>  #define BRCM_PCIE_4356_DEVICE_ID    0x43ec
>  #define BRCM_PCIE_43567_DEVICE_ID    0x43d3
>  #define BRCM_PCIE_43570_DEVICE_ID    0x43d9
> +#define BRCM_PCIE_43570_RAW_DEVICE_ID    0xaa31

It is just a name, but what does RAW mean here? Also 0xaa31 is 43569 in 
decimal. Is this really a valid device ID or is this an unprogrammed 
device (without valid devid in OTP).

Regards,
Arend

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: add CYW43570 PCIE device
  2021-11-23 12:32 ` Arend van Spriel
@ 2021-11-25  9:29   ` Lin Ian (CSSITB CSS ICW SW WFS / EE)
  2021-11-25  9:44     ` Arend van Spriel
  0 siblings, 1 reply; 5+ messages in thread
From: Lin Ian (CSSITB CSS ICW SW WFS / EE) @ 2021-11-25  9:29 UTC (permalink / raw)
  To: Arend van Spriel, linux-wireless
  Cc: brcm80211-dev-list, brcm80211-dev-list, Franky Lin,
	Hante Meuleman, Kalle Valo, Chi-Hsien.Lin, Wright.Feng,
	Double.Lo



On 11/23/2021 8:32 PM, Arend van Spriel wrote:
> On November 23, 2021 7:24:32 AM "Lin Ian (CSSITB CSS ICW SW WFS / EE)" 
> <ian.lin-ee@infineon.com> wrote:
>
>> From: Soontak Lee <soontak.lee@cypress.com>
>>
>> CYW43570 is a 3-antenna, 2x2 MIMO,802.11a/b/g/n/ac, PCIe 3.0 for WLAN.
>> It is BT/WIFI combo.
>>
>> Signed-off-by: Soontak Lee <soontak.lee@cypress.com>
>> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
>
> Missing signoff
>
>> Jira:SWLINUX-1213
>
> Meaningless to the public so remove it when submitting to the community.
I will send a new patch mail that modified the commit message, thank you.

>> ---
>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 1 +
>>  drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>> index 8b149996fc00..ceeb1f10752a 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>> @@ -2106,6 +2106,7 @@ static const struct pci_device_id
>> brcmf_pcie_devid_table[] = {
>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_DEVICE_ID),
>> +    BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_RAW_DEVICE_ID),
>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4358_DEVICE_ID),
>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4359_DEVICE_ID),
>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_DEVICE_ID),
>> diff --git
>> a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>> b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>> index 9d81320164ce..3bbe2388ec54 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>> @@ -71,6 +71,7 @@
>>  #define BRCM_PCIE_4356_DEVICE_ID    0x43ec
>>  #define BRCM_PCIE_43567_DEVICE_ID    0x43d3
>>  #define BRCM_PCIE_43570_DEVICE_ID    0x43d9
>> +#define BRCM_PCIE_43570_RAW_DEVICE_ID    0xaa31
>
> It is just a name, but what does RAW mean here? Also 0xaa31 is 43569 
> in decimal. Is this really a valid device ID or is this an 
> unprogrammed device (without valid devid in OTP).
It's a unprogrammed device, basically 0xaa31 is the id with blank OTP.


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: add CYW43570 PCIE device
  2021-11-25  9:29   ` Lin Ian (CSSITB CSS ICW SW WFS / EE)
@ 2021-11-25  9:44     ` Arend van Spriel
  2021-11-29  7:39       ` Lin Ian (CSSITB CSS ICW SW WFS / EE)
  0 siblings, 1 reply; 5+ messages in thread
From: Arend van Spriel @ 2021-11-25  9:44 UTC (permalink / raw)
  To: Lin Ian (CSSITB CSS ICW SW WFS / EE), linux-wireless
  Cc: brcm80211-dev-list, brcm80211-dev-list, Franky Lin,
	Hante Meuleman, Kalle Valo, Chi-Hsien.Lin, Wright.Feng,
	Double.Lo

[-- Attachment #1: Type: text/plain, Size: 2871 bytes --]

On 11/25/2021 10:29 AM, Lin Ian (CSSITB CSS ICW SW WFS / EE) wrote:
> 
> 
> On 11/23/2021 8:32 PM, Arend van Spriel wrote:
>> On November 23, 2021 7:24:32 AM "Lin Ian (CSSITB CSS ICW SW WFS / EE)" 
>> <ian.lin-ee@infineon.com> wrote:
>>
>>> From: Soontak Lee <soontak.lee@cypress.com>
>>>
>>> CYW43570 is a 3-antenna, 2x2 MIMO,802.11a/b/g/n/ac, PCIe 3.0 for WLAN.
>>> It is BT/WIFI combo.
>>>
>>> Signed-off-by: Soontak Lee <soontak.lee@cypress.com>
>>> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
>>
>> Missing signoff
>>
>>> Jira:SWLINUX-1213
>>
>> Meaningless to the public so remove it when submitting to the community.
> I will send a new patch mail that modified the commit message, thank you.

great.

>>> ---
>>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 1 +
>>>  drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 +
>>>  2 files changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> index 8b149996fc00..ceeb1f10752a 100644
>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>> @@ -2106,6 +2106,7 @@ static const struct pci_device_id
>>> brcmf_pcie_devid_table[] = {
>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_DEVICE_ID),
>>> +    BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_RAW_DEVICE_ID),
>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4358_DEVICE_ID),
>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4359_DEVICE_ID),
>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_DEVICE_ID),
>>> diff --git
>>> a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> index 9d81320164ce..3bbe2388ec54 100644
>>> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>> @@ -71,6 +71,7 @@
>>>  #define BRCM_PCIE_4356_DEVICE_ID    0x43ec
>>>  #define BRCM_PCIE_43567_DEVICE_ID    0x43d3
>>>  #define BRCM_PCIE_43570_DEVICE_ID    0x43d9
>>> +#define BRCM_PCIE_43570_RAW_DEVICE_ID    0xaa31
>>
>> It is just a name, but what does RAW mean here? Also 0xaa31 is 43569 
>> in decimal. Is this really a valid device ID or is this an 
>> unprogrammed device (without valid devid in OTP).
> It's a unprogrammed device, basically 0xaa31 is the id with blank OTP.

So do we expect linux end-users to come across such a device. As far as 
I know a device with unprogrammed OTP will use the chip id as the PCI 
devid. If this is needed to enable development with unprogrammed devices 
I would suggest to have these under Kconfig option.

Regards,
Arend

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: add CYW43570 PCIE device
  2021-11-25  9:44     ` Arend van Spriel
@ 2021-11-29  7:39       ` Lin Ian (CSSITB CSS ICW SW WFS / EE)
  0 siblings, 0 replies; 5+ messages in thread
From: Lin Ian (CSSITB CSS ICW SW WFS / EE) @ 2021-11-29  7:39 UTC (permalink / raw)
  To: Arend van Spriel, linux-wireless
  Cc: brcm80211-dev-list, brcm80211-dev-list, Franky Lin,
	Hante Meuleman, Kalle Valo, Chi-Hsien.Lin, Wright.Feng,
	Double.Lo



On 11/25/2021 5:44 PM, Arend van Spriel wrote:
> On 11/25/2021 10:29 AM, Lin Ian (CSSITB CSS ICW SW WFS / EE) wrote:
>>
>>
>> On 11/23/2021 8:32 PM, Arend van Spriel wrote:
>>> On November 23, 2021 7:24:32 AM "Lin Ian (CSSITB CSS ICW SW WFS / 
>>> EE)" <ian.lin-ee@infineon.com> wrote:
>>>
>>>> From: Soontak Lee <soontak.lee@cypress.com>
>>>>
>>>> CYW43570 is a 3-antenna, 2x2 MIMO,802.11a/b/g/n/ac, PCIe 3.0 for WLAN.
>>>> It is BT/WIFI combo.
>>>>
>>>> Signed-off-by: Soontak Lee <soontak.lee@cypress.com>
>>>> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
>>>
>>> Missing signoff
>>>
>>>> Jira:SWLINUX-1213
>>>
>>> Meaningless to the public so remove it when submitting to the 
>>> community.
>> I will send a new patch mail that modified the commit message, thank 
>> you.
>
> great.
>
>>>> ---
>>>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 1 +
>>>>  drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 +
>>>>  2 files changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>>> index 8b149996fc00..ceeb1f10752a 100644
>>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
>>>> @@ -2106,6 +2106,7 @@ static const struct pci_device_id
>>>> brcmf_pcie_devid_table[] = {
>>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
>>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
>>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_DEVICE_ID),
>>>> +    BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_RAW_DEVICE_ID),
>>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4358_DEVICE_ID),
>>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_4359_DEVICE_ID),
>>>>      BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_DEVICE_ID),
>>>> diff --git
>>>> a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>>> b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>>> index 9d81320164ce..3bbe2388ec54 100644
>>>> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>>> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
>>>> @@ -71,6 +71,7 @@
>>>>  #define BRCM_PCIE_4356_DEVICE_ID    0x43ec
>>>>  #define BRCM_PCIE_43567_DEVICE_ID    0x43d3
>>>>  #define BRCM_PCIE_43570_DEVICE_ID    0x43d9
>>>> +#define BRCM_PCIE_43570_RAW_DEVICE_ID    0xaa31
>>>
>>> It is just a name, but what does RAW mean here? Also 0xaa31 is 43569 
>>> in decimal. Is this really a valid device ID or is this an 
>>> unprogrammed device (without valid devid in OTP).
>> It's a unprogrammed device, basically 0xaa31 is the id with blank OTP.
>
> So do we expect linux end-users to come across such a device. As far 
> as I know a device with unprogrammed OTP will use the chip id as the 
> PCI devid. If this is needed to enable development with unprogrammed 
> devices I would suggest to have these under Kconfig option.
Some end-users use the driver to do MFG process, so the RAW device ID is 
supposed to be supported.
We don't expect user should modify kconfig for this, so directly add in 
driver is reasonable.



^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-29  7:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23  6:24 [PATCH] brcmfmac: add CYW43570 PCIE device Lin Ian (CSSITB CSS ICW SW WFS / EE)
2021-11-23 12:32 ` Arend van Spriel
2021-11-25  9:29   ` Lin Ian (CSSITB CSS ICW SW WFS / EE)
2021-11-25  9:44     ` Arend van Spriel
2021-11-29  7:39       ` Lin Ian (CSSITB CSS ICW SW WFS / EE)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.