From: Arnd Bergmann <arnd@arndb.de>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: "Zhang Rui" <rui.zhang@intel.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Caesar Wang" <caesar.wang@rock-chips.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"Tao Huang" <huangtao@rock-chips.com>,
"Eddie Cai" <cf@rock-chips.com>,
"Douglas Anderson" <dianders@chromium.org>,
dtor <dtor@chromium.org>, "Chris Zhong" <zyw@rock-chips.com>,
"addy.ke@rock-chips.com" <addy.ke@rock-chips.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
zhaoyifeng <zyf@rock-chips.com>
Subject: Re: [PATCH v4 2/4] dt-bindings: document Rockchip thermal
Date: Thu, 11 Sep 2014 14:32:08 +0200 [thread overview]
Message-ID: <40514790.Xc34lyFLGa@wuerfel> (raw)
In-Reply-To: <20140911121842.GB26715@developer>
On Thursday 11 September 2014 08:18:43 Eduardo Valentin wrote:
> > As what we want is to make thermal driver have a chance to configure the
> > hardware shutdown registers, I'm thinking if we can do this without
> > representing the hardware shutdown value as a trip point.
> > Say,
> > 1. parse DT, and get the hardware shutdown temperature value, and store
> > it somewhere, e.g. struct __thermal_zone.
> > 2. introduce a new parameter, int (*set_hardware_trip)(void *, long *),
> > in thermal_zone_of_sensor_register().
> > 3. invoke set_hard_trip(tz, hardware_shutdown_temperature_value) in
> > thermal_zone_of_sensor_register().
>
> The only issue I have with the above proposal is that not all platforms
> use DT. Some still boot with boardfiles, for instance. Thus, the
> parameter to configure hardware thermal shutdown needs to be common on
> thermal core, not specific to of-thermal. Do you agree?
Do you know of a machine that can't yet be converted to DT and that
needs this driver? In case of rockchips that is certainly not the
case, and we don't care about anybody trying to use board files out
of tree, they can just hack the thermal support as well.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] dt-bindings: document Rockchip thermal
Date: Thu, 11 Sep 2014 14:32:08 +0200 [thread overview]
Message-ID: <40514790.Xc34lyFLGa@wuerfel> (raw)
In-Reply-To: <20140911121842.GB26715@developer>
On Thursday 11 September 2014 08:18:43 Eduardo Valentin wrote:
> > As what we want is to make thermal driver have a chance to configure the
> > hardware shutdown registers, I'm thinking if we can do this without
> > representing the hardware shutdown value as a trip point.
> > Say,
> > 1. parse DT, and get the hardware shutdown temperature value, and store
> > it somewhere, e.g. struct __thermal_zone.
> > 2. introduce a new parameter, int (*set_hardware_trip)(void *, long *),
> > in thermal_zone_of_sensor_register().
> > 3. invoke set_hard_trip(tz, hardware_shutdown_temperature_value) in
> > thermal_zone_of_sensor_register().
>
> The only issue I have with the above proposal is that not all platforms
> use DT. Some still boot with boardfiles, for instance. Thus, the
> parameter to configure hardware thermal shutdown needs to be common on
> thermal core, not specific to of-thermal. Do you agree?
Do you know of a machine that can't yet be converted to DT and that
needs this driver? In case of rockchips that is certainly not the
case, and we don't care about anybody trying to use board files out
of tree, they can just hack the thermal support as well.
Arnd
next prev parent reply other threads:[~2014-09-11 12:32 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 2:10 [PATCH v4 0/4] Rockchip soc thermal driver Caesar Wang
2014-09-03 2:10 ` Caesar Wang
2014-09-03 2:10 ` [PATCH v4 1/4] thermal: rockchip: add driver for thermal Caesar Wang
2014-09-03 2:10 ` Caesar Wang
2014-08-30 20:09 ` Eduardo Valentin
2014-08-30 20:09 ` Eduardo Valentin
2014-09-10 4:39 ` Caesar Wang
2014-09-10 4:39 ` Caesar Wang
2014-09-10 12:46 ` Eduardo Valentin
2014-09-10 12:46 ` Eduardo Valentin
2014-09-10 13:21 ` Caesar Wang
2014-09-10 13:21 ` Caesar Wang
2014-09-10 13:21 ` Caesar Wang
2014-09-17 7:29 ` Caesar Wang
2014-09-17 7:29 ` Caesar Wang
2014-09-04 17:06 ` Dmitry Torokhov
2014-09-04 17:06 ` Dmitry Torokhov
2014-09-05 0:33 ` Caesar Wang
2014-09-05 0:33 ` Caesar Wang
2014-09-03 2:10 ` [PATCH v4 2/4] dt-bindings: document Rockchip thermal Caesar Wang
2014-09-03 2:10 ` Caesar Wang
2014-09-03 8:07 ` Heiko Stübner
2014-09-03 8:07 ` Heiko Stübner
2014-09-04 1:02 ` Caesar Wang
2014-09-04 1:02 ` Caesar Wang
2014-09-09 2:27 ` Zhang Rui
2014-09-09 2:27 ` Zhang Rui
2014-09-09 11:35 ` Heiko Stübner
2014-09-09 11:35 ` Heiko Stübner
2014-09-09 11:35 ` Heiko Stübner
2014-09-09 15:09 ` Eduardo Valentin
2014-09-09 15:09 ` Eduardo Valentin
2014-09-09 15:09 ` Eduardo Valentin
2014-09-10 1:02 ` Zhang Rui
2014-09-10 1:02 ` Zhang Rui
2014-09-10 1:14 ` edubezval
2014-09-10 1:14 ` edubezval at gmail.com
2014-09-10 7:24 ` Heiko Stübner
2014-09-10 7:24 ` Heiko Stübner
2014-09-10 7:24 ` Heiko Stübner
2014-09-11 2:36 ` Zhang Rui
2014-09-11 2:36 ` Zhang Rui
2014-09-11 2:36 ` Zhang Rui
2014-09-11 12:18 ` Eduardo Valentin
2014-09-11 12:18 ` Eduardo Valentin
2014-09-11 12:18 ` Eduardo Valentin
2014-09-11 12:32 ` Arnd Bergmann [this message]
2014-09-11 12:32 ` Arnd Bergmann
2014-09-11 15:53 ` Eduardo Valentin
2014-09-11 15:53 ` Eduardo Valentin
2014-09-16 7:23 ` Zhang Rui
2014-09-16 7:23 ` Zhang Rui
2014-09-16 7:45 ` Zhang Rui
2014-09-16 7:45 ` Zhang Rui
2014-09-03 2:10 ` [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288 Caesar Wang
2014-09-03 2:10 ` Caesar Wang
2014-09-09 11:37 ` Heiko Stübner
2014-09-09 11:37 ` Heiko Stübner
2014-09-10 2:49 ` Caesar Wang
2014-09-10 2:49 ` Caesar Wang
2014-09-11 13:58 ` Heiko Stübner
2014-09-11 13:58 ` Heiko Stübner
2014-09-11 13:58 ` Heiko Stübner
2014-09-03 2:10 ` [PATCH v4 4/4] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang
2014-09-03 2:10 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40514790.Xc34lyFLGa@wuerfel \
--to=arnd@arndb.de \
--cc=addy.ke@rock-chips.com \
--cc=caesar.wang@rock-chips.com \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@chromium.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=zyf@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.