[PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c

[PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c

[Rashika Kheria]

This patch marks the function gru_get_cb_exception_detail_str() and
gru_abort() as static in sgi-gru/grukservices.c because they are not
used outside this file.

Thus, it also eliminates the following warnings in
sgi-gru/grukservices.c:
drivers/misc/sgi-gru/grukservices.c:432:7: warning: no previous prototype for ‘gru_get_cb_exception_detail_str’ [-Wmissing-prototypes]
drivers/misc/sgi-gru/grukservices.c:508:6: warning: no previous prototype for ‘gru_abort’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/misc/sgi-gru/grukservices.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
index 913de07..29d1582 100644
--- a/drivers/misc/sgi-gru/grukservices.c
+++ b/drivers/misc/sgi-gru/grukservices.c
@@ -429,7 +429,7 @@ int gru_get_cb_exception_detail(void *cb,
 	return 0;
 }
 
-char *gru_get_cb_exception_detail_str(int ret, void *cb,
+static char *gru_get_cb_exception_detail_str(int ret, void *cb,
 				      char *buf, int size)
 {
 	struct gru_control_block_status *gen = (void *)cb;
@@ -505,7 +505,7 @@ int gru_wait_proc(void *cb)
 	return ret;
 }
 
-void gru_abort(int ret, void *cb, char *str)
+static void gru_abort(int ret, void *cb, char *str)
 {
 	char buf[GRU_EXC_STR_SIZE];
 
-- 
1.7.9.5

[PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

[Rashika Kheria]

This patch marks the function xp_init() and xp_exit() as static in
sgi-xp/xp_main.c because they are not used outside this file.

Thus, it also eliminates the following warnings in sgi-xp/xp_main.c:
drivers/misc/sgi-xp/xp_main.c:249:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-prototypes]
drivers/misc/sgi-xp/xp_main.c:274:1: warning: no previous prototype for ‘xp_exit’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/misc/sgi-xp/xp_main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/sgi-xp/xp_main.c b/drivers/misc/sgi-xp/xp_main.c
index 01be66d..df14c70 100644
--- a/drivers/misc/sgi-xp/xp_main.c
+++ b/drivers/misc/sgi-xp/xp_main.c
@@ -245,7 +245,7 @@ xpc_disconnect(int ch_number)
 }
 EXPORT_SYMBOL_GPL(xpc_disconnect);
 
-int __init
+static int __init
 xp_init(void)
 {
 	enum xp_retval ret;
@@ -270,7 +270,7 @@ xp_init(void)
 
 module_init(xp_init);
 
-void __exit
+static void __exit
 xp_exit(void)
 {
 	if (is_shub())
-- 
1.7.9.5

[PATCH 3/5] drivers: misc: Mark functions as static in xpc_main.c

[Rashika Kheria]

This patch marks the function xpc_init() and xpc_exit() as static in
sgi-xp/xpc_main.c because they are not used outside this file.

Thus, it also eliminates the following warnings in sgi-xp/xpc_main.c:
drivers/misc/sgi-xp/xpc_main.c:1231:1: warning: no previous prototype for ‘xpc_init’ [-Wmissing-prototypes]
drivers/misc/sgi-xp/xpc_main.c:1349:1: warning: no previous prototype for ‘xpc_exit’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/misc/sgi-xp/xpc_main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c
index 82dc574..5b1b10d 100644
--- a/drivers/misc/sgi-xp/xpc_main.c
+++ b/drivers/misc/sgi-xp/xpc_main.c
@@ -1227,7 +1227,7 @@ xpc_system_die(struct notifier_block *nb, unsigned long event, void *_die_args)
 	return NOTIFY_DONE;
 }
 
-int __init
+static int __init
 xpc_init(void)
 {
 	int ret;
@@ -1345,7 +1345,7 @@ out_1:
 
 module_init(xpc_init);
 
-void __exit
+static void __exit
 xpc_exit(void)
 {
 	xpc_do_exit(xpUnloading);
-- 
1.7.9.5

[PATCH 4/5] drivers: misc: Mark functions as static in ad525x_dpot.c

[Rashika Kheria]

This patch marks the function ad_dpot_add_files() and
ad_dpot_remove_files() as static in ad525x_dpot.c because they are not
used outside this file.

Thus, it also eliminates the following warnings in ad525x_dpot.c:
drivers/misc/ad525x_dpot.c:644:5: warning: no previous prototype for ‘ad_dpot_add_files’ [-Wmissing-prototypes]
drivers/misc/ad525x_dpot.c:669:13: warning: no previous prototype for ‘ad_dpot_remove_files’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/misc/ad525x_dpot.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
index 0daadcf..d3eee11 100644
--- a/drivers/misc/ad525x_dpot.c
+++ b/drivers/misc/ad525x_dpot.c
@@ -641,7 +641,7 @@ static const struct attribute_group ad525x_group_commands = {
 	.attrs = ad525x_attributes_commands,
 };
 
-int ad_dpot_add_files(struct device *dev,
+static int ad_dpot_add_files(struct device *dev,
 		unsigned features, unsigned rdac)
 {
 	int err = sysfs_create_file(&dev->kobj,
@@ -666,7 +666,7 @@ int ad_dpot_add_files(struct device *dev,
 	return err;
 }
 
-inline void ad_dpot_remove_files(struct device *dev,
+static inline void ad_dpot_remove_files(struct device *dev,
 		unsigned features, unsigned rdac)
 {
 	sysfs_remove_file(&dev->kobj,
-- 
1.7.9.5

[PATCH 5/5] drivers: misc: Mark function jp_generic_ide_ioctl() as static in lkdtm.c

[Rashika Kheria]

This patch marks the function jp_generic_ide_ioctl() as static in
lkdtm.c because it is not used outside this file.

Thus, it also eliminates the following warnings in lkdtm.c:
drivers/misc/lkdtm.c:227:5: warning: no previous prototype for ‘jp_generic_ide_ioctl’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/misc/lkdtm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
index a2edb2e..79b677e 100644
--- a/drivers/misc/lkdtm.c
+++ b/drivers/misc/lkdtm.c
@@ -224,7 +224,7 @@ static int jp_scsi_dispatch_cmd(struct scsi_cmnd *cmd)
 }
 
 #ifdef CONFIG_IDE
-int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
+static int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
 			struct block_device *bdev, unsigned int cmd,
 			unsigned long arg)
 {
-- 
1.7.9.5

Re: [PATCH 4/5] drivers: misc: Mark functions as static in ad525x_dpot.c

[Michael Hennerich]

On 12/13/2013 07:57 AM, Rashika Kheria wrote:
> This patch marks the function ad_dpot_add_files() and
> ad_dpot_remove_files() as static in ad525x_dpot.c because they are not
> used outside this file.
>
> Thus, it also eliminates the following warnings in ad525x_dpot.c:
> drivers/misc/ad525x_dpot.c:644:5: warning: no previous prototype for ‘ad_dpot_add_files’ [-Wmissing-prototypes]
> drivers/misc/ad525x_dpot.c:669:13: warning: no previous prototype for ‘ad_dpot_remove_files’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
>   drivers/misc/ad525x_dpot.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
> index 0daadcf..d3eee11 100644
> --- a/drivers/misc/ad525x_dpot.c
> +++ b/drivers/misc/ad525x_dpot.c
> @@ -641,7 +641,7 @@ static const struct attribute_group ad525x_group_commands = {
>   	.attrs = ad525x_attributes_commands,
>   };
>   
> -int ad_dpot_add_files(struct device *dev,
> +static int ad_dpot_add_files(struct device *dev,
>   		unsigned features, unsigned rdac)
>   {
>   	int err = sysfs_create_file(&dev->kobj,
> @@ -666,7 +666,7 @@ int ad_dpot_add_files(struct device *dev,
>   	return err;
>   }
>   
> -inline void ad_dpot_remove_files(struct device *dev,
> +static inline void ad_dpot_remove_files(struct device *dev,
>   		unsigned features, unsigned rdac)
>   {
>   	sysfs_remove_file(&dev->kobj,


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif

Re: [PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c

[Josh Triplett]

On Fri, Dec 13, 2013 at 12:12:34PM +0530, Rashika Kheria wrote:
> This patch marks the function gru_get_cb_exception_detail_str() and
> gru_abort() as static in sgi-gru/grukservices.c because they are not
> used outside this file.
> 
> Thus, it also eliminates the following warnings in
> sgi-gru/grukservices.c:
> drivers/misc/sgi-gru/grukservices.c:432:7: warning: no previous prototype for ‘gru_get_cb_exception_detail_str’ [-Wmissing-prototypes]
> drivers/misc/sgi-gru/grukservices.c:508:6: warning: no previous prototype for ‘gru_abort’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/misc/sgi-gru/grukservices.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 913de07..29d1582 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -429,7 +429,7 @@ int gru_get_cb_exception_detail(void *cb,
>  	return 0;
>  }
>  
> -char *gru_get_cb_exception_detail_str(int ret, void *cb,
> +static char *gru_get_cb_exception_detail_str(int ret, void *cb,
>  				      char *buf, int size)
>  {
>  	struct gru_control_block_status *gen = (void *)cb;
> @@ -505,7 +505,7 @@ int gru_wait_proc(void *cb)
>  	return ret;
>  }
>  
> -void gru_abort(int ret, void *cb, char *str)
> +static void gru_abort(int ret, void *cb, char *str)
>  {
>  	char buf[GRU_EXC_STR_SIZE];
>  
> -- 
> 1.7.9.5
> 

Re: [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

[Josh Triplett]

On Fri, Dec 13, 2013 at 12:21:20PM +0530, Rashika Kheria wrote:
> This patch marks the function xp_init() and xp_exit() as static in
> sgi-xp/xp_main.c because they are not used outside this file.
> 
> Thus, it also eliminates the following warnings in sgi-xp/xp_main.c:
> drivers/misc/sgi-xp/xp_main.c:249:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-prototypes]
> drivers/misc/sgi-xp/xp_main.c:274:1: warning: no previous prototype for ‘xp_exit’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/misc/sgi-xp/xp_main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-xp/xp_main.c b/drivers/misc/sgi-xp/xp_main.c
> index 01be66d..df14c70 100644
> --- a/drivers/misc/sgi-xp/xp_main.c
> +++ b/drivers/misc/sgi-xp/xp_main.c
> @@ -245,7 +245,7 @@ xpc_disconnect(int ch_number)
>  }
>  EXPORT_SYMBOL_GPL(xpc_disconnect);
>  
> -int __init
> +static int __init
>  xp_init(void)
>  {
>  	enum xp_retval ret;
> @@ -270,7 +270,7 @@ xp_init(void)
>  
>  module_init(xp_init);
>  
> -void __exit
> +static void __exit
>  xp_exit(void)
>  {
>  	if (is_shub())
> -- 
> 1.7.9.5
> 

Re: [PATCH 3/5] drivers: misc: Mark functions as static in xpc_main.c

[Josh Triplett]

On Fri, Dec 13, 2013 at 12:24:05PM +0530, Rashika Kheria wrote:
> This patch marks the function xpc_init() and xpc_exit() as static in
> sgi-xp/xpc_main.c because they are not used outside this file.
> 
> Thus, it also eliminates the following warnings in sgi-xp/xpc_main.c:
> drivers/misc/sgi-xp/xpc_main.c:1231:1: warning: no previous prototype for ‘xpc_init’ [-Wmissing-prototypes]
> drivers/misc/sgi-xp/xpc_main.c:1349:1: warning: no previous prototype for ‘xpc_exit’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/misc/sgi-xp/xpc_main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c
> index 82dc574..5b1b10d 100644
> --- a/drivers/misc/sgi-xp/xpc_main.c
> +++ b/drivers/misc/sgi-xp/xpc_main.c
> @@ -1227,7 +1227,7 @@ xpc_system_die(struct notifier_block *nb, unsigned long event, void *_die_args)
>  	return NOTIFY_DONE;
>  }
>  
> -int __init
> +static int __init
>  xpc_init(void)
>  {
>  	int ret;
> @@ -1345,7 +1345,7 @@ out_1:
>  
>  module_init(xpc_init);
>  
> -void __exit
> +static void __exit
>  xpc_exit(void)
>  {
>  	xpc_do_exit(xpUnloading);
> -- 
> 1.7.9.5
> 

Re: [PATCH 4/5] drivers: misc: Mark functions as static in ad525x_dpot.c

[Josh Triplett]

On Fri, Dec 13, 2013 at 12:27:10PM +0530, Rashika Kheria wrote:
> This patch marks the function ad_dpot_add_files() and
> ad_dpot_remove_files() as static in ad525x_dpot.c because they are not
> used outside this file.
> 
> Thus, it also eliminates the following warnings in ad525x_dpot.c:
> drivers/misc/ad525x_dpot.c:644:5: warning: no previous prototype for ‘ad_dpot_add_files’ [-Wmissing-prototypes]
> drivers/misc/ad525x_dpot.c:669:13: warning: no previous prototype for ‘ad_dpot_remove_files’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/misc/ad525x_dpot.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
> index 0daadcf..d3eee11 100644
> --- a/drivers/misc/ad525x_dpot.c
> +++ b/drivers/misc/ad525x_dpot.c
> @@ -641,7 +641,7 @@ static const struct attribute_group ad525x_group_commands = {
>  	.attrs = ad525x_attributes_commands,
>  };
>  
> -int ad_dpot_add_files(struct device *dev,
> +static int ad_dpot_add_files(struct device *dev,
>  		unsigned features, unsigned rdac)
>  {
>  	int err = sysfs_create_file(&dev->kobj,
> @@ -666,7 +666,7 @@ int ad_dpot_add_files(struct device *dev,
>  	return err;
>  }
>  
> -inline void ad_dpot_remove_files(struct device *dev,
> +static inline void ad_dpot_remove_files(struct device *dev,
>  		unsigned features, unsigned rdac)
>  {
>  	sysfs_remove_file(&dev->kobj,
> -- 
> 1.7.9.5
> 

Re: [PATCH 5/5] drivers: misc: Mark function jp_generic_ide_ioctl() as static in lkdtm.c

[Josh Triplett]

On Fri, Dec 13, 2013 at 12:29:42PM +0530, Rashika Kheria wrote:
> This patch marks the function jp_generic_ide_ioctl() as static in
> lkdtm.c because it is not used outside this file.
> 
> Thus, it also eliminates the following warnings in lkdtm.c:
> drivers/misc/lkdtm.c:227:5: warning: no previous prototype for ‘jp_generic_ide_ioctl’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/misc/lkdtm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
> index a2edb2e..79b677e 100644
> --- a/drivers/misc/lkdtm.c
> +++ b/drivers/misc/lkdtm.c
> @@ -224,7 +224,7 @@ static int jp_scsi_dispatch_cmd(struct scsi_cmnd *cmd)
>  }
>  
>  #ifdef CONFIG_IDE
> -int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
> +static int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
>  			struct block_device *bdev, unsigned int cmd,
>  			unsigned long arg)
>  {
> -- 
> 1.7.9.5
> 

Re: [PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c

[Dimitri Sivanich]

On Fri, Dec 13, 2013 at 12:12:34PM +0530, Rashika Kheria wrote:
> This patch marks the function gru_get_cb_exception_detail_str() and
> gru_abort() as static in sgi-gru/grukservices.c because they are not
> used outside this file.
> 
> Thus, it also eliminates the following warnings in
> sgi-gru/grukservices.c:
> drivers/misc/sgi-gru/grukservices.c:432:7: warning: no previous prototype for ‘gru_get_cb_exception_detail_str’ [-Wmissing-prototypes]
> drivers/misc/sgi-gru/grukservices.c:508:6: warning: no previous prototype for ‘gru_abort’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Acked-by: Dimitri Sivanich <sivanich@sgi.com>

> ---
>  drivers/misc/sgi-gru/grukservices.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 913de07..29d1582 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -429,7 +429,7 @@ int gru_get_cb_exception_detail(void *cb,
>  	return 0;
>  }
>  
> -char *gru_get_cb_exception_detail_str(int ret, void *cb,
> +static char *gru_get_cb_exception_detail_str(int ret, void *cb,
>  				      char *buf, int size)
>  {
>  	struct gru_control_block_status *gen = (void *)cb;
> @@ -505,7 +505,7 @@ int gru_wait_proc(void *cb)
>  	return ret;
>  }
>  
> -void gru_abort(int ret, void *cb, char *str)
> +static void gru_abort(int ret, void *cb, char *str)
>  {
>  	char buf[GRU_EXC_STR_SIZE];
>  
> -- 
> 1.7.9.5

Re: [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

[Robin Holt]

On Fri, Dec 13, 2013 at 2:56 AM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Fri, Dec 13, 2013 at 12:21:20PM +0530, Rashika Kheria wrote:
>> This patch marks the function xp_init() and xp_exit() as static in
>> sgi-xp/xp_main.c because they are not used outside this file.
>>
>> Thus, it also eliminates the following warnings in sgi-xp/xp_main.c:
>> drivers/misc/sgi-xp/xp_main.c:249:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-prototypes]
>> drivers/misc/sgi-xp/xp_main.c:274:1: warning: no previous prototype for ‘xp_exit’ [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: Robin Holt <robinmholt@gmail.com>

>
>>  drivers/misc/sgi-xp/xp_main.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/misc/sgi-xp/xp_main.c b/drivers/misc/sgi-xp/xp_main.c
>> index 01be66d..df14c70 100644
>> --- a/drivers/misc/sgi-xp/xp_main.c
>> +++ b/drivers/misc/sgi-xp/xp_main.c
>> @@ -245,7 +245,7 @@ xpc_disconnect(int ch_number)
>>  }
>>  EXPORT_SYMBOL_GPL(xpc_disconnect);
>>
>> -int __init
>> +static int __init
>>  xp_init(void)
>>  {
>>       enum xp_retval ret;
>> @@ -270,7 +270,7 @@ xp_init(void)
>>
>>  module_init(xp_init);
>>
>> -void __exit
>> +static void __exit
>>  xp_exit(void)
>>  {
>>       if (is_shub())
>> --
>> 1.7.9.5
>>

Re: [PATCH 3/5] drivers: misc: Mark functions as static in xpc_main.c

[Robin Holt]

On Fri, Dec 13, 2013 at 2:57 AM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Fri, Dec 13, 2013 at 12:24:05PM +0530, Rashika Kheria wrote:
>> This patch marks the function xpc_init() and xpc_exit() as static in
>> sgi-xp/xpc_main.c because they are not used outside this file.
>>
>> Thus, it also eliminates the following warnings in sgi-xp/xpc_main.c:
>> drivers/misc/sgi-xp/xpc_main.c:1231:1: warning: no previous prototype for ‘xpc_init’ [-Wmissing-prototypes]
>> drivers/misc/sgi-xp/xpc_main.c:1349:1: warning: no previous prototype for ‘xpc_exit’ [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: Robin Holt <robinmholt@gmail.com>

>
>>  drivers/misc/sgi-xp/xpc_main.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c
>> index 82dc574..5b1b10d 100644
>> --- a/drivers/misc/sgi-xp/xpc_main.c
>> +++ b/drivers/misc/sgi-xp/xpc_main.c
>> @@ -1227,7 +1227,7 @@ xpc_system_die(struct notifier_block *nb, unsigned long event, void *_die_args)
>>       return NOTIFY_DONE;
>>  }
>>
>> -int __init
>> +static int __init
>>  xpc_init(void)
>>  {
>>       int ret;
>> @@ -1345,7 +1345,7 @@ out_1:
>>
>>  module_init(xpc_init);
>>
>> -void __exit
>> +static void __exit
>>  xpc_exit(void)
>>  {
>>       xpc_do_exit(xpUnloading);
>> --
>> 1.7.9.5
>>