All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins
@ 2020-08-22 20:36 Marek Vasut
  2020-08-22 20:57 ` [Linux-stm32] " Ahmad Fatoum
  2020-08-28 12:47 ` Alexandre Torgue
  0 siblings, 2 replies; 7+ messages in thread
From: Marek Vasut @ 2020-08-22 20:36 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marek Vasut, Alexandre Torgue, Patrice Chotard, Patrick Delaunay,
	Maxime Coquelin, Manivannan Sadhasivam, linux-stm32

Add another mux option for DCMI pins, this is used on AV96 board.

Upstream-Status: Work-in-progress
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 37 ++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index 1c4c3d32efae..d6847787c65a 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -118,6 +118,43 @@ pins {
 		};
 	};
 
+	dcmi_pins_b: dcmi-1 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
+				 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
+				 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
+				 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
+				 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
+				 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
+				 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
+				 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
+				 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
+				 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
+				 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
+				 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
+				 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
+			bias-pull-up;
+		};
+	};
+
+	dcmi_sleep_pins_b: dcmi-sleep-1 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
+				 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
+				 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
+				 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
+				 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
+				 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */
+				 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
+				 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
+				 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
+				 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
+				 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
+				 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
+				 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
+		};
+	};
+
 	ethernet0_rgmii_pins_a: rgmii-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('G', 5, AF11)>, /* ETH_RGMII_CLK125 */
-- 
2.28.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins
  2020-08-22 20:36 [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins Marek Vasut
@ 2020-08-22 20:57 ` Ahmad Fatoum
  2020-08-22 21:48   ` Marek Vasut
  2020-08-28 12:47 ` Alexandre Torgue
  1 sibling, 1 reply; 7+ messages in thread
From: Ahmad Fatoum @ 2020-08-22 20:57 UTC (permalink / raw)
  To: Marek Vasut, linux-arm-kernel
  Cc: linux-stm32, Maxime Coquelin, Patrick Delaunay, Manivannan Sadhasivam

Hi,

On 8/22/20 10:36 PM, Marek Vasut wrote:
> Add another mux option for DCMI pins, this is used on AV96 board.
> 
> Upstream-Status: Work-in-progress

Is this a left-over? What is its meaning here?

Cheers,

> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 37 ++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index 1c4c3d32efae..d6847787c65a 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -118,6 +118,43 @@ pins {
>  		};
>  	};
>  
> +	dcmi_pins_b: dcmi-1 {
> +		pins {
> +			pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
> +				 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
> +				 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
> +				 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
> +				 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
> +				 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
> +				 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
> +				 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
> +				 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
> +				 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
> +				 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
> +				 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
> +				 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
> +			bias-pull-up;
> +		};
> +	};
> +
> +	dcmi_sleep_pins_b: dcmi-sleep-1 {
> +		pins {
> +			pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
> +				 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
> +				 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
> +				 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
> +				 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
> +				 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */
> +				 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
> +				 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
> +				 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
> +				 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
> +				 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
> +				 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
> +				 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
> +		};
> +	};
> +
>  	ethernet0_rgmii_pins_a: rgmii-0 {
>  		pins1 {
>  			pinmux = <STM32_PINMUX('G', 5, AF11)>, /* ETH_RGMII_CLK125 */
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins
  2020-08-22 20:57 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-08-22 21:48   ` Marek Vasut
  0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2020-08-22 21:48 UTC (permalink / raw)
  To: Ahmad Fatoum, linux-arm-kernel
  Cc: linux-stm32, Maxime Coquelin, Patrick Delaunay, Manivannan Sadhasivam

On 8/22/20 10:57 PM, Ahmad Fatoum wrote:
> Hi,

Hi,

> On 8/22/20 10:36 PM, Marek Vasut wrote:
>> Add another mux option for DCMI pins, this is used on AV96 board.
>>
>> Upstream-Status: Work-in-progress
> 
> Is this a left-over? What is its meaning here?

Yep, it's to track the patch status when backporting.
Should be removed.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins
  2020-08-22 20:36 [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins Marek Vasut
  2020-08-22 20:57 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-08-28 12:47 ` Alexandre Torgue
  2020-08-28 12:52   ` Marek Vasut
  1 sibling, 1 reply; 7+ messages in thread
From: Alexandre Torgue @ 2020-08-28 12:47 UTC (permalink / raw)
  To: Marek Vasut, linux-arm-kernel
  Cc: Patrick Delaunay, linux-stm32, Patrice Chotard, Maxime Coquelin,
	Manivannan Sadhasivam

Hi Marek

On 8/22/20 10:36 PM, Marek Vasut wrote:
> Add another mux option for DCMI pins, this is used on AV96 board.
> 
> Upstream-Status: Work-in-progress
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
>   arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 37 ++++++++++++++++++++++++
>   1 file changed, 37 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index 1c4c3d32efae..d6847787c65a 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -118,6 +118,43 @@ pins {
>   		};
>   	};
>   
> +	dcmi_pins_b: dcmi-1 {
> +		pins {
> +			pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
> +				 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
> +				 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
> +				 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
> +				 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
> +				 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
> +				 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
> +				 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
> +				 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
> +				 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
> +				 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
> +				 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
> +				 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
> +			bias-pull-up;
> +		};
> +	};
> +
> +	dcmi_sleep_pins_b: dcmi-sleep-1 {
> +		pins {
> +			pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
> +				 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
> +				 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
> +				 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
> +				 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
> +				 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */
> +				 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
> +				 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
> +				 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
> +				 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
> +				 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
> +				 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
> +				 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
> +		};
> +	};
> +

Defined but not used. Do you have another patch in pipe ?

regards
alex

>   	ethernet0_rgmii_pins_a: rgmii-0 {
>   		pins1 {
>   			pinmux = <STM32_PINMUX('G', 5, AF11)>, /* ETH_RGMII_CLK125 */
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins
  2020-08-28 12:47 ` Alexandre Torgue
@ 2020-08-28 12:52   ` Marek Vasut
  2020-08-28 15:56     ` Alexandre Torgue
  0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2020-08-28 12:52 UTC (permalink / raw)
  To: Alexandre Torgue, linux-arm-kernel
  Cc: Patrick Delaunay, linux-stm32, Patrice Chotard, Maxime Coquelin,
	Manivannan Sadhasivam

On 8/28/20 2:47 PM, Alexandre Torgue wrote:
> Hi Marek

Hi,

[...]

>> +        pins {
>> +            pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
>> +                 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
>> +                 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
>> +                 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
>> +                 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
>> +                 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
>> +                 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
>> +                 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
>> +                 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
>> +                 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
>> +                 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
>> +                 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
>> +                 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
>> +            bias-pull-up;
>> +        };
>> +    };
>> +
>> +    dcmi_sleep_pins_b: dcmi-sleep-1 {
>> +        pins {
>> +            pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
>> +                 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
>> +                 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
>> +                 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
>> +                 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
>> +                 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */
>> +                 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
>> +                 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
>> +                 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
>> +                 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
>> +                 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
>> +                 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
>> +                 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
>> +        };
>> +    };
>> +
> 
> Defined but not used. Do you have another patch in pipe ?

Yeah, for camera on the AV96, but that depends on DCMI media patches to
be usable. Same for the RCC patches.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins
  2020-08-28 12:52   ` Marek Vasut
@ 2020-08-28 15:56     ` Alexandre Torgue
  2020-08-28 16:38       ` Marek Vasut
  0 siblings, 1 reply; 7+ messages in thread
From: Alexandre Torgue @ 2020-08-28 15:56 UTC (permalink / raw)
  To: Marek Vasut, linux-arm-kernel
  Cc: Patrick Delaunay, linux-stm32, Patrice Chotard, Maxime Coquelin,
	Manivannan Sadhasivam

Hi,

On 8/28/20 2:52 PM, Marek Vasut wrote:
> On 8/28/20 2:47 PM, Alexandre Torgue wrote:
>> Hi Marek
> 
> Hi,
> 
> [...]
> 
>>> +        pins {
>>> +            pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
>>> +                 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
>>> +                 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
>>> +                 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
>>> +                 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
>>> +                 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
>>> +                 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
>>> +                 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
>>> +                 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
>>> +                 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
>>> +                 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
>>> +                 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
>>> +                 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
>>> +            bias-pull-up;
>>> +        };
>>> +    };
>>> +
>>> +    dcmi_sleep_pins_b: dcmi-sleep-1 {
>>> +        pins {
>>> +            pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
>>> +                 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
>>> +                 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
>>> +                 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
>>> +                 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
>>> +                 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */
>>> +                 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
>>> +                 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
>>> +                 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
>>> +                 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
>>> +                 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
>>> +                 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
>>> +                 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
>>> +        };
>>> +    };
>>> +
>>
>> Defined but not used. Do you have another patch in pipe ?
> 
> Yeah, for camera on the AV96, but that depends on DCMI media patches to
> be usable. Same for the RCC patches.

Ok so I prefer to wait for other DCMI patches before merging those ones.

Regards
Alex


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins
  2020-08-28 15:56     ` Alexandre Torgue
@ 2020-08-28 16:38       ` Marek Vasut
  0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2020-08-28 16:38 UTC (permalink / raw)
  To: Alexandre Torgue, linux-arm-kernel
  Cc: Patrick Delaunay, linux-stm32, Patrice Chotard, Maxime Coquelin,
	Manivannan Sadhasivam

On 8/28/20 5:56 PM, Alexandre Torgue wrote:
> Hi,

Hi,

> On 8/28/20 2:52 PM, Marek Vasut wrote:
>> On 8/28/20 2:47 PM, Alexandre Torgue wrote:
>>> Hi Marek
>>
>> Hi,
>>
>> [...]
>>
>>>> +        pins {
>>>> +            pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
>>>> +                 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
>>>> +                 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
>>>> +                 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
>>>> +                 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
>>>> +                 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
>>>> +                 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
>>>> +                 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
>>>> +                 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
>>>> +                 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
>>>> +                 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
>>>> +                 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
>>>> +                 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
>>>> +            bias-pull-up;
>>>> +        };
>>>> +    };
>>>> +
>>>> +    dcmi_sleep_pins_b: dcmi-sleep-1 {
>>>> +        pins {
>>>> +            pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
>>>> +                 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
>>>> +                 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
>>>> +                 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
>>>> +                 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
>>>> +                 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */
>>>> +                 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
>>>> +                 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
>>>> +                 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
>>>> +                 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
>>>> +                 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
>>>> +                 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
>>>> +                 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
>>>> +        };
>>>> +    };
>>>> +
>>>
>>> Defined but not used. Do you have another patch in pipe ?
>>
>> Yeah, for camera on the AV96, but that depends on DCMI media patches to
>> be usable. Same for the RCC patches.
> 
> Ok so I prefer to wait for other DCMI patches before merging those ones.

Fine by me.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-08-28 16:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22 20:36 [PATCH] ARM: dts: stm32: Add alternate pinmux for DCMI pins Marek Vasut
2020-08-22 20:57 ` [Linux-stm32] " Ahmad Fatoum
2020-08-22 21:48   ` Marek Vasut
2020-08-28 12:47 ` Alexandre Torgue
2020-08-28 12:52   ` Marek Vasut
2020-08-28 15:56     ` Alexandre Torgue
2020-08-28 16:38       ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.