From: Martin Schiller <ms@dev.tdt.de> To: Arnd Bergmann <arnd@arndb.de> Cc: David Miller <davem@davemloft.net>, khc@pm.waw.pl, gregkh <gregkh@linuxfoundation.org>, driverdevel <devel@driverdev.osuosl.org>, Networking <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>, Andrew Hendry <andrew.hendry@gmail.com>, linux-x25@vger.kernel.org, Kevin Curtis <kevin.curtis@farsite.com>, "R.J.Dunlop" <bob.dunlop@farsite.com>, Qiang Zhao <qiang.zhao@nxp.com> Subject: Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging Date: Tue, 10 Dec 2019 09:59:29 +0100 [thread overview] Message-ID: <407acd92c92c3ba04578da89b1a0f191@dev.tdt.de> (raw) In-Reply-To: <CAK8P3a25UGV1KS1ufZsyQJk1+9Rp9is0x6eOU7pr5Xf6Z3N2gA@mail.gmail.com> On 2019-12-09 20:26, Arnd Bergmann wrote: > On Mon, Dec 9, 2019 at 7:29 PM David Miller <davem@davemloft.net> > wrote: >> >> From: Arnd Bergmann <arnd@arndb.de> >> Date: Mon, 9 Dec 2019 16:12:56 +0100 >> >> > syzbot keeps finding issues in the X.25 implementation that nobody is >> > interested in fixing. Given that all the x25 patches of the past years >> > that are not global cleanups tend to fix user-triggered oopses, is it >> > time to just retire the subsystem? >> >> I have a bug fix that I'm currently applying to 'net' right now >> actually: >> >> https://patchwork.ozlabs.org/patch/1205973/ >> >> So your proposal might be a bit premature. > > Ok, makes sense. Looking back in the history, I also see other bugfixes > from the same author. > > Adding Martin Schiller to Cc: for a few questions: > > - What hardware are you using for X.25? I would say that X.25 is (at least in Germany) not dead yet. For example, it is still used in the railway network of the Deutsche Bahn AG in many different areas. [1] We deliver products for this and use the Linux X.25 stack with some bugfixes and extensions that I would like to get upstream. As hardware/interfaces we use X.21bis/G.703 adapters, which are connected via HDLC_X25 and LAPB. Also for this there are extensions and bugfixes, which I would like to include in the kernel. > - Would you be available to be listed in the MAINTAINERS file > as a contact for net/x25? Yes, you can add me to the MAINTAINERS file. I have only limited time, but I will try to follow all requests concerning this subsystem. > - Does your bug fix address the latest issue found by syzbot[1], > or do you have an idea to fix it if not? I don't have a direct solution for the concrete problem mentioned above, but at first sight I would say that the commit 95d6ebd53c79 ("net/x25: fix use-after-free in x25_device_event()") holds the wrong lock (&x25_list_lock). Shouldn't this be the lock &x25_neigh_list_lock as in x25_get_neigh(), where x25_neigh_hold() is called? > > Arnd > > [1] > https://lore.kernel.org/netdev/CAK8P3a0LdF+aQ1hnZrVKkNBQaum0WqW1jyR7_Eb+JRiwyHWr6Q@mail.gmail.com/
WARNING: multiple messages have this Message-ID (diff)
From: Martin Schiller <ms@dev.tdt.de> To: Arnd Bergmann <arnd@arndb.de> Cc: driverdevel <devel@driverdev.osuosl.org>, linux-x25@vger.kernel.org, gregkh <gregkh@linuxfoundation.org>, "R.J.Dunlop" <bob.dunlop@farsite.com>, linux-kernel@vger.kernel.org, Kevin Curtis <kevin.curtis@farsite.com>, Eric Biggers <ebiggers@kernel.org>, Networking <netdev@vger.kernel.org>, Andrew Hendry <andrew.hendry@gmail.com>, Qiang Zhao <qiang.zhao@nxp.com>, David Miller <davem@davemloft.net>, khc@pm.waw.pl Subject: Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging Date: Tue, 10 Dec 2019 09:59:29 +0100 [thread overview] Message-ID: <407acd92c92c3ba04578da89b1a0f191@dev.tdt.de> (raw) In-Reply-To: <CAK8P3a25UGV1KS1ufZsyQJk1+9Rp9is0x6eOU7pr5Xf6Z3N2gA@mail.gmail.com> On 2019-12-09 20:26, Arnd Bergmann wrote: > On Mon, Dec 9, 2019 at 7:29 PM David Miller <davem@davemloft.net> > wrote: >> >> From: Arnd Bergmann <arnd@arndb.de> >> Date: Mon, 9 Dec 2019 16:12:56 +0100 >> >> > syzbot keeps finding issues in the X.25 implementation that nobody is >> > interested in fixing. Given that all the x25 patches of the past years >> > that are not global cleanups tend to fix user-triggered oopses, is it >> > time to just retire the subsystem? >> >> I have a bug fix that I'm currently applying to 'net' right now >> actually: >> >> https://patchwork.ozlabs.org/patch/1205973/ >> >> So your proposal might be a bit premature. > > Ok, makes sense. Looking back in the history, I also see other bugfixes > from the same author. > > Adding Martin Schiller to Cc: for a few questions: > > - What hardware are you using for X.25? I would say that X.25 is (at least in Germany) not dead yet. For example, it is still used in the railway network of the Deutsche Bahn AG in many different areas. [1] We deliver products for this and use the Linux X.25 stack with some bugfixes and extensions that I would like to get upstream. As hardware/interfaces we use X.21bis/G.703 adapters, which are connected via HDLC_X25 and LAPB. Also for this there are extensions and bugfixes, which I would like to include in the kernel. > - Would you be available to be listed in the MAINTAINERS file > as a contact for net/x25? Yes, you can add me to the MAINTAINERS file. I have only limited time, but I will try to follow all requests concerning this subsystem. > - Does your bug fix address the latest issue found by syzbot[1], > or do you have an idea to fix it if not? I don't have a direct solution for the concrete problem mentioned above, but at first sight I would say that the commit 95d6ebd53c79 ("net/x25: fix use-after-free in x25_device_event()") holds the wrong lock (&x25_list_lock). Shouldn't this be the lock &x25_neigh_list_lock as in x25_get_neigh(), where x25_neigh_hold() is called? > > Arnd > > [1] > https://lore.kernel.org/netdev/CAK8P3a0LdF+aQ1hnZrVKkNBQaum0WqW1jyR7_Eb+JRiwyHWr6Q@mail.gmail.com/ _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-12-10 8:59 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-09 15:12 [PATCH 1/4] [net-next] wan: remove stale Kconfig entries Arnd Bergmann 2019-12-09 15:12 ` Arnd Bergmann 2019-12-09 15:12 ` [PATCH 2/4] [net-next] wan: remove sbni/granch driver Arnd Bergmann 2019-12-09 15:12 ` Arnd Bergmann 2019-12-09 15:12 ` [PATCH 3/4] [net-next] wan: remove old frame relay driver Arnd Bergmann 2019-12-09 15:12 ` Arnd Bergmann 2019-12-09 15:12 ` [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging Arnd Bergmann 2019-12-09 15:12 ` Arnd Bergmann 2019-12-09 15:41 ` Greg Kroah-Hartman 2019-12-09 15:41 ` Greg Kroah-Hartman 2019-12-09 18:29 ` David Miller 2019-12-09 18:29 ` David Miller 2019-12-09 19:26 ` Arnd Bergmann 2019-12-09 19:26 ` Arnd Bergmann 2019-12-10 8:59 ` Martin Schiller [this message] 2019-12-10 8:59 ` Martin Schiller 2019-12-10 13:51 ` Arnd Bergmann 2019-12-10 13:51 ` Arnd Bergmann 2019-12-11 5:58 ` Martin Schiller 2019-12-11 5:58 ` Martin Schiller 2019-12-11 7:10 ` Krzysztof Hałasa 2019-12-11 7:10 ` Krzysztof Hałasa 2019-12-11 7:10 ` Krzysztof Hałasa 2019-12-11 13:34 ` Andrew Lunn 2019-12-11 13:34 ` Andrew Lunn 2019-12-11 13:34 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=407acd92c92c3ba04578da89b1a0f191@dev.tdt.de \ --to=ms@dev.tdt.de \ --cc=andrew.hendry@gmail.com \ --cc=arnd@arndb.de \ --cc=bob.dunlop@farsite.com \ --cc=davem@davemloft.net \ --cc=devel@driverdev.osuosl.org \ --cc=ebiggers@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=kevin.curtis@farsite.com \ --cc=khc@pm.waw.pl \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-x25@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=qiang.zhao@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.