All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH]OMAP HSMMC: Fix a bug in card remove scenario
@ 2010-04-01  0:29 Madhusudhan Chikkature
  0 siblings, 0 replies; only message in thread
From: Madhusudhan Chikkature @ 2010-04-01  0:29 UTC (permalink / raw)
  To: akpm; +Cc: linux-mmc, linux-omap

From: Madhusudhan Chikkature <madhu.cr@ti.com>
Date: Wed, 31 Mar 2010 19:31:24 -0400
Subject: [PATCH] OMAP HSMMC:Fix a bug in card removal scenario

The reset of data lines when the card is removed from the cage results
in a failure.The failure is seen if the card is removed from the cage
when TC is pending after a CMD with data received CC.The reset logic leaves
the controller in a state where niether a TC is received nor DTO.

The rest code can be safely removed here since it is taken care in the IRQ
handler.

Signed-off-by: Madhusudhan Chikkature <madhu.cr@ti.com>
---
 drivers/mmc/host/omap_hsmmc.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 83f0aff..e9caf69 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1179,15 +1179,10 @@ static void omap_hsmmc_detect(struct work_struct *work)
 		carddetect = -ENOSYS;
 	}

-	if (carddetect) {
+	if (carddetect)
 		mmc_detect_change(host->mmc, (HZ * 200) / 1000);
-	} else {
-		mmc_host_enable(host->mmc);
-		omap_hsmmc_reset_controller_fsm(host, SRD);
-		mmc_host_lazy_disable(host->mmc);
-
+	else
 		mmc_detect_change(host->mmc, (HZ * 50) / 1000);
-	}
 }

 /*
-- 
1.6.3.3




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-04-01  0:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-01  0:29 [PATCH]OMAP HSMMC: Fix a bug in card remove scenario Madhusudhan Chikkature

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.