[rdma-core patch v3] srp_daemon: improve the debug message for is_enabled_by_rules_file

[rdma-core patch v3] srp_daemon: improve the debug message for is_enabled_by_rules_file

[Honggang Li]

If the target was disallowed by rule file, user can not distinguish that
from the old debug message.

pr_debug("Found an SRP target with id_ext %s - check if it allowed by rules file\n", target->id_ext);

It implicitly implied by the message next to the old debug message.

pr_debug("Found an SRP target with id_ext %s - check if it is already connected\n", target->id_ext);

The improved debug message will feedback the check result of rule file, user
no longer needs to wonder the target is allowed or not.

Signed-off-by: Honggang Li <honli@redhat.com>
---
 srp_daemon/srp_daemon.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
index a004f6a4..e85b9668 100644
--- a/srp_daemon/srp_daemon.c
+++ b/srp_daemon/srp_daemon.c
@@ -349,10 +349,11 @@ static int is_enabled_by_rules_file(struct target_details *target)
 	int rule;
 	struct config_t *conf = config;
 
-	if (NULL == conf->rules)
+	if (NULL == conf->rules) {
+		pr_debug("Allowing SRP target with id_ext %s because not using a rules file\n", target->id_ext);
 		return 1;
+	}
 
-	pr_debug("Found an SRP target with id_ext %s - check if it allowed by rules file\n", target->id_ext);
 	rule = -1;
 	do {
 		rule++;
@@ -392,6 +393,9 @@ static int is_enabled_by_rules_file(struct target_details *target)
 
 		target->options = conf->rules[rule].options;
 
+		pr_debug("SRP target with id_ext %s %s by rules file\n",
+				target->id_ext,
+				conf->rules[rule].allow ? "allowed" : "disallowed");
 		return conf->rules[rule].allow;
 
 	} while (1);
-- 
2.20.1

Re: [rdma-core patch v3] srp_daemon: improve the debug message for is_enabled_by_rules_file

[Bart Van Assche]

On 7/14/19 9:16 PM, Honggang Li wrote:
> If the target was disallowed by rule file, user can not distinguish that
> from the old debug message.
> 
> pr_debug("Found an SRP target with id_ext %s - check if it allowed by rules file\n", target->id_ext);
> 
> It implicitly implied by the message next to the old debug message.
> 
> pr_debug("Found an SRP target with id_ext %s - check if it is already connected\n", target->id_ext);
> 
> The improved debug message will feedback the check result of rule file, user
> no longer needs to wonder the target is allowed or not.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [rdma-core patch v3] srp_daemon: improve the debug message for is_enabled_by_rules_file

[Jason Gunthorpe]

On Mon, Jul 15, 2019 at 12:16:14AM -0400, Honggang Li wrote:
> If the target was disallowed by rule file, user can not distinguish that
> from the old debug message.
> 
> pr_debug("Found an SRP target with id_ext %s - check if it allowed by rules file\n", target->id_ext);
> 
> It implicitly implied by the message next to the old debug message.
> 
> pr_debug("Found an SRP target with id_ext %s - check if it is already connected\n", target->id_ext);
> 
> The improved debug message will feedback the check result of rule file, user
> no longer needs to wonder the target is allowed or not.
> 
> Signed-off-by: Honggang Li <honli@redhat.com>
>  srp_daemon/srp_daemon.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied to for-next, thanks

Jason