All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Sudeep Holla' <sudeep.holla@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>
Subject: RE: [PATCH] firmware: arm_scmi: Use {get,put}_unaligned_le32 accessors
Date: Wed, 7 Aug 2019 15:18:59 +0000	[thread overview]
Message-ID: <4102ce79ef7a4f5ba819663d072bccc8@AcuMS.aculab.com> (raw)
In-Reply-To: <20190807130038.26878-1-sudeep.holla@arm.com>

From: Sudeep Holla
> Sent: 07 August 2019 14:01
> 
> Instead of type-casting the {tx,rx}.buf all over the place while
> accessing them to read/write __le32 from/to the firmware, let's use
> the nice existing {get,put}_unaligned_le32 accessors to hide all the
> type cast ugliness.

Why the 'unaligned' accessors?

> -	*(__le32 *)t->tx.buf = cpu_to_le32(id);
> +	put_unaligned_le32(id, t->tx.buf);

These will be expensive if the cpu doesn't support them.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Sudeep Holla' <sudeep.holla@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: RE: [PATCH] firmware: arm_scmi: Use {get,put}_unaligned_le32 accessors
Date: Wed, 7 Aug 2019 15:18:59 +0000	[thread overview]
Message-ID: <4102ce79ef7a4f5ba819663d072bccc8@AcuMS.aculab.com> (raw)
In-Reply-To: <20190807130038.26878-1-sudeep.holla@arm.com>

From: Sudeep Holla
> Sent: 07 August 2019 14:01
> 
> Instead of type-casting the {tx,rx}.buf all over the place while
> accessing them to read/write __le32 from/to the firmware, let's use
> the nice existing {get,put}_unaligned_le32 accessors to hide all the
> type cast ugliness.

Why the 'unaligned' accessors?

> -	*(__le32 *)t->tx.buf = cpu_to_le32(id);
> +	put_unaligned_le32(id, t->tx.buf);

These will be expensive if the cpu doesn't support them.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-08-07 15:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 13:00 [PATCH] firmware: arm_scmi: Use {get,put}_unaligned_le32 accessors Sudeep Holla
2019-08-07 13:00 ` Sudeep Holla
2019-08-07 13:36 ` Philipp Zabel
2019-08-07 13:36   ` Philipp Zabel
2019-08-07 13:57   ` Sudeep Holla
2019-08-07 13:57     ` Sudeep Holla
2019-08-07 14:07     ` Robin Murphy
2019-08-07 14:07       ` Robin Murphy
2019-08-07 14:37       ` Sudeep Holla
2019-08-07 14:37         ` Sudeep Holla
2019-08-07 15:18 ` David Laight [this message]
2019-08-07 15:18   ` David Laight
2019-08-07 17:08   ` Sudeep Holla
2019-08-07 17:08     ` Sudeep Holla
2019-08-07 17:37 ` [PATCH v2] firmware: arm_scmi: Use {get,put}_unaligned_le{32,64} accessors Sudeep Holla
2019-08-07 17:37   ` [PATCH v2] firmware: arm_scmi: Use {get, put}_unaligned_le{32, 64} accessors Sudeep Holla
2019-08-08  9:47   ` [PATCH v2] firmware: arm_scmi: Use {get,put}_unaligned_le{32,64} accessors Philipp Zabel
2019-08-08  9:47     ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4102ce79ef7a4f5ba819663d072bccc8@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.