* usb: dwc2: Fix interval type issue
@ 2018-03-14 10:12 Minas Harutyunyan
0 siblings, 0 replies; 3+ messages in thread
From: Minas Harutyunyan @ 2018-03-14 10:12 UTC (permalink / raw)
To: Grigor Tovmasyan, John Youn, Felipe Balbi, Greg Kroah-Hartman, linux-usb
On 2/6/2018 7:07 PM, Grigor Tovmasyan wrote:
> The maximum value that unsigned char can hold is 255, meanwhile
> the maximum value of interval is 2^(bIntervalMax-1)=2^15.
>
> Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
> ---
> drivers/usb/dwc2/core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
> index 0f0c21cf0192..51c3d5170b3b 100644
> --- a/drivers/usb/dwc2/core.h
> +++ b/drivers/usb/dwc2/core.h
> @@ -217,7 +217,7 @@ struct dwc2_hsotg_ep {
> unsigned char dir_in;
> unsigned char index;
> unsigned char mc;
> - unsigned char interval;
> + u16 interval;
>
> unsigned int halted:1;
> unsigned int periodic:1;
>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* usb: dwc2: Fix interval type issue
@ 2018-03-14 13:16 Minas Harutyunyan
0 siblings, 0 replies; 3+ messages in thread
From: Minas Harutyunyan @ 2018-03-14 13:16 UTC (permalink / raw)
To: Minas Harutyunyan, Grigor Tovmasyan, John Youn, Felipe Balbi,
Greg Kroah-Hartman, linux-usb
On 3/14/2018 2:12 PM, Minas Harutyunyan wrote:
> On 2/6/2018 7:07 PM, Grigor Tovmasyan wrote:
>> The maximum value that unsigned char can hold is 255, meanwhile
>> the maximum value of interval is 2^(bIntervalMax-1)=2^15.
>>
>> Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
>> ---
>> drivers/usb/dwc2/core.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
>> index 0f0c21cf0192..51c3d5170b3b 100644
>> --- a/drivers/usb/dwc2/core.h
>> +++ b/drivers/usb/dwc2/core.h
>> @@ -217,7 +217,7 @@ struct dwc2_hsotg_ep {
>> unsigned char dir_in;
>> unsigned char index;
>> unsigned char mc;
>> - unsigned char interval;
>> + u16 interval;
>>
>> unsigned int halted:1;
>> unsigned int periodic:1;
>>
>
> Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> --
Sorry for "Acked-by".
Tested-by: Minas Harutyunyan <hminas@synopsys.com>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* usb: dwc2: Fix interval type issue
@ 2018-02-06 15:07 Grigor Tovmasyan
0 siblings, 0 replies; 3+ messages in thread
From: Grigor Tovmasyan @ 2018-02-06 15:07 UTC (permalink / raw)
To: John Youn, Felipe Balbi, Greg Kroah-Hartman, linux-usb; +Cc: Grigor Tovmasyan
The maximum value that unsigned char can hold is 255, meanwhile
the maximum value of interval is 2^(bIntervalMax-1)=2^15.
Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
---
drivers/usb/dwc2/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index 0f0c21cf0192..51c3d5170b3b 100644
--- a/drivers/usb/dwc2/core.h
+++ b/drivers/usb/dwc2/core.h
@@ -217,7 +217,7 @@ struct dwc2_hsotg_ep {
unsigned char dir_in;
unsigned char index;
unsigned char mc;
- unsigned char interval;
+ u16 interval;
unsigned int halted:1;
unsigned int periodic:1;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-14 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-14 10:12 usb: dwc2: Fix interval type issue Minas Harutyunyan
-- strict thread matches above, loose matches on Subject: below --
2018-03-14 13:16 Minas Harutyunyan
2018-02-06 15:07 Grigor Tovmasyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.