* usb: dwc2: debugfs: Don't touch RX FIFO during register dump
@ 2018-05-05 9:32 Minas Harutyunyan
0 siblings, 0 replies; 2+ messages in thread
From: Minas Harutyunyan @ 2018-05-05 9:32 UTC (permalink / raw)
To: Stefan Wahren, Minas Harutyunyan, Grigor Tovmasyan
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, Mian Yousaf Kaukab
On 5/4/2018 10:09 PM, Stefan Wahren wrote:
> Dumping the registers via debugfs makes USB on Raspberry Pi completely
> unusable. The read of register GRXSTSP ("Receive Status Read and Pop
> Register") is responsible for this behaviour, because it pops the RX FIFO.
> So avoid this by omitting the relevant register.
>
> CC: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>
> Fixes: 563cf017c443 ("usb: dwc2: debugfs: add support for complete register dump")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> drivers/usb/dwc2/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c
> index 58c691f..d4c0589 100644
> --- a/drivers/usb/dwc2/debugfs.c
> +++ b/drivers/usb/dwc2/debugfs.c
> @@ -368,7 +368,7 @@ static const struct debugfs_reg32 dwc2_regs[] = {
> dump_register(GINTSTS),
> dump_register(GINTMSK),
> dump_register(GRXSTSR),
> - dump_register(GRXSTSP),
> + /* Omit GRXSTSP */
> dump_register(GRXFSIZ),
> dump_register(GNPTXFSIZ),
> dump_register(GNPTXSTS),
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* usb: dwc2: debugfs: Don't touch RX FIFO during register dump
@ 2018-05-04 18:09 Stefan Wahren
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Wahren @ 2018-05-04 18:09 UTC (permalink / raw)
To: Minas Harutyunyan, Grigor Tovmasyan
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, Stefan Wahren,
Mian Yousaf Kaukab
Dumping the registers via debugfs makes USB on Raspberry Pi completely
unusable. The read of register GRXSTSP ("Receive Status Read and Pop
Register") is responsible for this behaviour, because it pops the RX FIFO.
So avoid this by omitting the relevant register.
CC: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>
Fixes: 563cf017c443 ("usb: dwc2: debugfs: add support for complete register dump")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/usb/dwc2/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c
index 58c691f..d4c0589 100644
--- a/drivers/usb/dwc2/debugfs.c
+++ b/drivers/usb/dwc2/debugfs.c
@@ -368,7 +368,7 @@ static const struct debugfs_reg32 dwc2_regs[] = {
dump_register(GINTSTS),
dump_register(GINTMSK),
dump_register(GRXSTSR),
- dump_register(GRXSTSP),
+ /* Omit GRXSTSP */
dump_register(GRXFSIZ),
dump_register(GNPTXFSIZ),
dump_register(GNPTXSTS),
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-05 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-05 9:32 usb: dwc2: debugfs: Don't touch RX FIFO during register dump Minas Harutyunyan
-- strict thread matches above, loose matches on Subject: below --
2018-05-04 18:09 Stefan Wahren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.