All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minas Harutyunyan <minas.harutyunyan@synopsys.com>
To: Josh Abraham <j.abraham1776@gmail.com>,
	"minas.harutyunyan@synopsys.com" <minas.harutyunyan@synopsys.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: remove set but unused variable
Date: Mon, 24 Sep 2018 05:48:33 +0000	[thread overview]
Message-ID: <410670D7E743164D87FA6160E7907A56013A76F5B9@am04wembxa.internal.synopsys.com> (raw)
In-Reply-To: 20180924014135.GA27711@josh-ThinkPad-T460s

On 9/24/2018 5:41 AM, Josh Abraham wrote:
> This patch removes a set but unused variable in hcd.c.
> 
> Fixes gcc warning:
> variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> ---
>   drivers/usb/dwc2/hcd.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2bd6e6bfc241..5f23b933cafc 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
>   	u32 remaining_count;
>   	u32 byte_count;
>   	u32 dword_count;
> -	u32 __iomem *data_fifo;
>   	u32 *data_buf = (u32 *)chan->xfer_buf;
>   
>   	if (dbg_hc(chan))
>   		dev_vdbg(hsotg->dev, "%s()\n", __func__);
>   
> -	data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
> -
>   	remaining_count = chan->xfer_len - chan->xfer_count;
>   	if (remaining_count > chan->max_packet)
>   		byte_count = chan->max_packet;
> 
Acked-by: Minas Harutyunyan <hminas@synopsys.com>


WARNING: multiple messages have this Message-ID (diff)
From: Minas Harutyunyan <minas.harutyunyan@synopsys.com>
To: Josh Abraham <j.abraham1776@gmail.com>,
	"minas.harutyunyan@synopsys.com" <minas.harutyunyan@synopsys.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: remove set but unused variable
Date: Mon, 24 Sep 2018 05:48:33 +0000	[thread overview]
Message-ID: <410670D7E743164D87FA6160E7907A56013A76F5B9@am04wembxa.internal.synopsys.com> (raw)
In-Reply-To: <20180912181610.GA31006@josh-ThinkPad-T460s>

On 9/24/2018 5:41 AM, Josh Abraham wrote:
> This patch removes a set but unused variable in hcd.c.
> 
> Fixes gcc warning:
> variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> ---
>   drivers/usb/dwc2/hcd.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2bd6e6bfc241..5f23b933cafc 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
>   	u32 remaining_count;
>   	u32 byte_count;
>   	u32 dword_count;
> -	u32 __iomem *data_fifo;
>   	u32 *data_buf = (u32 *)chan->xfer_buf;
>   
>   	if (dbg_hc(chan))
>   		dev_vdbg(hsotg->dev, "%s()\n", __func__);
>   
> -	data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
> -
>   	remaining_count = chan->xfer_len - chan->xfer_count;
>   	if (remaining_count > chan->max_packet)
>   		byte_count = chan->max_packet;
> 
Acked-by: Minas Harutyunyan <hminas@synopsys.com>

WARNING: multiple messages have this Message-ID (diff)
From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: Josh Abraham <j.abraham1776@gmail.com>,
	"minas.harutyunyan@synopsys.com" <minas.harutyunyan@synopsys.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: usb: dwc2: remove set but unused variable
Date: Mon, 24 Sep 2018 05:48:33 +0000	[thread overview]
Message-ID: <410670D7E743164D87FA6160E7907A56013A76F5B9@am04wembxa.internal.synopsys.com> (raw)

On 9/24/2018 5:41 AM, Josh Abraham wrote:
> This patch removes a set but unused variable in hcd.c.
> 
> Fixes gcc warning:
> variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> ---
>   drivers/usb/dwc2/hcd.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2bd6e6bfc241..5f23b933cafc 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
>   	u32 remaining_count;
>   	u32 byte_count;
>   	u32 dword_count;
> -	u32 __iomem *data_fifo;
>   	u32 *data_buf = (u32 *)chan->xfer_buf;
>   
>   	if (dbg_hc(chan))
>   		dev_vdbg(hsotg->dev, "%s()\n", __func__);
>   
> -	data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
> -
>   	remaining_count = chan->xfer_len - chan->xfer_count;
>   	if (remaining_count > chan->max_packet)
>   		byte_count = chan->max_packet;
> 
Acked-by: Minas Harutyunyan <hminas@synopsys.com>

  reply	other threads:[~2018-09-24  5:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24  1:41 [PATCH] usb: dwc2: remove set but unused variable Josh Abraham
2018-09-24  1:41 ` Joshua Abraham
2018-09-24  1:41 ` [PATCH] " Josh Abraham
2018-09-24  5:48 ` Minas Harutyunyan [this message]
2018-09-24  5:48   ` Minas Harutyunyan
2018-09-24  5:48   ` [PATCH] " Minas Harutyunyan
  -- strict thread matches above, loose matches on Subject: below --
2018-09-12 18:16 Josh Abraham
2018-09-12 18:16 ` Joshua Abraham
2018-09-12 18:16 ` [PATCH] " Josh Abraham
2018-09-13  6:36 ` Minas Harutyunyan
2018-09-13  6:36   ` Minas Harutyunyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=410670D7E743164D87FA6160E7907A56013A76F5B9@am04wembxa.internal.synopsys.com \
    --to=minas.harutyunyan@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=j.abraham1776@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.