* [PATCH] Remove wildcard on KBUILD_OUTPUT
[not found] ` <51248.194.237.142.13.1092343524.squirrel@194.237.142.13>
@ 2004-08-12 21:28 ` Coywolf Qi Hunt
2004-08-15 19:14 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Coywolf Qi Hunt @ 2004-08-12 21:28 UTC (permalink / raw)
To: sam; +Cc: kai, akpm, linux-kernel
sam@ravnborg.org wrote:
>>You misunderstood me.
>>This patch removes unnecessary wildcard on KBUILD_OUTPUT and unused VPATH.
>>If it looks ok, I'd like to send it to lkml and akpm.
>>
>>
>
>Try building a kernel where you use O= to specify another output directory.
>Try with an existing and a non-existing directory.
>
>You will see why both are needed.
>
>
>
I searched VPATH in the manual. I was wrong on removing VPATH.
But I still think wildcard is unnecessary.
I did build kernel with another output directory, both existing and
non-existing before mailling you.
And even when KBUILD_OUTPUT contains wildcard. Ok, I just saw Kai's
reply. I Needn't further explain.
Kai Germaschewski wrote:
>>Try building a kernel where you use O= to specify another output directory.
>>Try with an existing and a non-existing directory.
>>
>>
>
>I suspect that the patch works, if $(shell ...) returns what's written to
>stdout, KBUILD_OUTPUT would be empty and thus the wildcard unnecessary. Of
>course I'm too lazy to test it out, too...
>
>--Kai
>
>
>
>
Signed-off-by: Coywolf Qi Hunt <coywolf@greatcn.org>
--- linux-2.6.8-rc4-mm1/Makefile 2004-08-12 13:59:10.000000000 -0500
+++ linux-2.6.8-rc4-mm1-cy/Makefile 2004-08-12 16:09:08.171039406 -0500
@@ -102,7 +102,7 @@ ifneq ($(KBUILD_OUTPUT),)
# check that the output directory actually exists
saved-output := $(KBUILD_OUTPUT)
KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd)
-$(if $(wildcard $(KBUILD_OUTPUT)),, \
+$(if $(KBUILD_OUTPUT),, \
$(error output directory "$(saved-output)" does not exist))
.PHONY: $(MAKECMDGOALS)
--
Coywolf Qi Hunt
Homepage http://greatcn.org/~coywolf/
Admin of http://GreatCN.org and http://LoveCN.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove wildcard on KBUILD_OUTPUT
2004-08-12 21:28 ` [PATCH] Remove wildcard on KBUILD_OUTPUT Coywolf Qi Hunt
@ 2004-08-15 19:14 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2004-08-15 19:14 UTC (permalink / raw)
To: Coywolf Qi Hunt; +Cc: sam, kai, akpm, linux-kernel
On Fri, Aug 13, 2004 at 05:28:37AM +0800, Coywolf Qi Hunt wrote:
> sam@ravnborg.org wrote:
>
> >>You misunderstood me.
> >>This patch removes unnecessary wildcard on KBUILD_OUTPUT
Applied, thanks.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-15 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <411B31A5.70508@greatcn.org>
[not found] ` <20040812172307.GA7365@mars.ravnborg.org>
[not found] ` <411BCE4F.1060002@greatcn.org>
[not found] ` <51248.194.237.142.13.1092343524.squirrel@194.237.142.13>
2004-08-12 21:28 ` [PATCH] Remove wildcard on KBUILD_OUTPUT Coywolf Qi Hunt
2004-08-15 19:14 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.