[swift][ironic][ceph][radosgw] radosgw "support" in python-swiftclient droped for ocata and above

[swift][ironic][ceph][radosgw] radosgw "support" in python-swiftclient droped for ocata and above

[Matthew Thode]

[-- Attachment #1.1: Type: text/plain, Size: 1314 bytes --]

python-swiftclient prior to 3.2.0 seemed to incidentally support radosgw
tempurls.  That is, there was no official support, but it still worked.

In 3.2.0 (specifically the linked commit(s)) tempurls were validated to
require /v1/account/container/object, which does not work with radosgw
as it expects /v1/container/object.  This means that radosgw tempurls
fail to work, which further means that radosgw will stop working for
things like ironic.

I can see the point that swiftclient should not care about ceph not
fully implementing the swift spec and not supporting the radosgw url
syntax, but it seems like a step back.  If this is not fixed then things
like ironic will not work with radosgw for Ocata and above (as that's
when this change was made).  We'd need to wait for either ceph to fix
this and support the account part of the url (probably just dropping it)
or have people fork python-swiftclient to 'fix' it.

I'm not sure what the right answer is...

https://github.com/openstack/python-swiftclient/commit/4c955751d340a8f71a2eebdb3c58d90b36874a66
https://github.com/openstack/ironic/blob/214b694f05d200ac1e2ce6db631546f2831c01f7/ironic/common/glance_service/v2/image_service.py#L152-L185

https://bugs.launchpad.net/ironic/+bug/1747384

-- 
Matthew Thode (prometheanfire)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 277 bytes --]

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [swift][ironic][ceph][radosgw] radosgw "support" in python-swiftclient droped for ocata and above

[Casey Bodley]

[-- Attachment #1.1: Type: text/plain, Size: 1870 bytes --]


On 05/09/2018 11:22 AM, Matthew Thode wrote:
> python-swiftclient prior to 3.2.0 seemed to incidentally support radosgw
> tempurls.  That is, there was no official support, but it still worked.
>
> In 3.2.0 (specifically the linked commit(s)) tempurls were validated to
> require /v1/account/container/object, which does not work with radosgw
> as it expects /v1/container/object.  This means that radosgw tempurls
> fail to work, which further means that radosgw will stop working for
> things like ironic.
>
> I can see the point that swiftclient should not care about ceph not
> fully implementing the swift spec and not supporting the radosgw url
> syntax, but it seems like a step back.  If this is not fixed then things
> like ironic will not work with radosgw for Ocata and above (as that's
> when this change was made).  We'd need to wait for either ceph to fix
> this and support the account part of the url (probably just dropping it)
> or have people fork python-swiftclient to 'fix' it.
>
> I'm not sure what the right answer is...
>
> https://github.com/openstack/python-swiftclient/commit/4c955751d340a8f71a2eebdb3c58d90b36874a66
> https://github.com/openstack/ironic/blob/214b694f05d200ac1e2ce6db631546f2831c01f7/ironic/common/glance_service/v2/image_service.py#L152-L185
>
> https://bugs.launchpad.net/ironic/+bug/1747384
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request-ZwoEplunGu0gQVYkTtqAhEB+6BGkLq7r@public.gmane.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Thanks for raising the issue. Radosgw does have a config option 
'rgw_swift_account_in_url' to expect this url format, though it defaults 
to false and I'm not 100% sure that it applies correctly to tempurls.

[-- Attachment #1.2: Type: text/html, Size: 3001 bytes --]

[-- Attachment #2: Type: text/plain, Size: 277 bytes --]

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [swift][ironic][ceph][radosgw] radosgw "support" in python-swiftclient droped for ocata and above

[Casey Bodley]

On 05/09/2018 11:40 AM, Casey Bodley wrote:
>
> On 05/09/2018 11:22 AM, Matthew Thode wrote:
>> python-swiftclient prior to 3.2.0 seemed to incidentally support radosgw
>> tempurls.  That is, there was no official support, but it still worked.
>>
>> In 3.2.0 (specifically the linked commit(s)) tempurls were validated to
>> require /v1/account/container/object, which does not work with radosgw
>> as it expects /v1/container/object.  This means that radosgw tempurls
>> fail to work, which further means that radosgw will stop working for
>> things like ironic.
>>
>> I can see the point that swiftclient should not care about ceph not
>> fully implementing the swift spec and not supporting the radosgw url
>> syntax, but it seems like a step back.  If this is not fixed then things
>> like ironic will not work with radosgw for Ocata and above (as that's
>> when this change was made).  We'd need to wait for either ceph to fix
>> this and support the account part of the url (probably just dropping it)
>> or have people fork python-swiftclient to 'fix' it.
>>
>> I'm not sure what the right answer is...
>>
>> https://github.com/openstack/python-swiftclient/commit/4c955751d340a8f71a2eebdb3c58d90b36874a66
>> https://github.com/openstack/ironic/blob/214b694f05d200ac1e2ce6db631546f2831c01f7/ironic/common/glance_service/v2/image_service.py#L152-L185
>>
>> https://bugs.launchpad.net/ironic/+bug/1747384
>>
>>
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> Thanks for raising the issue. Radosgw does have a config option 
> 'rgw_swift_account_in_url' to expect this url format, though it 
> defaults to false and I'm not 100% sure that it applies correctly to 
> tempurls.

Marcus Watts confirmed that this does work with tempurl.

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [swift][ironic][ceph][radosgw] radosgw "support" in python-swiftclient droped for ocata and above

[Julia Kreger]

On Wed, May 9, 2018 at 5:10 PM, Casey Bodley <cbodley@redhat.com> wrote:
>
> On 05/09/2018 11:40 AM, Casey Bodley wrote:
>>
>>
>> On 05/09/2018 11:22 AM, Matthew Thode wrote:
>>>
>>> python-swiftclient prior to 3.2.0 seemed to incidentally support radosgw
>>> tempurls.  That is, there was no official support, but it still worked.
>>>
>>> In 3.2.0 (specifically the linked commit(s)) tempurls were validated to
>>> require /v1/account/container/object, which does not work with radosgw
>>> as it expects /v1/container/object.  This means that radosgw tempurls
>>> fail to work, which further means that radosgw will stop working for
>>> things like ironic.

What is the value in the validation of the URL path as such? It seems
like the client shouldn't really care as to the precise format of the
end user supplied URL as long as the server returns the expected
response.

>>> I can see the point that swiftclient should not care about ceph not
>>> fully implementing the swift spec and not supporting the radosgw url
>>> syntax, but it seems like a step back.  If this is not fixed then things
>>> like ironic will not work with radosgw for Ocata and above (as that's
>>> when this change was made).  We'd need to wait for either ceph to fix
>>> this and support the account part of the url (probably just dropping it)
>>> or have people fork python-swiftclient to 'fix' it.
>>>
>>> I'm not sure what the right answer is...

I'm personally -1 to pinning swiftclient as that will introduce
headaches if someone tries to install ironic along side anything that
expects a newer client or vise-versa.

I agree it seems like a step back, to which I'm curious about the
value of having the check. The forth option is for ironic to abruptly
drop all related code and support for radosgw temp urls, but that too
would be a setback and negative for OpenStack in general.

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev