* [PATCH] scsi_wait_scan: no option appears when configuring for scsi_wait_scan.
@ 2009-06-17 2:07 Changli Gao
2009-06-17 2:12 ` Matthew Wilcox
0 siblings, 1 reply; 11+ messages in thread
From: Changli Gao @ 2009-06-17 2:07 UTC (permalink / raw)
To: James.Bottomley; +Cc: Linux Kernel Mailing List, linux-scsi, xiaosuo
FIXBUG: missing comment after tristate leads to no option for
scsci_wait_scan when configuring.
When build kernel, this module is always built if I choose SCSI, and I
can't find any option in the configuration menu, so I can't disable it
or build it into kernel statically. After diving into the kernel source
code, I found no comment after keyword tristate, then I added the
comment and help.
Signed-off-by: Changli Gao <xiaosuo@gmail.com <mailto:xiaosuo@gmail.com>>
----
Kconfig | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--- drivers/scsi/Kconfig.orig 2009-06-17 09:52:46.000000000 +0800
+++ drivers/scsi/Kconfig 2009-06-17 09:55:57.000000000 +0800
@@ -259,10 +259,15 @@
or async on the kernel's command line.
config SCSI_WAIT_SCAN
- tristate
+ tristate "Wait until all the async scans are complete"
default m
depends on SCSI
depends on MODULES
+ help
+ Wait until all the async scans are complete. The idea is to use it in
+ initrd/initramfs scripts. You modprobe it after all the modprobes of
+ the root SCSI drivers and it will wait until they have all finished
+ scanning their busses before allowing the boot to proceed
menu "SCSI Transports"
depends on SCSI
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] scsi_wait_scan: no option appears when configuring for scsi_wait_scan.
2009-06-17 2:07 [PATCH] scsi_wait_scan: no option appears when configuring for scsi_wait_scan Changli Gao
@ 2009-06-17 2:12 ` Matthew Wilcox
2009-06-17 10:07 ` [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable Stefan Richter
0 siblings, 1 reply; 11+ messages in thread
From: Matthew Wilcox @ 2009-06-17 2:12 UTC (permalink / raw)
To: Changli Gao; +Cc: James.Bottomley, Linux Kernel Mailing List, linux-scsi
On Wed, Jun 17, 2009 at 10:07:32AM +0800, Changli Gao wrote:
> FIXBUG: missing comment after tristate leads to no option for
> scsci_wait_scan when configuring.
Please search the archives. Patches along these lines have been rejected
before.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-17 2:12 ` Matthew Wilcox
@ 2009-06-17 10:07 ` Stefan Richter
2009-06-17 10:28 ` Stefan Richter
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Stefan Richter @ 2009-06-17 10:07 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Changli Gao, James.Bottomley, Linux Kernel Mailing List, linux-scsi
People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
item. These patches aren't accepted upstream, so let's stop the ongoing
irritation of people due to this obscure and strange installed module
and its Kconfig option.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/scsi/Kconfig | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
Index: b/drivers/scsi/Kconfig
===================================================================
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -259,10 +259,25 @@ config SCSI_SCAN_ASYNC
or async on the kernel's command line.
config SCSI_WAIT_SCAN
- tristate
+ tristate # No prompt here, this is a hidden option.
default m
depends on SCSI
depends on MODULES
+ help
+ Wait until all the async scans are complete. The idea is to use
+ it in initrd/ initramfs scripts. You modprobe it after all the
+ modprobes of the root SCSI drivers and it will wait until they
+ have all finished scanning their buses before allowing the boot
+ to proceed.
+
+ Of course this does not work if targets boot independently of and
+ in parallel with the initiator, and/ or with transports with non-
+ deterministic target discovery schemes, and/ or if a transport
+ driver does not support scsi_wait_scan.
+
+ Still, this option is not exposed as a prompt because little is
+ to be gained by disabling it, whereas people who accidentally
+ switch it off may wonder why their mkinitrd gets into trouble.
menu "SCSI Transports"
depends on SCSI
--
Stefan Richter
-=====-==--= -==- =---=
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-17 10:07 ` [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable Stefan Richter
@ 2009-06-17 10:28 ` Stefan Richter
2009-06-18 0:57 ` Changli Gao
2009-06-18 15:21 ` James Bottomley
2 siblings, 0 replies; 11+ messages in thread
From: Stefan Richter @ 2009-06-17 10:28 UTC (permalink / raw)
To: linux-scsi
Cc: Matthew Wilcox, Changli Gao, James.Bottomley, Linux Kernel Mailing List
Stefan Richter wrote:
> People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
> item. These patches aren't accepted upstream, so let's stop the ongoing
> irritation of people due to this obscure and strange installed module
> and its Kconfig option.
PS, references:
http://bugzilla.kernel.org/show_bug.cgi?id=8763
http://bugzilla.kernel.org/show_bug.cgi?id=8872
http://bugzilla.kernel.org/show_bug.cgi?id=9769
and more mailinglist references than you can shake a stick at, yet
nobody is aware of.
--
Stefan Richter
-=====-==--= -==- =---=
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-17 10:07 ` [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable Stefan Richter
2009-06-17 10:28 ` Stefan Richter
@ 2009-06-18 0:57 ` Changli Gao
2009-06-18 15:21 ` James Bottomley
2 siblings, 0 replies; 11+ messages in thread
From: Changli Gao @ 2009-06-18 0:57 UTC (permalink / raw)
To: Stefan Richter
Cc: Matthew Wilcox, James.Bottomley, Linux Kernel Mailing List, linux-scsi
On Wed, Jun 17, 2009 at 6:07 PM, Stefan
Richter<stefanr@s5r6.in-berlin.de> wrote:
> People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
> item. These patches aren't accepted upstream, so let's stop the ongoing
> irritation of people due to this obscure and strange installed module
> and its Kconfig option.
Aha, I really like this, and think it works. :)
--
Regards,
Changli Gao(xiaosuo@gmail.com)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-17 10:07 ` [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable Stefan Richter
2009-06-17 10:28 ` Stefan Richter
2009-06-18 0:57 ` Changli Gao
@ 2009-06-18 15:21 ` James Bottomley
2009-06-18 16:59 ` Sam Ravnborg
2 siblings, 1 reply; 11+ messages in thread
From: James Bottomley @ 2009-06-18 15:21 UTC (permalink / raw)
To: Stefan Richter
Cc: Matthew Wilcox, Changli Gao, Linux Kernel Mailing List, linux-scsi
On Wed, 2009-06-17 at 12:07 +0200, Stefan Richter wrote:
> People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
> item. These patches aren't accepted upstream, so let's stop the ongoing
> irritation of people due to this obscure and strange installed module
> and its Kconfig option.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
> drivers/scsi/Kconfig | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> Index: b/drivers/scsi/Kconfig
> ===================================================================
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -259,10 +259,25 @@ config SCSI_SCAN_ASYNC
> or async on the kernel's command line.
>
> config SCSI_WAIT_SCAN
> - tristate
> + tristate # No prompt here, this is a hidden option.
Adding comments explaining this is good, I think.
> default m
> depends on SCSI
> depends on MODULES
> + help
> + Wait until all the async scans are complete. The idea is to use
> + it in initrd/ initramfs scripts. You modprobe it after all the
> + modprobes of the root SCSI drivers and it will wait until they
> + have all finished scanning their buses before allowing the boot
> + to proceed.
> +
> + Of course this does not work if targets boot independently of and
> + in parallel with the initiator, and/ or with transports with non-
> + deterministic target discovery schemes, and/ or if a transport
> + driver does not support scsi_wait_scan.
> +
> + Still, this option is not exposed as a prompt because little is
> + to be gained by disabling it, whereas people who accidentally
> + switch it off may wonder why their mkinitrd gets into trouble.
But not a help text that can never be shown. Turn this into a comment
and I'll apply the patch.
The reason is the fact that this could be construed as a detectable bug
(option with help that can never be displayed) and someone with too much
time on their hands someday might make a static checker for it.
James
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-18 15:21 ` James Bottomley
@ 2009-06-18 16:59 ` Sam Ravnborg
2009-06-18 19:03 ` [PATCH update 1] " Stefan Richter
2009-06-18 19:03 ` [PATCH update 2] " Stefan Richter
0 siblings, 2 replies; 11+ messages in thread
From: Sam Ravnborg @ 2009-06-18 16:59 UTC (permalink / raw)
To: James Bottomley
Cc: Stefan Richter, Matthew Wilcox, Changli Gao,
Linux Kernel Mailing List, linux-scsi
On Thu, Jun 18, 2009 at 03:21:26PM +0000, James Bottomley wrote:
> On Wed, 2009-06-17 at 12:07 +0200, Stefan Richter wrote:
> > People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
> > item. These patches aren't accepted upstream, so let's stop the ongoing
> > irritation of people due to this obscure and strange installed module
> > and its Kconfig option.
> >
> > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> > ---
> > drivers/scsi/Kconfig | 17 ++++++++++++++++-
> > 1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > Index: b/drivers/scsi/Kconfig
> > ===================================================================
> > --- a/drivers/scsi/Kconfig
> > +++ b/drivers/scsi/Kconfig
> > @@ -259,10 +259,25 @@ config SCSI_SCAN_ASYNC
> > or async on the kernel's command line.
> >
> > config SCSI_WAIT_SCAN
> > - tristate
> > + tristate # No prompt here, this is a hidden option.
>
> Adding comments explaining this is good, I think.
>
> > default m
> > depends on SCSI
> > depends on MODULES
> > + help
> > + Wait until all the async scans are complete. The idea is to use
> > + it in initrd/ initramfs scripts. You modprobe it after all the
> > + modprobes of the root SCSI drivers and it will wait until they
> > + have all finished scanning their buses before allowing the boot
> > + to proceed.
> > +
> > + Of course this does not work if targets boot independently of and
> > + in parallel with the initiator, and/ or with transports with non-
> > + deterministic target discovery schemes, and/ or if a transport
> > + driver does not support scsi_wait_scan.
> > +
> > + Still, this option is not exposed as a prompt because little is
> > + to be gained by disabling it, whereas people who accidentally
> > + switch it off may wonder why their mkinitrd gets into trouble.
>
> But not a help text that can never be shown. Turn this into a comment
> and I'll apply the patch.
>
> The reason is the fact that this could be construed as a detectable bug
> (option with help that can never be displayed) and someone with too much
> time on their hands someday might make a static checker for it.
In another thread we discussed that the help text should be visible when
searching for an invisible symbol.
There are arguments both ways.
Personally I like the help syntax that we one day can benefit from
and would not accept a warning for help text on symbols with no prompt.
Sam
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH update 1] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-18 16:59 ` Sam Ravnborg
@ 2009-06-18 19:03 ` Stefan Richter
2009-06-18 19:03 ` [PATCH update 2] " Stefan Richter
1 sibling, 0 replies; 11+ messages in thread
From: Stefan Richter @ 2009-06-18 19:03 UTC (permalink / raw)
To: James Bottomley
Cc: Sam Ravnborg, Matthew Wilcox, Changli Gao, linux-kernel, linux-scsi
People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
item. These patches aren't accepted upstream, so let's stop the ongoing
irritation of people due to the unconditionally installed module and its
Kconfig symbol.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
update 1: more precise wording
drivers/scsi/Kconfig | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
Index: b/drivers/scsi/Kconfig
===================================================================
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -259,10 +259,23 @@ config SCSI_SCAN_ASYNC
or async on the kernel's command line.
config SCSI_WAIT_SCAN
- tristate
+ tristate # No prompt here, this is an invisible symbol.
default m
depends on SCSI
depends on MODULES
+ help
+ Wait until all the async scans are complete. The idea is to use
+ it in initrd/ initramfs scripts. You modprobe it after all the
+ modprobes of the root SCSI drivers and it will wait until they
+ have all finished scanning their buses before allowing the boot
+ to proceed. (This method is not applicable if targets boot
+ independently in parallel with the initiator, or with transports
+ with non-deterministic target discovery schemes, or if a transport
+ driver does not support scsi_wait_scan.)
+
+ This symbol is not exposed as a prompt because little is to be
+ gained by disabling it, whereas people who accidentally switch it
+ off may wonder why their mkinitrd gets into trouble.
menu "SCSI Transports"
depends on SCSI
--
Stefan Richter
-=====-==--= -==- =--=-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH update 2] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-18 16:59 ` Sam Ravnborg
2009-06-18 19:03 ` [PATCH update 1] " Stefan Richter
@ 2009-06-18 19:03 ` Stefan Richter
2009-06-22 8:57 ` Alan Cox
1 sibling, 1 reply; 11+ messages in thread
From: Stefan Richter @ 2009-06-18 19:03 UTC (permalink / raw)
To: James Bottomley
Cc: Sam Ravnborg, Matthew Wilcox, Changli Gao, linux-kernel, linux-scsi
People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
item. These patches aren't accepted upstream, so let's stop the ongoing
irritation of people due to the unconditionally installed module and its
Kconfig symbol.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
update 1: more precise wording
update 2: same as comment instead of help (pick what you like better)
drivers/scsi/Kconfig | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
Index: b/drivers/scsi/Kconfig
===================================================================
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -259,10 +259,21 @@ config SCSI_SCAN_ASYNC
or async on the kernel's command line.
config SCSI_WAIT_SCAN
- tristate
+ tristate # No prompt here, this is an invisible symbol.
default m
depends on SCSI
depends on MODULES
+# scsi_wait_scan is a loadable module which waits until all the async scans are
+# complete. The idea is to use it in initrd/ initramfs scripts. You modprobe
+# it after all the modprobes of the root SCSI drivers and it will wait until
+# they have all finished scanning their buses before allowing the boot to
+# proceed. (This method is not applicable if targets boot independently in
+# parallel with the initiator, or with transports with non-deterministic target
+# discovery schemes, or if a transport driver does not support scsi_wait_scan.)
+#
+# This symbol is not exposed as a prompt because little is to be gained by
+# disabling it, whereas people who accidentally switch it off may wonder why
+# their mkinitrd gets into trouble.
menu "SCSI Transports"
depends on SCSI
--
Stefan Richter
-=====-==--= -==- =--=-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH update 2] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-18 19:03 ` [PATCH update 2] " Stefan Richter
@ 2009-06-22 8:57 ` Alan Cox
2009-06-22 11:02 ` Matthew Wilcox
0 siblings, 1 reply; 11+ messages in thread
From: Alan Cox @ 2009-06-22 8:57 UTC (permalink / raw)
To: Stefan Richter
Cc: James Bottomley, Sam Ravnborg, Matthew Wilcox, Changli Gao,
linux-kernel, linux-scsi
On Thu, 18 Jun 2009 21:03:23 +0200 (CEST)
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
> item. These patches aren't accepted upstream, so let's stop the ongoing
> irritation of people due to the unconditionally installed module and its
> Kconfig symbol.
How about the other possibility. People keepmaking it tunable because it
makes sense for it to be tunable. Far better IMHO to make it tunable "if
EMBEDDED"
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH update 2] SCSI: explain the hidden scsi_wait_scan Kconfig variable
2009-06-22 8:57 ` Alan Cox
@ 2009-06-22 11:02 ` Matthew Wilcox
0 siblings, 0 replies; 11+ messages in thread
From: Matthew Wilcox @ 2009-06-22 11:02 UTC (permalink / raw)
To: Alan Cox
Cc: Stefan Richter, James Bottomley, Sam Ravnborg, Changli Gao,
linux-kernel, linux-scsi
On Mon, Jun 22, 2009 at 09:57:01AM +0100, Alan Cox wrote:
> On Thu, 18 Jun 2009 21:03:23 +0200 (CEST)
> Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>
> > People keep sending patches to expose CONFIG_SCSI_WAIT_SCAN as a tunable
> > item. These patches aren't accepted upstream, so let's stop the ongoing
> > irritation of people due to the unconditionally installed module and its
> > Kconfig symbol.
>
> How about the other possibility. People keepmaking it tunable because it
> makes sense for it to be tunable. Far better IMHO to make it tunable "if
> EMBEDDED"
It doesn't make sense for it to be tunable.
All it does is control whether or not scsi_wait_scan.ko is built.
Everyone who's complained about it has been of the form "I turned off
all modules, but this module gets built anyway". For them, the answer
is simple: Don't run "make modules_install".
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2009-06-22 11:02 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-17 2:07 [PATCH] scsi_wait_scan: no option appears when configuring for scsi_wait_scan Changli Gao
2009-06-17 2:12 ` Matthew Wilcox
2009-06-17 10:07 ` [PATCH] SCSI: explain the hidden scsi_wait_scan Kconfig variable Stefan Richter
2009-06-17 10:28 ` Stefan Richter
2009-06-18 0:57 ` Changli Gao
2009-06-18 15:21 ` James Bottomley
2009-06-18 16:59 ` Sam Ravnborg
2009-06-18 19:03 ` [PATCH update 1] " Stefan Richter
2009-06-18 19:03 ` [PATCH update 2] " Stefan Richter
2009-06-22 8:57 ` Alan Cox
2009-06-22 11:02 ` Matthew Wilcox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.