* [qemu-web PATCH] Gemfile: Add webrick bundle dependency
@ 2021-09-13 18:29 Philippe Mathieu-Daudé
2021-09-14 5:17 ` Thomas Huth
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-13 18:29 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Thomas Huth, John Snow, Philippe Mathieu-Daudé
Without the webrick bundle, jekyll fails to start:
$ bundle exec jekyll serve
Ignoring ffi-1.11.1 because its extensions are not built. Try: gem pristine ffi --version 1.11.1
Configuration file: qemu-web/_config.yml
Source: qemu-web
Destination: qemu-web/_site
Incremental build: disabled. Enable with --incremental
Generating...
Jekyll Feed: Generating feed for posts
done in 0.686 seconds.
Auto-regeneration: enabled for 'qemu-web'
------------------------------------------------
Jekyll 4.0.1 Please append `--trace` to the `serve` command
for any additional information or backtrace.
------------------------------------------------
qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in `require': cannot load such file -- webrick (LoadError)
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in `<top (required)>'
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in `require_relative'
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in `setup'
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:100:in `process'
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `block in process_with_graceful_fail'
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `each'
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `process_with_graceful_fail'
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:86:in `block (2 levels) in init_with_program'
from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/exe/jekyll:15:in `<top (required)>'
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Gemfile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Gemfile b/Gemfile
index 6a7852e..dc35cb7 100644
--- a/Gemfile
+++ b/Gemfile
@@ -25,3 +25,5 @@ end
# for https://github.com/sass/sassc-ruby/issues/146
gem "sassc", ">= 2.2.1"
+
+gem "webrick", "~> 1.7"
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency
2021-09-13 18:29 [qemu-web PATCH] Gemfile: Add webrick bundle dependency Philippe Mathieu-Daudé
@ 2021-09-14 5:17 ` Thomas Huth
2021-09-14 6:31 ` Philippe Mathieu-Daudé
2021-09-14 8:21 ` Daniel P. Berrangé
0 siblings, 2 replies; 8+ messages in thread
From: Thomas Huth @ 2021-09-14 5:17 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, Daniel P. Berrange
Cc: Paolo Bonzini, John Snow
On 13/09/2021 20.29, Philippe Mathieu-Daudé wrote:
> Without the webrick bundle, jekyll fails to start:
>
> $ bundle exec jekyll serve
> Ignoring ffi-1.11.1 because its extensions are not built. Try: gem pristine ffi --version 1.11.1
> Configuration file: qemu-web/_config.yml
> Source: qemu-web
> Destination: qemu-web/_site
> Incremental build: disabled. Enable with --incremental
> Generating...
> Jekyll Feed: Generating feed for posts
> done in 0.686 seconds.
> Auto-regeneration: enabled for 'qemu-web'
> ------------------------------------------------
> Jekyll 4.0.1 Please append `--trace` to the `serve` command
> for any additional information or backtrace.
> ------------------------------------------------
> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in `require': cannot load such file -- webrick (LoadError)
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in `<top (required)>'
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in `require_relative'
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in `setup'
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:100:in `process'
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `block in process_with_graceful_fail'
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `each'
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `process_with_graceful_fail'
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:86:in `block (2 levels) in init_with_program'
> from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
> from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
> from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
> from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
> from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
> from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/exe/jekyll:15:in `<top (required)>'
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Gemfile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Gemfile b/Gemfile
> index 6a7852e..dc35cb7 100644
> --- a/Gemfile
> +++ b/Gemfile
> @@ -25,3 +25,5 @@ end
>
> # for https://github.com/sass/sassc-ruby/issues/146
> gem "sassc", ">= 2.2.1"
> +
> +gem "webrick", "~> 1.7"
Daniel, is this fixing the jekyll problem for you, too?
I'm still on ruby 2.5.9 where this does not occur yet... might be good to
mention that this is a new problem with ruby 3.0 in the cover letter.
Thomas
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency
2021-09-14 5:17 ` Thomas Huth
@ 2021-09-14 6:31 ` Philippe Mathieu-Daudé
2021-09-14 8:21 ` Daniel P. Berrangé
1 sibling, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-14 6:31 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Daniel P. Berrange; +Cc: Paolo Bonzini, John Snow
On 9/14/21 7:17 AM, Thomas Huth wrote:
> On 13/09/2021 20.29, Philippe Mathieu-Daudé wrote:
>> Without the webrick bundle, jekyll fails to start:
>>
>> $ bundle exec jekyll serve
>> Ignoring ffi-1.11.1 because its extensions are not built. Try: gem
>> pristine ffi --version 1.11.1
>> Configuration file: qemu-web/_config.yml
>> Source: qemu-web
>> Destination: qemu-web/_site
>> Incremental build: disabled. Enable with --incremental
>> Generating...
>> Jekyll Feed: Generating feed for posts
>> done in 0.686 seconds.
>> Auto-regeneration: enabled for 'qemu-web'
>> ------------------------------------------------
>> Jekyll 4.0.1 Please append `--trace` to the `serve` command
>> for any additional information or backtrace.
>> ------------------------------------------------
>>
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in
>> `require': cannot load such file -- webrick (LoadError)
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in
>> `<top (required)>'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in
>> `require_relative'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in
>> `setup'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:100:in
>> `process'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in
>> `block in process_with_graceful_fail'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in
>> `each'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in
>> `process_with_graceful_fail'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:86:in
>> `block (2 levels) in init_with_program'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in
>> `block in execute'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in
>> `each'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in
>> `execute'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in
>> `go'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in
>> `program'
>> from
>> qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/exe/jekyll:15:in `<top
>> (required)>'
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Gemfile | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Gemfile b/Gemfile
>> index 6a7852e..dc35cb7 100644
>> --- a/Gemfile
>> +++ b/Gemfile
>> @@ -25,3 +25,5 @@ end
>> # for https://github.com/sass/sassc-ruby/issues/146
>> gem "sassc", ">= 2.2.1"
>> +
>> +gem "webrick", "~> 1.7"
>
> Daniel, is this fixing the jekyll problem for you, too?
>
> I'm still on ruby 2.5.9 where this does not occur yet... might be good
> to mention that this is a new problem with ruby 3.0 in the cover letter.
I'll also mention I'm using Fedora 34.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency
2021-09-14 5:17 ` Thomas Huth
2021-09-14 6:31 ` Philippe Mathieu-Daudé
@ 2021-09-14 8:21 ` Daniel P. Berrangé
2021-09-15 22:27 ` Paolo Bonzini
1 sibling, 1 reply; 8+ messages in thread
From: Daniel P. Berrangé @ 2021-09-14 8:21 UTC (permalink / raw)
To: Thomas Huth
Cc: John Snow, Philippe Mathieu-Daudé, qemu-devel, Paolo Bonzini
On Tue, Sep 14, 2021 at 07:17:11AM +0200, Thomas Huth wrote:
> On 13/09/2021 20.29, Philippe Mathieu-Daudé wrote:
> > Without the webrick bundle, jekyll fails to start:
> >
> > $ bundle exec jekyll serve
> > Ignoring ffi-1.11.1 because its extensions are not built. Try: gem pristine ffi --version 1.11.1
> > Configuration file: qemu-web/_config.yml
> > Source: qemu-web
> > Destination: qemu-web/_site
> > Incremental build: disabled. Enable with --incremental
> > Generating...
> > Jekyll Feed: Generating feed for posts
> > done in 0.686 seconds.
> > Auto-regeneration: enabled for 'qemu-web'
> > ------------------------------------------------
> > Jekyll 4.0.1 Please append `--trace` to the `serve` command
> > for any additional information or backtrace.
> > ------------------------------------------------
> > qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in `require': cannot load such file -- webrick (LoadError)
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve/servlet.rb:3:in `<top (required)>'
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in `require_relative'
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:179:in `setup'
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:100:in `process'
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `block in process_with_graceful_fail'
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `each'
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `process_with_graceful_fail'
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:86:in `block (2 levels) in init_with_program'
> > from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
> > from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
> > from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
> > from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
> > from qemu-web/vendor/ruby/3.0.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
> > from qemu-web/vendor/ruby/3.0.0/gems/jekyll-4.0.1/exe/jekyll:15:in `<top (required)>'
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > Gemfile | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Gemfile b/Gemfile
> > index 6a7852e..dc35cb7 100644
> > --- a/Gemfile
> > +++ b/Gemfile
> > @@ -25,3 +25,5 @@ end
> > # for https://github.com/sass/sassc-ruby/issues/146
> > gem "sassc", ">= 2.2.1"
> > +
> > +gem "webrick", "~> 1.7"
>
> Daniel, is this fixing the jekyll problem for you, too?
>
> I'm still on ruby 2.5.9 where this does not occur yet... might be good to
> mention that this is a new problem with ruby 3.0 in the cover letter.
Yes, this is needed to fix Ruby 3.
I didn't propose it myself as I'm not sure if it in turn breaks people
with Ruby 2.x ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency
2021-09-14 8:21 ` Daniel P. Berrangé
@ 2021-09-15 22:27 ` Paolo Bonzini
2021-09-16 4:24 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 8+ messages in thread
From: Paolo Bonzini @ 2021-09-15 22:27 UTC (permalink / raw)
To: Daniel P. Berrangé, Thomas Huth
Cc: John Snow, Philippe Mathieu-Daudé, qemu-devel
On 14/09/21 10:21, Daniel P. Berrangé wrote:
> Yes, this is needed to fix Ruby 3.
>
> I didn't propose it myself as I'm not sure if it in turn breaks people
> with Ruby 2.x ?
Does it pass the GitLab CI (which uses 2.5)?
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency
2021-09-15 22:27 ` Paolo Bonzini
@ 2021-09-16 4:24 ` Philippe Mathieu-Daudé
2021-09-16 4:55 ` Thomas Huth
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-16 4:24 UTC (permalink / raw)
To: Paolo Bonzini, Daniel P. Berrangé, Thomas Huth; +Cc: John Snow, qemu-devel
On 9/16/21 12:27 AM, Paolo Bonzini wrote:
> On 14/09/21 10:21, Daniel P. Berrangé wrote:
>> Yes, this is needed to fix Ruby 3.
>>
>> I didn't propose it myself as I'm not sure if it in turn breaks people
>> with Ruby 2.x ?
>
> Does it pass the GitLab CI (which uses 2.5)?
Yes:
https://gitlab.com/philmd/qemu-web/-/jobs/1594757246#L466
Installing webrick 1.7.0
Bundle complete! 5 Gemfile dependencies, 32 gems now installed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency
2021-09-16 4:24 ` Philippe Mathieu-Daudé
@ 2021-09-16 4:55 ` Thomas Huth
2021-09-16 5:03 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Huth @ 2021-09-16 4:55 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Paolo Bonzini, Daniel P. Berrangé
Cc: John Snow, qemu-devel
On 16/09/2021 06.24, Philippe Mathieu-Daudé wrote:
> On 9/16/21 12:27 AM, Paolo Bonzini wrote:
>> On 14/09/21 10:21, Daniel P. Berrangé wrote:
>>> Yes, this is needed to fix Ruby 3.
>>>
>>> I didn't propose it myself as I'm not sure if it in turn breaks people
>>> with Ruby 2.x ?
>>
>> Does it pass the GitLab CI (which uses 2.5)?
>
> Yes:
> https://gitlab.com/philmd/qemu-web/-/jobs/1594757246#L466
> Installing webrick 1.7.0
> Bundle complete! 5 Gemfile dependencies, 32 gems now installed.
The patch is also not breaking anything for me here (with Ruby 2.5.9).
Pushed now.
Thanks,
Thomas
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency
2021-09-16 4:55 ` Thomas Huth
@ 2021-09-16 5:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-16 5:03 UTC (permalink / raw)
To: Thomas Huth, Paolo Bonzini, Daniel P. Berrangé; +Cc: John Snow, qemu-devel
On 9/16/21 6:55 AM, Thomas Huth wrote:
> On 16/09/2021 06.24, Philippe Mathieu-Daudé wrote:
>> On 9/16/21 12:27 AM, Paolo Bonzini wrote:
>>> On 14/09/21 10:21, Daniel P. Berrangé wrote:
>>>> Yes, this is needed to fix Ruby 3.
>>>>
>>>> I didn't propose it myself as I'm not sure if it in turn breaks people
>>>> with Ruby 2.x ?
>>>
>>> Does it pass the GitLab CI (which uses 2.5)?
>>
>> Yes:
>> https://gitlab.com/philmd/qemu-web/-/jobs/1594757246#L466
>> Installing webrick 1.7.0
>> Bundle complete! 5 Gemfile dependencies, 32 gems now installed.
>
> The patch is also not breaking anything for me here (with Ruby 2.5.9).
> Pushed now.
That was fast! Thanks :)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-16 5:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 18:29 [qemu-web PATCH] Gemfile: Add webrick bundle dependency Philippe Mathieu-Daudé
2021-09-14 5:17 ` Thomas Huth
2021-09-14 6:31 ` Philippe Mathieu-Daudé
2021-09-14 8:21 ` Daniel P. Berrangé
2021-09-15 22:27 ` Paolo Bonzini
2021-09-16 4:24 ` Philippe Mathieu-Daudé
2021-09-16 4:55 ` Thomas Huth
2021-09-16 5:03 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.