All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/bnxt: fix compilation
@ 2017-10-09 13:59 Mark Kavanagh
  2017-10-09 14:14 ` [dpdk-stable] " De Lara Guarch, Pablo
  2017-10-09 17:34 ` Ferruh Yigit
  0 siblings, 2 replies; 6+ messages in thread
From: Mark Kavanagh @ 2017-10-09 13:59 UTC (permalink / raw)
  To: dev; +Cc: stable, ferruh.yigit, ajit.khaparde, Mark Kavanagh

As of 5ef3b79fdfe6f, compilation of DPDK fails with the following
error message:
"bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]".

Resolve this by initializing 'vnic' to NULL;

Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
CC: stable@dpdk.org

Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
---
 drivers/net/bnxt/bnxt_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c
index d470be2..9f171fd 100644
--- a/drivers/net/bnxt/bnxt_filter.c
+++ b/drivers/net/bnxt/bnxt_filter.c
@@ -906,7 +906,7 @@ struct bnxt_filter_info *
 {
 	struct bnxt *bp = (struct bnxt *)dev->data->dev_private;
 	struct bnxt_filter_info *filter;
-	struct bnxt_vnic_info *vnic;
+	struct bnxt_vnic_info *vnic = NULL;
 	struct rte_flow *flow;
 	unsigned int i;
 	int ret = 0;
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH] net/bnxt: fix compilation
  2017-10-09 13:59 [PATCH] net/bnxt: fix compilation Mark Kavanagh
@ 2017-10-09 14:14 ` De Lara Guarch, Pablo
  2017-10-09 14:28   ` Kavanagh, Mark B
  2017-10-09 17:34 ` Ferruh Yigit
  1 sibling, 1 reply; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2017-10-09 14:14 UTC (permalink / raw)
  To: Kavanagh, Mark B, dev
  Cc: stable, Yigit, Ferruh, ajit.khaparde, Kavanagh, Mark B



> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Mark
> Kavanagh
> Sent: Monday, October 9, 2017 3:00 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> ajit.khaparde@broadcom.com; Kavanagh, Mark B
> <mark.b.kavanagh@intel.com>
> Subject: [dpdk-stable] [PATCH] net/bnxt: fix compilation
> 
> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following error
> message:
> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]".
> 
> Resolve this by initializing 'vnic' to NULL;
> 
> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
> CC: stable@dpdk.org

Hi Mark,

You don't need to cc stable, since you are fixing code that was sent in this release.
Only fixes for patches sent in previous DPDK versions need to be applied to the stable repo.

Regards,
Pablo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH] net/bnxt: fix compilation
  2017-10-09 14:14 ` [dpdk-stable] " De Lara Guarch, Pablo
@ 2017-10-09 14:28   ` Kavanagh, Mark B
  0 siblings, 0 replies; 6+ messages in thread
From: Kavanagh, Mark B @ 2017-10-09 14:28 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, dev; +Cc: Yigit, Ferruh, ajit.khaparde

>From: De Lara Guarch, Pablo
>Sent: Monday, October 9, 2017 3:15 PM
>To: Kavanagh, Mark B <mark.b.kavanagh@intel.com>; dev@dpdk.org
>Cc: stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
>ajit.khaparde@broadcom.com; Kavanagh, Mark B <mark.b.kavanagh@intel.com>
>Subject: RE: [dpdk-stable] [PATCH] net/bnxt: fix compilation
>
>
>
>> -----Original Message-----
>> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Mark
>> Kavanagh
>> Sent: Monday, October 9, 2017 3:00 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> ajit.khaparde@broadcom.com; Kavanagh, Mark B
>> <mark.b.kavanagh@intel.com>
>> Subject: [dpdk-stable] [PATCH] net/bnxt: fix compilation
>>
>> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following error
>> message:
>> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
>> function [-Werror=maybe-uninitialized]".
>>
>> Resolve this by initializing 'vnic' to NULL;
>>
>> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
>> CC: stable@dpdk.org
>
>Hi Mark,
>
>You don't need to cc stable, since you are fixing code that was sent in this
>release.
>Only fixes for patches sent in previous DPDK versions need to be applied to
>the stable repo.

Thanks for the clarification Pablo - makes sense.

Removing stable@dpdk.org from this thread.

Cheers,
Mark

>
>Regards,
>Pablo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] net/bnxt: fix compilation
  2017-10-09 13:59 [PATCH] net/bnxt: fix compilation Mark Kavanagh
  2017-10-09 14:14 ` [dpdk-stable] " De Lara Guarch, Pablo
@ 2017-10-09 17:34 ` Ferruh Yigit
  2017-10-10  7:40   ` Kavanagh, Mark B
  1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2017-10-09 17:34 UTC (permalink / raw)
  To: Mark Kavanagh, dev; +Cc: ajit.khaparde

On 10/9/2017 2:59 PM, Mark Kavanagh wrote:
> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following
> error message:
> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]".
> 
> Resolve this by initializing 'vnic' to NULL;
> 
> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")

> 
> Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>

Applied to dpdk-next-net/master, thanks.

Can you please provide compiler and version information?
I get the commit for now and will update it later with that information.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] net/bnxt: fix compilation
  2017-10-09 17:34 ` Ferruh Yigit
@ 2017-10-10  7:40   ` Kavanagh, Mark B
  2017-10-10 16:45     ` Ferruh Yigit
  0 siblings, 1 reply; 6+ messages in thread
From: Kavanagh, Mark B @ 2017-10-10  7:40 UTC (permalink / raw)
  To: Yigit, Ferruh, dev; +Cc: ajit.khaparde

>From: Yigit, Ferruh
>Sent: Monday, October 9, 2017 6:34 PM
>To: Kavanagh, Mark B <mark.b.kavanagh@intel.com>; dev@dpdk.org
>Cc: ajit.khaparde@broadcom.com
>Subject: Re: [PATCH] net/bnxt: fix compilation
>
>On 10/9/2017 2:59 PM, Mark Kavanagh wrote:
>> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following
>> error message:
>> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
>> function [-Werror=maybe-uninitialized]".
>>
>> Resolve this by initializing 'vnic' to NULL;
>>
>> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
>
>>
>> Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
>
>Applied to dpdk-next-net/master, thanks.
>
>Can you please provide compiler and version information?
>I get the commit for now and will update it later with that information.

Thanks Ferruh - compiler info is as follows:

   gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)

Best,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] net/bnxt: fix compilation
  2017-10-10  7:40   ` Kavanagh, Mark B
@ 2017-10-10 16:45     ` Ferruh Yigit
  0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2017-10-10 16:45 UTC (permalink / raw)
  To: Kavanagh, Mark B, dev; +Cc: ajit.khaparde

On 10/10/2017 8:40 AM, Kavanagh, Mark B wrote:
>> From: Yigit, Ferruh
>> Sent: Monday, October 9, 2017 6:34 PM
>> To: Kavanagh, Mark B <mark.b.kavanagh@intel.com>; dev@dpdk.org
>> Cc: ajit.khaparde@broadcom.com
>> Subject: Re: [PATCH] net/bnxt: fix compilation
>>
>> On 10/9/2017 2:59 PM, Mark Kavanagh wrote:
>>> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following
>>> error message:
>>> "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this
>>> function [-Werror=maybe-uninitialized]".
>>>
>>> Resolve this by initializing 'vnic' to NULL;
>>>
>>> Fixes: 5ef3b79fdfe6f ("net/bnxt: support flow filter ops")
>>
>>>
>>> Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
>>
>> Applied to dpdk-next-net/master, thanks.
>>
>> Can you please provide compiler and version information?
>> I get the commit for now and will update it later with that information.
> 
> Thanks Ferruh - compiler info is as follows:
> 
>    gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)

Updated commit log, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-10-10 16:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-09 13:59 [PATCH] net/bnxt: fix compilation Mark Kavanagh
2017-10-09 14:14 ` [dpdk-stable] " De Lara Guarch, Pablo
2017-10-09 14:28   ` Kavanagh, Mark B
2017-10-09 17:34 ` Ferruh Yigit
2017-10-10  7:40   ` Kavanagh, Mark B
2017-10-10 16:45     ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.