Re: [PATCH] s390: disable -Warray-bounds

From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, dchinner@redhat.com,
	Kees Cook <keescook@chromium.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390: disable -Warray-bounds
Date: Thu, 09 Jun 2022 15:14:39 +0100	[thread overview]
Message-ID: <4147483.1654784079@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHk-=wh6+KUi+T8Ncn6BWTHDTJCzrJxgT47SWbq-ZWs1_vbvHA@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> > Yeah. Happily, this has already been solved, but it looks like David didn't do a pull yet for it?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-next
> 
> Good.

Do you want it tagging and a pull req generating, even though it's a single
patch?

Note that Dave Chinner would rather I converted code like:

	struct myfs_inode *myfsinode = xyz;
	myfsinode->netfs.inode.i_ino = 123;

to something like:

	struct myfs_inode *myfsinode = xyz;
	struct inode *inode = VFS_I(myfsinode);
	inode->i_ino = 123;

where the translation is wrapped inside a VFS_I() macro in every filesystem
and wants this across all filesystems.  I think the former looks cleaner, but
he has a point about how to deal with yet another layer of wrapping being
inserted in the future.  Do you have a preference?

David