From: Linus Torvalds <torvalds@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
David Howells <dhowells@redhat.com>,
Sven Schnelle <svens@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390: disable -Warray-bounds
Date: Wed, 8 Jun 2022 18:22:18 -0700 [thread overview]
Message-ID: <CAHk-=wh6+KUi+T8Ncn6BWTHDTJCzrJxgT47SWbq-ZWs1_vbvHA@mail.gmail.com> (raw)
In-Reply-To: <AEEBCF5D-8402-441D-940B-105AA718C71F@chromium.org>
On Wed, Jun 8, 2022 at 5:39 PM Kees Cook <keescook@chromium.org> wrote:
>
> I'll take a look; thanks! Should I send them back as a pull request?
That would be good.
> Yeah. Happily, this has already been solved, but it looks like David didn't do a pull yet for it?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-next
Good.
> For gcc's UBSAN_SHIFT (I typoed this in my first reply) bug, netdev has been moving it to W=1 builds on a per-source basis for the moment:
>
> https://git.kernel.org/linus/e95032988053c17baf6c7e27024f5103a19a5f4a
Ugh. That's sad. Since now the gcc-12 misfeature ends up biting
everybody else too.
> Perhaps these could be even more carefully limited to GCC 12 only, using the Kconfig you suggested?
Yeah, I'd rather just say "gcc-12 gets this thing entirely wrong,
let's disable it there" than disable it for compilers that get it
right.
In fact, I'd rather have that global "gcc-12 is broken, disable it",
than marking "this file shouldn't get checked" kind of logic.
It's wrong blaming the C code, when the compiler is doing bad sh*t.
Linus
next prev parent reply other threads:[~2022-06-09 1:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:43 [PATCH] s390: disable -Warray-bounds Sven Schnelle
2022-04-22 17:54 ` Kees Cook
2022-04-25 9:13 ` Heiko Carstens
2022-06-08 20:07 ` Linus Torvalds
2022-06-08 21:33 ` Kees Cook
2022-06-08 23:59 ` Linus Torvalds
2022-06-09 0:39 ` Kees Cook
2022-06-09 1:22 ` Linus Torvalds [this message]
2022-06-09 9:56 ` Philipp Zabel
2022-06-09 13:02 ` Kees Cook
2022-06-09 14:14 ` David Howells
2022-06-09 18:20 ` Linus Torvalds
2022-06-09 23:59 ` Dave Chinner
2022-06-10 1:18 ` Linus Torvalds
2022-06-09 9:56 ` Philipp Zabel
2022-06-09 14:55 ` Nathan Chancellor
2022-06-09 18:51 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh6+KUi+T8Ncn6BWTHDTJCzrJxgT47SWbq-ZWs1_vbvHA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=agordeev@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=festevam@gmail.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.