* [PATCH 2.6 5/7]: Fix ipip_fb_tunnel_dev leak in ipip_fini
@ 2004-10-03 21:13 Patrick McHardy
0 siblings, 0 replies; only message in thread
From: Patrick McHardy @ 2004-10-03 21:13 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 135 bytes --]
ipip_fb_tunnel_dev doesn't have a destructor set
and is not freed manually. Set the destructor in
ipip_tunnel_setup to fix the leak.
[-- Attachment #2: 05.diff --]
[-- Type: text/x-patch, Size: 1029 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/10/03 20:42:17+02:00 kaber@coreworks.de
# [IPV4]: Fix ipip_fb_tunnel_dev leak in ipip_fini
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/ipv4/ipip.c
# 2004/10/03 20:41:38+02:00 kaber@coreworks.de +1 -1
# [IPV4]: Fix ipip_fb_tunnel_dev leak in ipip_fini
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
diff -Nru a/net/ipv4/ipip.c b/net/ipv4/ipip.c
--- a/net/ipv4/ipip.c 2004-10-03 22:20:49 +02:00
+++ b/net/ipv4/ipip.c 2004-10-03 22:20:49 +02:00
@@ -246,7 +246,6 @@
nt = dev->priv;
SET_MODULE_OWNER(dev);
dev->init = ipip_tunnel_init;
- dev->destructor = free_netdev;
nt->parms = *parms;
if (register_netdevice(dev) < 0) {
@@ -784,6 +783,7 @@
dev->get_stats = ipip_tunnel_get_stats;
dev->do_ioctl = ipip_tunnel_ioctl;
dev->change_mtu = ipip_tunnel_change_mtu;
+ dev->destructor = free_netdev;
dev->type = ARPHRD_TUNNEL;
dev->hard_header_len = LL_MAX_HEADER + sizeof(struct iphdr);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-10-03 21:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-03 21:13 [PATCH 2.6 5/7]: Fix ipip_fb_tunnel_dev leak in ipip_fini Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.