All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: make get_color_space_type() static
@ 2020-09-28  2:36 ` Jason Yan
  0 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-09-28  2:36 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, amd-gfx, dri-devel

This addresses the following sparse warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
warning: symbol 'get_color_space_type' was not declared. Should it be
static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
index c026b393f3c5..2a9080400bdd 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
@@ -177,7 +177,7 @@ static bool is_ycbcr709_limited_type(
 		ret = true;
 	return ret;
 }
-enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
+static enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
 {
 	enum dc_color_space_type type = COLOR_SPACE_RGB_TYPE;
 
-- 
2.25.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/amd/display: make get_color_space_type() static
@ 2020-09-28  2:36 ` Jason Yan
  0 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-09-28  2:36 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, amd-gfx, dri-devel

This addresses the following sparse warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
warning: symbol 'get_color_space_type' was not declared. Should it be
static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
index c026b393f3c5..2a9080400bdd 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
@@ -177,7 +177,7 @@ static bool is_ycbcr709_limited_type(
 		ret = true;
 	return ret;
 }
-enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
+static enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
 {
 	enum dc_color_space_type type = COLOR_SPACE_RGB_TYPE;
 
-- 
2.25.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: make get_color_space_type() static
  2020-09-28  2:36 ` Jason Yan
@ 2020-09-28 14:06   ` Harry Wentland
  -1 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2020-09-28 14:06 UTC (permalink / raw)
  To: Jason Yan, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, amd-gfx, dri-devel

On 2020-09-27 10:36 p.m., Jason Yan wrote:
> This addresses the following sparse warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
> warning: symbol 'get_color_space_type' was not declared. Should it be
> static?
> 

If you have multiple fixes of the same or similar nature in the same
subsystem (e.g. drm/amd/display) I would prefer a single patch to fix
all of them. These really only need separate patches if they go outside
a subsystem.

I see a lot of these tiny static checker patches from Huawei and while I
appreciate small patches I feel these are needlessly small.

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> index c026b393f3c5..2a9080400bdd 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> @@ -177,7 +177,7 @@ static bool is_ycbcr709_limited_type(
>  		ret = true;
>  	return ret;
>  }
> -enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
> +static enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
>  {
>  	enum dc_color_space_type type = COLOR_SPACE_RGB_TYPE;
>  
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: make get_color_space_type() static
@ 2020-09-28 14:06   ` Harry Wentland
  0 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2020-09-28 14:06 UTC (permalink / raw)
  To: Jason Yan, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, amd-gfx, dri-devel

On 2020-09-27 10:36 p.m., Jason Yan wrote:
> This addresses the following sparse warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
> warning: symbol 'get_color_space_type' was not declared. Should it be
> static?
> 

If you have multiple fixes of the same or similar nature in the same
subsystem (e.g. drm/amd/display) I would prefer a single patch to fix
all of them. These really only need separate patches if they go outside
a subsystem.

I see a lot of these tiny static checker patches from Huawei and while I
appreciate small patches I feel these are needlessly small.

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> index c026b393f3c5..2a9080400bdd 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> @@ -177,7 +177,7 @@ static bool is_ycbcr709_limited_type(
>  		ret = true;
>  	return ret;
>  }
> -enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
> +static enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
>  {
>  	enum dc_color_space_type type = COLOR_SPACE_RGB_TYPE;
>  
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: make get_color_space_type() static
  2020-09-28 14:06   ` Harry Wentland
@ 2020-09-28 21:34     ` Alex Deucher
  -1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2020-09-28 21:34 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Jason Yan, Leo (Sunpeng) Li, amd-gfx list, Dave Airlie,
	Maling list - DRI developers, Deucher, Alexander,
	Christian Koenig

Applied.  Thanks!

On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2020-09-27 10:36 p.m., Jason Yan wrote:
> > This addresses the following sparse warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
> > warning: symbol 'get_color_space_type' was not declared. Should it be
> > static?
> >
>
> If you have multiple fixes of the same or similar nature in the same
> subsystem (e.g. drm/amd/display) I would prefer a single patch to fix
> all of them. These really only need separate patches if they go outside
> a subsystem.
>
> I see a lot of these tiny static checker patches from Huawei and while I
> appreciate small patches I feel these are needlessly small.
>
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > index c026b393f3c5..2a9080400bdd 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > @@ -177,7 +177,7 @@ static bool is_ycbcr709_limited_type(
> >               ret = true;
> >       return ret;
> >  }
> > -enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
> > +static enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
> >  {
> >       enum dc_color_space_type type = COLOR_SPACE_RGB_TYPE;
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: make get_color_space_type() static
@ 2020-09-28 21:34     ` Alex Deucher
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2020-09-28 21:34 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Jason Yan, Leo (Sunpeng) Li, amd-gfx list, Dave Airlie,
	Maling list - DRI developers, Daniel Vetter, Deucher, Alexander,
	Christian Koenig

Applied.  Thanks!

On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2020-09-27 10:36 p.m., Jason Yan wrote:
> > This addresses the following sparse warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
> > warning: symbol 'get_color_space_type' was not declared. Should it be
> > static?
> >
>
> If you have multiple fixes of the same or similar nature in the same
> subsystem (e.g. drm/amd/display) I would prefer a single patch to fix
> all of them. These really only need separate patches if they go outside
> a subsystem.
>
> I see a lot of these tiny static checker patches from Huawei and while I
> appreciate small patches I feel these are needlessly small.
>
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > index c026b393f3c5..2a9080400bdd 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > @@ -177,7 +177,7 @@ static bool is_ycbcr709_limited_type(
> >               ret = true;
> >       return ret;
> >  }
> > -enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
> > +static enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
> >  {
> >       enum dc_color_space_type type = COLOR_SPACE_RGB_TYPE;
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-28 21:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28  2:36 [PATCH] drm/amd/display: make get_color_space_type() static Jason Yan
2020-09-28  2:36 ` Jason Yan
2020-09-28 14:06 ` Harry Wentland
2020-09-28 14:06   ` Harry Wentland
2020-09-28 21:34   ` Alex Deucher
2020-09-28 21:34     ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.