[Buildroot] [PATCH] package/libgeos: fix build failure due to Gcc Bug 68485

[Buildroot] [PATCH] package/libgeos: fix build failure due to Gcc Bug 68485

[Giulio Benetti]

Package libgeos manifests Microblaze Gcc Bug 68485 resulting in a build
failure due to an Internal Compiler Error.

As done for other packages in Buildroot work around this Gcc Bug by
setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.

Fixes:
http://autobuild.buildroot.net/results/0da/0daa6b259aea5381fad86d01e6dd026b1c8ad073/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libgeos/libgeos.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/libgeos/libgeos.mk b/package/libgeos/libgeos.mk
index 50c3832c01..a355732af8 100644
--- a/package/libgeos/libgeos.mk
+++ b/package/libgeos/libgeos.mk
@@ -13,8 +13,16 @@ LIBGEOS_INSTALL_STAGING = YES
 LIBGEOS_CONFIG_SCRIPTS = geos-config
 LIBGEOS_CONF_OPTS = -DBUILD_BENCHMARKS=OFF
 
+LIBGEOS_CXXFLAGS = $(TARGET_CXXCFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+LIBGEOS_CXXFLAGS += -O0
+endif
+
 ifeq ($(BR2_arm)$(BR2_armeb),y)
 LIBGEOS_CONF_OPTS += -DDISABLE_GEOS_INLINE=ON
 endif
 
+LIBGEOS_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(LIBGEOS_CXXFLAGS)"
+
 $(eval $(cmake-package))
-- 
2.25.1

[Buildroot] [PATCH] package/libgeos: fix build failure due to Gcc Bug 68485

[Thomas Petazzoni]

Hello Giulio,

On Fri, 12 Feb 2021 23:42:38 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Package libgeos manifests Microblaze Gcc Bug 68485 resulting in a build
> failure due to an Internal Compiler Error.
> 
> As done for other packages in Buildroot work around this Gcc Bug by
> setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.
> 
> Fixes:
> http://autobuild.buildroot.net/results/0da/0daa6b259aea5381fad86d01e6dd026b1c8ad073/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/libgeos/libgeos.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)

Applied to master, thanks. Could you check if this bug still exists
with gcc 10.x, and if it does, ping on the gcc bug report ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/libgeos: fix build failure due to Gcc Bug 68485

[Giulio Benetti]

Hi Thomas,

On 2/13/21 10:51 PM, Thomas Petazzoni wrote:
> Hello Giulio,
> 
> On Fri, 12 Feb 2021 23:42:38 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> Package libgeos manifests Microblaze Gcc Bug 68485 resulting in a build
>> failure due to an Internal Compiler Error.
>>
>> As done for other packages in Buildroot work around this Gcc Bug by
>> setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/0da/0daa6b259aea5381fad86d01e6dd026b1c8ad073/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   package/libgeos/libgeos.mk | 8 ++++++++
>>   1 file changed, 8 insertions(+)
> 
> Applied to master, thanks. Could you check if this bug still exists
> with gcc 10.x, and if it does, ping on the gcc bug report ?

I've just tried to build with gcc 10.2 and unfortunately it still have 
that bug. So I've just pinged gcc bug report:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485#add_comment

Let's see what they answer.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

[Buildroot] [PATCH] package/libgeos: fix build failure due to Gcc Bug 68485

[Thomas Petazzoni]

On Mon, 15 Feb 2021 00:46:35 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> > Applied to master, thanks. Could you check if this bug still exists
> > with gcc 10.x, and if it does, ping on the gcc bug report ?  
> 
> I've just tried to build with gcc 10.2 and unfortunately it still have 
> that bug. So I've just pinged gcc bug report:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485#add_comment

Thanks for having done the extra research and following up with the gcc
developers!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/libgeos: fix build failure due to Gcc Bug 68485

[Giulio Benetti]

> Il giorno 15 feb 2021, alle ore 09:59, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> 
> ?On Mon, 15 Feb 2021 00:46:35 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>>> Applied to master, thanks. Could you check if this bug still exists
>>> with gcc 10.x, and if it does, ping on the gcc bug report ?  
>> 
>> I've just tried to build with gcc 10.2 and unfortunately it still have 
>> that bug. So I've just pinged gcc bug report:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485#add_comment
> 
> Thanks for having done the extra research and following up with the gcc
> developers!

Happy to do this, it?s in the interest of everyone :-)

Giulio

> 
> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com